WindowServer: Fix xbanan access check

Instead of calculating bit-by-bit crc32, we now calculate a lookup table
during compile time. The old crc32 calculation was taking almost 50% of
the decompression time.

Also handle multiple symbols at once without outputting to user. It is
much more efficient to output many bytes instead of the up to 258 that a
single symbol can decode to :^)

.clangd

@@ -0,0 +1,13 @@
+Diagnostics:
+  Suppress: target_unsupported_type
+
+CompileFlags:
+  Remove: [
+    -fstrict-volatile-bitfields,
+    -fno-tree-loop-distribute-patterns
+  ]
+  Add: [
+    -D__banan_os__,
+    -D__arch__=x86_64,
+    -D__x86_64__
+  ]

.gitignore

@@ -3,3 +3,4 @@
 build/
 base/
 script/fakeroot-context
+tools/update-image-perms

.vscode/c_cpp_properties.json

@@ -8,7 +8,8 @@
                 "${workspaceFolder}/userspace/libraries/*/include"
             ],
             "defines": [
-				"__arch=x86_64"
+                "__arch=x86_64",
+                "__enable_sse=1"
             ],
             "compilerPath": "${workspaceFolder}/toolchain/local/bin/x86_64-banan_os-gcc",
             "cStandard": "c17",
@@ -24,7 +25,8 @@
             ],
             "defines": [
                 "__arch=x86_64",
-				"__is_kernel"
+                "__is_kernel",
+                "__enable_sse=1"
             ],
             "compilerPath": "${workspaceFolder}/toolchain/local/bin/x86_64-banan_os-gcc",
             "cStandard": "c17",

.vscode/settings.json

@@ -2,5 +2,9 @@
     "cmake.configureOnOpen": false,
     "editor.tabSize": 4,
     "editor.insertSpaces": false,
-    "editor.detectIndentation": false
+    "editor.detectIndentation": false,
+    "clangd.arguments": [
+        "--compile-commands-dir=${workspaceFolder}/build",
+        "-header-insertion=never"
+    ]
 }

BAN/CMakeLists.txt

@@ -6,7 +6,13 @@ set(BAN_SOURCES
 )
 
 add_library(ban ${BAN_SOURCES})
+target_link_options(ban PRIVATE -nolibc)
 banan_link_library(ban libc)
 
+set_target_properties(ban PROPERTIES OUTPUT_NAME libban)
+
+# set SONAME as cmake doesn't set it for some reason??
+set_target_properties(ban PROPERTIES LINK_FLAGS "-Wl,-soname,libban.so")
+
 banan_install_headers(ban)
 install(TARGETS ban OPTIONAL)

BAN/include/BAN/Array.h

@@ -18,78 +18,78 @@ namespace BAN
 		using const_iterator = ConstIteratorSimple<T, Array>;
 
 	public:
-		Array() = default;
+		constexpr Array() = default;
-		Array(const T&);
+		constexpr Array(const T&);
 
 		iterator begin() { return iterator(m_data); }
 		iterator end() { return iterator(m_data + size()); }
 		const_iterator begin() const { return const_iterator(m_data); }
 		const_iterator end() const { return const_iterator(m_data + size()); }
 
-		const T& operator[](size_type) const;
+		constexpr const T& operator[](size_type) const;
-		T& operator[](size_type);
+		constexpr T& operator[](size_type);
 
-		const T& back() const;
+		constexpr const T& back() const;
-		T& back();
+		constexpr T& back();
-		const T& front() const;
+		constexpr const T& front() const;
-		T& front();
+		constexpr T& front();
 
 		Span<T> span() { return Span(m_data, size()); }
-		const Span<T> span() const { return Span(m_data, size()); }
+		Span<const T> span() const { return Span(m_data, size()); }
 
 		constexpr size_type size() const;
 
-		const T* data() const { return m_data; }
+		constexpr const T* data() const { return m_data; }
-		T* data() { return m_data; }
+		constexpr T* data() { return m_data; }
 
 	private:
 		T m_data[S] {};
 	};
 
 	template<typename T, size_t S>
-	Array<T, S>::Array(const T& value)
+	constexpr Array<T, S>::Array(const T& value)
 	{
 		for (size_type i = 0; i < S; i++)
 			m_data[i] = value;
 	}
 
 	template<typename T, size_t S>
-	const T& Array<T, S>::operator[](size_type index) const
+	constexpr const T& Array<T, S>::operator[](size_type index) const
 	{
 		ASSERT(index < S);
 		return m_data[index];
 	}
 
 	template<typename T, size_t S>
-	T& Array<T, S>::operator[](size_type index)
+	constexpr T& Array<T, S>::operator[](size_type index)
 	{
 		ASSERT(index < S);
 		return m_data[index];
 	}
 
 	template<typename T, size_t S>
-	const T& Array<T, S>::back() const
+	constexpr const T& Array<T, S>::back() const
 	{
 		ASSERT(S != 0);
 		return m_data[S - 1];
 	}
 
 	template<typename T, size_t S>
-	T& Array<T, S>::back()
+	constexpr T& Array<T, S>::back()
 	{
 		ASSERT(S != 0);
 		return m_data[S - 1];
 	}
 
 	template<typename T, size_t S>
-	const T& Array<T, S>::front() const
+	constexpr const T& Array<T, S>::front() const
 	{
 		ASSERT(S != 0);
 		return m_data[0];
 	}
 
 	template<typename T, size_t S>
-	T& Array<T, S>::front()
+	constexpr T& Array<T, S>::front()
 	{
 		ASSERT(S != 0);
 		return m_data[0];

BAN/include/BAN/Atomic.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <BAN/Traits.h>
+
 namespace BAN
 {
 
@@ -13,8 +15,36 @@ namespace BAN
 		memory_order_seq_cst = __ATOMIC_SEQ_CST,
 	};
 
-	template<typename T, MemoryOrder MEM_ORDER = MemoryOrder::memory_order_seq_cst>
+	template<typename T> concept atomic_c = is_integral_v<T> || is_pointer_v<T>;
-	requires requires { __atomic_always_lock_free(sizeof(T), 0); }
+	template<typename T> concept atomic_lockfree_c = (is_integral_v<T> || is_pointer_v<T>) && __atomic_always_lock_free(sizeof(T), 0);
+
+	template<atomic_lockfree_c T, atomic_c U>
+	inline void atomic_store(T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { __atomic_store_n(&obj, value, mem_order); }
+	template<atomic_lockfree_c T>
+	inline T atomic_load(T& obj, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_load_n(&obj, mem_order); }
+
+	template<atomic_lockfree_c T, atomic_c U>
+	inline T atomic_exchange(T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_exchange_n(&obj, value, mem_order); }
+	template<atomic_lockfree_c T, atomic_lockfree_c U, atomic_c V>
+	inline bool atomic_compare_exchange(T& obj, U& expected, V value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_compare_exchange_n(&obj, &expected, value, false, mem_order, mem_order); }
+
+#define DECL_ATOMIC_INLINE template<atomic_lockfree_c T, atomic_c U> inline
+	DECL_ATOMIC_INLINE T atomic_add_fetch (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_add_fetch (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_sub_fetch (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_sub_fetch (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_and_fetch (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_and_fetch (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_xor_fetch (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_xor_fetch (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_or_fetch  (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_or_fetch  (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_nand_fetch(T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_nand_fetch(&obj, value, mem_order); }
+
+	DECL_ATOMIC_INLINE T atomic_fetch_add (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_fetch_add (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_fetch_sub (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_fetch_sub (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_fetch_and (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_fetch_and (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_fetch_xor (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_fetch_xor (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_fetch_or  (T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_fetch_or  (&obj, value, mem_order); }
+	DECL_ATOMIC_INLINE T atomic_fetch_nand(T& obj, U value, MemoryOrder mem_order = MemoryOrder::memory_order_seq_cst) { return __atomic_fetch_nand(&obj, value, mem_order); }
+#undef DECL_ATOMIC_INLINE
+
+	template<atomic_lockfree_c T, MemoryOrder MEM_ORDER = MemoryOrder::memory_order_seq_cst>
 	class Atomic
 	{
 		Atomic(const Atomic&) = delete;
@@ -26,27 +56,41 @@ namespace BAN
 		constexpr Atomic() : m_value(0) {}
 		constexpr Atomic(T val) : m_value(val) {}
 
-		inline T load(MemoryOrder mem_order = MEM_ORDER) const volatile			{ return __atomic_load_n(&m_value, mem_order); }
+		inline T load(MemoryOrder mem_order = MEM_ORDER) const volatile			{ return atomic_load(m_value, mem_order); }
-		inline void store(T val, MemoryOrder mem_order = MEM_ORDER) volatile	{ __atomic_store_n(&m_value, val, mem_order); }
+		inline void store(T val, MemoryOrder mem_order = MEM_ORDER) volatile	{ atomic_store(m_value, val, mem_order); }
 
 		inline T operator=(T val) volatile { store(val); return val; }
 
 		inline operator T() const volatile { return load(); }
 
-		inline T operator+=(T val) volatile { return __atomic_add_fetch(&m_value, val, MEM_ORDER); }
+		inline T operator+=(T val) volatile { return atomic_add_fetch(m_value, val, MEM_ORDER); }
-		inline T operator-=(T val) volatile { return __atomic_sub_fetch(&m_value, val, MEM_ORDER); }
+		inline T operator-=(T val) volatile { return atomic_sub_fetch(m_value, val, MEM_ORDER); }
-		inline T operator&=(T val) volatile { return __atomic_and_fetch(&m_value, val, MEM_ORDER); }
+		inline T operator&=(T val) volatile { return atomic_and_fetch(m_value, val, MEM_ORDER); }
-		inline T operator^=(T val) volatile { return __atomic_xor_fetch(&m_value, val, MEM_ORDER); }
+		inline T operator^=(T val) volatile { return atomic_xor_fetch(m_value, val, MEM_ORDER); }
-		inline T operator|=(T val) volatile { return __atomic_or_fetch(&m_value, val, MEM_ORDER); }
+		inline T operator|=(T val) volatile { return atomic_or_fetch(m_value, val, MEM_ORDER); }
 
-		inline T operator--() volatile { return __atomic_sub_fetch(&m_value, 1, MEM_ORDER); }
+		inline T operator--() volatile { return atomic_sub_fetch(m_value, 1, MEM_ORDER); }
-		inline T operator++() volatile { return __atomic_add_fetch(&m_value, 1, MEM_ORDER); }
+		inline T operator++() volatile { return atomic_add_fetch(m_value, 1, MEM_ORDER); }
 
-		inline T operator--(int) volatile { return __atomic_fetch_sub(&m_value, 1, MEM_ORDER); }
+		inline T operator--(int) volatile { return atomic_fetch_sub(m_value, 1, MEM_ORDER); }
-		inline T operator++(int) volatile { return __atomic_fetch_add(&m_value, 1, MEM_ORDER); }
+		inline T operator++(int) volatile { return atomic_fetch_add(m_value, 1, MEM_ORDER); }
 
-		inline bool compare_exchange(T expected, T desired, MemoryOrder mem_order = MEM_ORDER) volatile { return __atomic_compare_exchange_n(&m_value, &expected, desired, false, mem_order, mem_order); }
+		inline bool compare_exchange(T& expected, T desired, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_compare_exchange(m_value, expected, desired, mem_order); }
-		inline T exchange(T desired, MemoryOrder mem_order = MEM_ORDER) volatile { return __atomic_exchange_n(&m_value, desired, mem_order); };
+		inline T exchange(T desired, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_exchange(m_value, desired, mem_order); };
+
+		inline T add_fetch (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_add_fetch (m_value, val, mem_order); }
+		inline T sub_fetch (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_sub_fetch (m_value, val, mem_order); }
+		inline T and_fetch (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_and_fetch (m_value, val, mem_order); }
+		inline T xor_fetch (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_xor_fetch (m_value, val, mem_order); }
+		inline T or_fetch  (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_or_fetch  (m_value, val, mem_order); }
+		inline T nand_fetch(T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_nand_fetch(m_value, val, mem_order); }
+
+		inline T fetch_add (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_fetch_add (m_value, val, mem_order); }
+		inline T fetch_sub (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_fetch_sub (m_value, val, mem_order); }
+		inline T fetch_and (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_fetch_and (m_value, val, mem_order); }
+		inline T fetch_xor (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_fetch_xor (m_value, val, mem_order); }
+		inline T fetch_or  (T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_fetch_or  (m_value, val, mem_order); }
+		inline T fetch_nand(T val, MemoryOrder mem_order = MEM_ORDER) volatile { return atomic_fetch_nand(m_value, val, mem_order); }
 
 	private:
 		T m_value;

BAN/include/BAN/ByteSpan.h

@@ -21,75 +21,56 @@ namespace BAN
 			, m_size(size)
 		{ }
 
-		ByteSpanGeneral(ByteSpanGeneral& other)
+		template<bool SRC_CONST>
+		ByteSpanGeneral(const ByteSpanGeneral<SRC_CONST>& other) requires(CONST || !SRC_CONST)
 			: m_data(other.data())
 			, m_size(other.size())
 		{ }
-		ByteSpanGeneral(ByteSpanGeneral&& other)
+		template<bool SRC_CONST>
+		ByteSpanGeneral(ByteSpanGeneral<SRC_CONST>&& other) requires(CONST || !SRC_CONST)
 			: m_data(other.data())
 			, m_size(other.size())
 		{
-			other.m_data = nullptr;
+			other.clear();
-			other.m_size = 0;
 		}
-		template<bool C2>
-		ByteSpanGeneral(const ByteSpanGeneral<C2>& other) requires(CONST)
-			: m_data(other.data())
-			, m_size(other.size())
-		{ }
-		template<bool C2>
-		ByteSpanGeneral(ByteSpanGeneral<C2>&& other) requires(CONST)
-			: m_data(other.data())
-			, m_size(other.size())
-		{
-			other.m_data = nullptr;
-			other.m_size = 0;
-		}
-		ByteSpanGeneral(Span<uint8_t> other)
-			: m_data(other.data())
-			, m_size(other.size())
-		{ }
-		ByteSpanGeneral(const Span<const uint8_t>& other) requires(CONST)
-			: m_data(other.data())
-			, m_size(other.size())
-		{ }
 
-		ByteSpanGeneral& operator=(ByteSpanGeneral other)
+		template<typename T>
+		ByteSpanGeneral(const Span<T>& other) requires(is_same_v<T, uint8_t> || (is_same_v<T, const uint8_t> && CONST))
+			: m_data(other.data())
+			, m_size(other.size())
+		{ }
+		template<typename T>
+		ByteSpanGeneral(Span<T>&& other) requires(is_same_v<T, uint8_t> || (is_same_v<T, const uint8_t> && CONST))
+			: m_data(other.data())
+			, m_size(other.size())
+		{
+			other.clear();
+		}
+
+		template<bool SRC_CONST>
+		ByteSpanGeneral& operator=(const ByteSpanGeneral<SRC_CONST>& other) requires(CONST || !SRC_CONST)
 		{
 			m_data = other.data();
 			m_size = other.size();
 			return *this;
 		}
-		template<bool C2>
+		template<bool SRC_CONST>
-		ByteSpanGeneral& operator=(const ByteSpanGeneral<C2>& other) requires(CONST)
+		ByteSpanGeneral& operator=(ByteSpanGeneral<SRC_CONST>&& other) requires(CONST || !SRC_CONST)
-		{
-			m_data = other.data();
-			m_size = other.size();
-			return *this;
-		}
-		ByteSpanGeneral& operator=(Span<uint8_t> other)
-		{
-			m_data = other.data();
-			m_size = other.size();
-			return *this;
-		}
-		ByteSpanGeneral& operator=(const Span<const uint8_t>& other) requires(CONST)
 		{
 			m_data = other.data();
 			m_size = other.size();
+			other.clear();
 			return *this;
 		}
 
 		template<typename S>
-		requires(CONST || !is_const_v<S>)
+		static ByteSpanGeneral from(S& value) requires(CONST || !is_const_v<S>)
-		static ByteSpanGeneral from(S& value)
 		{
 			return ByteSpanGeneral(reinterpret_cast<value_type*>(&value), sizeof(S));
 		}
 
 		template<typename S>
-		requires(!CONST && !is_const_v<S>)
+		S& as() const requires(!CONST || is_const_v<S>)
-		S& as()
 		{
 			ASSERT(m_data);
 			ASSERT(m_size >= sizeof(S));
@@ -97,30 +78,13 @@ namespace BAN
 		}
 
 		template<typename S>
-		requires(is_const_v<S>)
+		Span<S> as_span() const requires(!CONST || is_const_v<S>)
-		S& as() const
-		{
-			ASSERT(m_data);
-			ASSERT(m_size >= sizeof(S));
-			return *reinterpret_cast<S*>(m_data);
-		}
-
-		template<typename S>
-		requires(!CONST && !is_const_v<S>)
-		Span<S> as_span()
 		{
 			ASSERT(m_data);
 			return Span<S>(reinterpret_cast<S*>(m_data), m_size / sizeof(S));
 		}
 
-		template<typename S>
+		[[nodiscard]] ByteSpanGeneral slice(size_type offset, size_type length = size_type(-1)) const
-		const Span<S> as_span() const
-		{
-			ASSERT(m_data);
-			return Span<S>(reinterpret_cast<S*>(m_data), m_size / sizeof(S));
-		}
-
-		ByteSpanGeneral slice(size_type offset, size_type length = size_type(-1))
 		{
 			ASSERT(m_data);
 			ASSERT(m_size >= offset);
@@ -130,22 +94,23 @@ namespace BAN
 			return ByteSpanGeneral(m_data + offset, length);
 		}
 
-		value_type& operator[](size_type offset)
+		value_type& operator[](size_type offset) const
-		{
-			ASSERT(offset < m_size);
-			return m_data[offset];
-		}
-		const value_type& operator[](size_type offset) const
 		{
 			ASSERT(offset < m_size);
 			return m_data[offset];
 		}
 
-		value_type* data() { return m_data; }
+		value_type* data() const { return m_data; }
-		const value_type* data() const { return m_data; }
 
+		bool empty() const { return m_size == 0; }
 		size_type size() const { return m_size; }
 
+		void clear()
+		{
+			m_data = nullptr;
+			m_size = 0;
+		}
+
 	private:
 		value_type* m_data { nullptr };
 		size_type m_size { 0 };

BAN/include/BAN/CircularQueue.h

@@ -24,7 +24,7 @@ namespace BAN
 		void push(const T&);
 		void push(T&&);
 		template<typename... Args>
-		void emplace(Args&&... args);
+		void emplace(Args&&... args) requires is_constructible_v<T, Args...>;
 
 		void pop();
 
@@ -34,6 +34,11 @@ namespace BAN
 		const T& back() const;
 		T& back();
 
+		const T& operator[](size_t index) const;
+		T& operator[](size_t index);
+
+		void clear();
+
 		size_type size() const { return m_size; }
 		bool empty() const { return size() == 0; }
 		bool full() const { return size() == capacity(); }
@@ -53,8 +58,7 @@ namespace BAN
 	template<typename T, size_t S>
 	CircularQueue<T, S>::~CircularQueue()
 	{
-		for (size_type i = 0; i < m_size; i++)
+		clear();
-			element_at((m_first + i) % capacity())->~T();
 	}
 
 	template<typename T, size_t S>
@@ -71,7 +75,7 @@ namespace BAN
 
 	template<typename T, size_t S>
 	template<typename... Args>
-	void CircularQueue<T, S>::emplace(Args&&... args)
+	void CircularQueue<T, S>::emplace(Args&&... args) requires is_constructible_v<T, Args...>
 	{
 		ASSERT(!full());
 		new (element_at(((m_first + m_size) % capacity()))) T(BAN::forward<Args>(args)...);
@@ -115,6 +119,28 @@ namespace BAN
 		return *element_at((m_first + m_size - 1) % capacity());
 	}
 
+	template<typename T, size_t S>
+	const T& CircularQueue<T, S>::operator[](size_t index) const
+	{
+		ASSERT(index < m_size);
+		return *element_at((m_first + index) % capacity());
+	}
+
+	template<typename T, size_t S>
+	T& CircularQueue<T, S>::operator[](size_t index)
+	{
+		ASSERT(index < m_size);
+		return *element_at((m_first + index) % capacity());
+	}
+
+	template<typename T, size_t S>
+	void CircularQueue<T, S>::clear()
+	{
+		for (size_type i = 0; i < m_size; i++)
+			element_at((m_first + i) % capacity())->~T();
+		m_size = 0;
+	}
+
 	template<typename T, size_t S>
 	const T* CircularQueue<T, S>::element_at(size_type index) const
 	{

BAN/include/BAN/Debug.h

@@ -9,29 +9,35 @@
 #include <BAN/Formatter.h>
 #include <stdio.h>
 
-#define __debug_putchar [](int c) { putc(c, stddbg); }
+#define __debug_putchar [](int c) { putc_unlocked(c, stddbg); }
 
 #define dprintln(...)											\
 	do {														\
+		flockfile(stddbg);										\
 		BAN::Formatter::print(__debug_putchar, __VA_ARGS__);	\
-		BAN::Formatter::print(__debug_putchar,"\r\n");			\
+		BAN::Formatter::print(__debug_putchar,"\n");			\
 		fflush(stddbg);											\
+		funlockfile(stddbg);									\
 	} while (false)
 
 #define dwarnln(...)											\
 	do {														\
+		flockfile(stddbg);										\
 		BAN::Formatter::print(__debug_putchar, "\e[33m");		\
 		BAN::Formatter::print(__debug_putchar, __VA_ARGS__);	\
-		BAN::Formatter::print(__debug_putchar, "\e[m\r\n");		\
+		BAN::Formatter::print(__debug_putchar, "\e[m\n");		\
 		fflush(stddbg);											\
+		funlockfile(stddbg);									\
 	} while(false)
 
 #define derrorln(...)											\
 	do {														\
+		flockfile(stddbg);										\
 		BAN::Formatter::print(__debug_putchar, "\e[31m");		\
 		BAN::Formatter::print(__debug_putchar, __VA_ARGS__);	\
-		BAN::Formatter::print(__debug_putchar, "\e[m\r\n");		\
+		BAN::Formatter::print(__debug_putchar, "\e[m\n");		\
 		fflush(stddbg);											\
+		funlockfile(stddbg);									\
 	} while(false)
 
 #define dprintln_if(cond, ...)		\

BAN/include/BAN/Endianness.h

@@ -70,15 +70,19 @@ namespace BAN
 	template<integral T>
 	struct LittleEndian
 	{
+		constexpr LittleEndian()
+			: raw(0)
+		{ }
+
 		constexpr LittleEndian(T value)
-		{
+			: raw(host_to_little_endian(value))
-			raw = host_to_little_endian(value);
+		{ }
-		}
 
 		constexpr operator T() const
 		{
 			return host_to_little_endian(raw);
 		}
+
 	private:
 		T raw;
 	};
@@ -86,15 +90,19 @@ namespace BAN
 	template<integral T>
 	struct BigEndian
 	{
+		constexpr BigEndian()
+			: raw(0)
+		{ }
+
 		constexpr BigEndian(T value)
-		{
+			: raw(host_to_big_endian(value))
-			raw = host_to_big_endian(value);
+		{ }
-		}
 
 		constexpr operator T() const
 		{
 			return host_to_big_endian(raw);
 		}
+
 	private:
 		T raw;
 	};

BAN/include/BAN/Errors.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <BAN/Formatter.h>
+#include <BAN/NoCopyMove.h>
 #include <BAN/Variant.h>
 
 #include <errno.h>
@@ -9,16 +10,16 @@
 #ifdef __is_kernel
 	#include <kernel/Panic.h>
 	#include <kernel/Errors.h>
-	#define MUST(expr)		 ({ auto&& e = expr; if (e.is_error()) Kernel::panic("{}", e.error()); e.release_value(); })
+	#define MUST(...)		 ({ auto&& e = (__VA_ARGS__); if (e.is_error()) Kernel::panic("{}", e.error()); e.release_value(); })
-	#define MUST_REF(expr)	*({ auto&& e = expr; if (e.is_error()) Kernel::panic("{}", e.error()); &e.release_value(); })
+	#define MUST_REF(...)	*({ auto&& e = (__VA_ARGS__); if (e.is_error()) Kernel::panic("{}", e.error()); &e.release_value(); })
 #else
-	#include <assert.h>
+	#include <BAN/Debug.h>
-	#define MUST(expr)		 ({ auto&& e = expr; assert(!e.is_error()); e.release_value(); })
+	#define MUST(...)		 ({ auto&& e = (__VA_ARGS__); if (e.is_error()) { derrorln("MUST(" #__VA_ARGS__ "): {}", e.error()); __builtin_trap(); } e.release_value(); })
-	#define MUST_REF(expr)	*({ auto&& e = expr; assert(!e.is_error()); &e.release_value(); })
+	#define MUST_REF(...)	*({ auto&& e = (__VA_ARGS__); if (e.is_error()) { derrorln("MUST(" #__VA_ARGS__ "): {}", e.error()); __builtin_trap(); } &e.release_value(); })
 #endif
 
-#define TRY(expr)		 ({ auto&& e = expr; if (e.is_error()) return e.release_error(); e.release_value(); })
+#define TRY(...)		 ({ auto&& e = (__VA_ARGS__); if (e.is_error()) return e.release_error(); e.release_value(); })
-#define TRY_REF(expr)	*({ auto&& e = expr; if (e.is_error()) return e.release_error(); &e.release_value(); })
+#define TRY_REF(...)	*({ auto&& e = (__VA_ARGS__); if (e.is_error()) return e.release_error(); &e.release_value(); })
 
 namespace BAN
 {
@@ -36,7 +37,14 @@ namespace BAN
 		{
 			return Error((uint64_t)error | kernel_error_mask);
 		}
+#else
+		template<size_t N>
+		consteval static Error from_literal(const char (&message)[N])
+		{
+			return Error(message);
+		}
 #endif
+
 		static Error from_errno(int error)
 		{
 			return Error(error);
@@ -54,12 +62,15 @@ namespace BAN
 		}
 #endif
 
-		uint64_t get_error_code() const { return m_error_code; }
+		constexpr uint64_t get_error_code() const { return m_error_code; }
 		const char* get_message() const
 		{
 #ifdef __is_kernel
 			if (m_error_code & kernel_error_mask)
 				return Kernel::error_string(kernel_error());
+#else
+			if (m_message)
+				return m_message;
 #endif
 			if (auto* desc = strerrordesc_np(m_error_code))
 				return desc;
@@ -67,16 +78,27 @@ namespace BAN
 		}
 
 	private:
-		Error(uint64_t error)
+		constexpr Error(uint64_t error)
 			: m_error_code(error)
 		{}
 
-		uint64_t m_error_code;
+#ifndef __is_kernel
+		constexpr Error(const char* message)
+			: m_message(message)
+		{}
+#endif
+
+		uint64_t m_error_code { 0 };
+
+#ifndef __is_kernel
+		const char* m_message { nullptr };
+#endif
 	};
 
 	template<typename T>
 	class [[nodiscard]] ErrorOr
 	{
+		BAN_NON_COPYABLE(ErrorOr);
 	public:
 		ErrorOr(const T& value)
 			: m_data(value)
@@ -90,6 +112,14 @@ namespace BAN
 		ErrorOr(Error&& error)
 			: m_data(move(error))
 		{}
+		ErrorOr(ErrorOr&& other)
+			: m_data(move(other.m_data))
+		{}
+		ErrorOr& operator=(ErrorOr&& other)
+		{
+			m_data = move(other.m_data);
+			return *this;
+		}
 
 		bool is_error() const			{ return m_data.template has<Error>(); }
 		const Error& error() const		{ return m_data.template get<Error>(); }

BAN/include/BAN/Formatter.h

@@ -10,22 +10,19 @@ namespace BAN::Formatter
 
 	struct ValueFormat;
 
-	template<typename F>
-	static void print(F putc, const char* format);
-
-	template<typename F, typename Arg, typename... Args>
-	static void print(F putc, const char* format, Arg&& arg, Args&&... args);
-
 	template<typename F, typename... Args>
-	static void println(F putc, const char* format, Args&&... args);
+	concept PrintableArguments = requires(F putc, Args&&... args, const ValueFormat& format)
+	{
+		(print_argument(putc, BAN::forward<Args>(args), format), ...);
+	};
 
 	template<typename F, typename T>
-	static void print_argument(F putc, T value, const ValueFormat& format);
+	inline void print_argument(F putc, T value, const ValueFormat& format);
 
 	namespace detail
 	{
 		template<typename F, typename T>
-		static size_t parse_format_and_print_argument(F putc, const char* format, T&& arg);
+		inline size_t parse_format_and_print_argument(F putc, const char* format, T&& arg);
 	}
 
 	/*
@@ -39,11 +36,12 @@ namespace BAN::Formatter
 		int base		= 10;
 		int percision	= 3;
 		int fill		= 0;
+		char fill_char  = '0';
 		bool upper		= false;
 	};
 
 	template<typename F>
-	void print(F putc, const char* format)
+	inline void print(F putc, const char* format)
 	{
 		while (*format)
 		{
@@ -52,8 +50,8 @@ namespace BAN::Formatter
 		}
 	}
 
-	template<typename F, typename Arg, typename... Args>
+	template<typename F, typename Arg, typename... Args> requires PrintableArguments<F, Arg, Args...>
-	void print(F putc, const char* format, Arg&& arg, Args&&... args)
+	inline void print(F putc, const char* format, Arg&& arg, Args&&... args)
 	{
 		while (*format && *format != '{')
 		{
@@ -71,7 +69,7 @@ namespace BAN::Formatter
 	}
 
 	template<typename F, typename... Args>
-	void println(F putc, const char* format, Args&&... args)
+	inline void println(F putc, const char* format, Args&&... args)
 	{
 		print(putc, format, args...);
 		putc('\n');
@@ -81,7 +79,7 @@ namespace BAN::Formatter
 	{
 
 		template<typename F, typename Arg>
-		size_t parse_format_and_print_argument(F putc, const char* format, Arg&& argument)
+		inline size_t parse_format_and_print_argument(F putc, const char* format, Arg&& argument)
 		{
 			ValueFormat value_format;
 
@@ -94,6 +92,12 @@ namespace BAN::Formatter
 				if (!format[i] || format[i] == '}')
 					break;
 
+				if (format[i] == ' ')
+				{
+					value_format.fill_char = ' ';
+					i++;
+				}
+
 				if ('0' <= format[i] && format[i] <= '9')
 				{
 					int fill = 0;
@@ -143,7 +147,7 @@ namespace BAN::Formatter
 			return i + 1;
 		}
 
-		static char value_to_base_char(uint8_t value, int base, bool upper)
+		inline char value_to_base_char(uint8_t value, int base, bool upper)
 		{
 			if (base <= 10)
 				return value + '0';
@@ -157,11 +161,12 @@ namespace BAN::Formatter
 		}
 
 		template<typename F, typename T>
-		void print_integer(F putc, T value, const ValueFormat& format)
+		inline void print_integer(F putc, T value, const ValueFormat& format)
 		{
 			if (value == 0)
 			{
-				for (int i = 0; i < format.fill || i < 1; i++)
+				for (int i = 0; i < format.fill - 1; i++)
+					putc(format.fill_char);
 				putc('0');
 				return;
 			}
@@ -188,7 +193,7 @@ namespace BAN::Formatter
 			}
 
 			while (ptr >= buffer + sizeof(buffer) - format.fill)
-				*(--ptr) = '0';
+				*(--ptr) = format.fill_char;
 
 			if (sign)
 				*(--ptr) = '-';
@@ -197,12 +202,16 @@ namespace BAN::Formatter
 		}
 
 		template<typename F, typename T>
-		void print_floating(F putc, T value, const ValueFormat& format)
+		inline void print_floating(F putc, T value, const ValueFormat& format)
 		{
+			if (value < 0)
+			{
+				putc('-');
+				return print_floating(putc, -value, format);
+			}
+
 			int64_t int_part = (int64_t)value;
 			T frac_part = value - (T)int_part;
-			if (frac_part < 0)
-				frac_part = -frac_part;
 
 			print_integer(putc, int_part, format);
 
@@ -220,7 +229,7 @@ namespace BAN::Formatter
 		}
 
 		template<typename F>
-		void print_pointer(F putc, void* ptr, const ValueFormat& format)
+		inline void print_pointer(F putc, void* ptr, const ValueFormat& format)
 		{
 			uintptr_t value = (uintptr_t)ptr;
 			print(putc, "0x");
@@ -236,13 +245,13 @@ namespace BAN::Formatter
 
 	*/
 
-	template<typename F, integral		T> void print_argument(F putc, T value, const ValueFormat& format) { detail::print_integer(putc, value, format); }
+	template<typename F, integral		T> inline void print_argument(F putc, T value, const ValueFormat& format) { detail::print_integer(putc, value, format); }
-	template<typename F, floating_point	T> void print_argument(F putc, T value, const ValueFormat& format) { detail::print_floating(putc, value, format); }
+	template<typename F, floating_point	T> inline void print_argument(F putc, T value, const ValueFormat& format) { detail::print_floating(putc, value, format); }
-	template<typename F, pointer		T> void print_argument(F putc, T value, const ValueFormat& format) { detail::print_pointer(putc, (void*)value, format); }
+	template<typename F, pointer		T> inline void print_argument(F putc, T value, const ValueFormat& format) { detail::print_pointer(putc, (void*)value, format); }
 
-	template<typename F> void print_argument(F putc, char			value, const ValueFormat&)	{ putc(value); }
+	template<typename F> inline void print_argument(F putc, char			value, const ValueFormat&)	{ putc(value); }
-	template<typename F> void print_argument(F putc, bool			value, const ValueFormat&)	{ print(putc, value ? "true" : "false"); }
+	template<typename F> inline void print_argument(F putc, bool			value, const ValueFormat&)	{ print(putc, value ? "true" : "false"); }
-	template<typename F> void print_argument(F putc, const char*	value, const ValueFormat&)	{ print(putc, value); }
+	template<typename F> inline void print_argument(F putc, const char*	value, const ValueFormat&)	{ print(putc, value); }
-	template<typename F> void print_argument(F putc, char*			value, const ValueFormat&)	{ print(putc, value); }
+	template<typename F> inline void print_argument(F putc, char*			value, const ValueFormat&)	{ print(putc, value); }
 
 }

BAN/include/BAN/Function.h

@@ -20,19 +20,19 @@ namespace BAN
 			new (m_storage) CallablePointer(function);
 		}
 		template<typename Own>
-		Function(Ret(Own::*function)(Args...), Own* owner)
+		Function(Ret(Own::*function)(Args...), Own& owner)
 		{
 			static_assert(sizeof(CallableMember<Own>) <= m_size);
 			new (m_storage) CallableMember<Own>(function, owner);
 		}
 		template<typename Own>
-		Function(Ret(Own::*function)(Args...) const, const Own* owner)
+		Function(Ret(Own::*function)(Args...) const, const Own& owner)
 		{
 			static_assert(sizeof(CallableMemberConst<Own>) <= m_size);
 			new (m_storage) CallableMemberConst<Own>(function, owner);
 		}
 		template<typename Lambda>
-		Function(Lambda lambda) requires requires(Lambda lamda, Args... args) { { lambda(args...) } -> BAN::same_as<Ret>; }
+		Function(Lambda lambda) requires requires(Lambda lamda, Args&&... args) { { lambda(forward<Args>(args)...) } -> BAN::same_as<Ret>; }
 		{
 			static_assert(sizeof(CallableLambda<Lambda>) <= m_size);
 			new (m_storage) CallableLambda<Lambda>(lambda);
@@ -91,36 +91,36 @@ namespace BAN
 		template<typename Own>
 		struct CallableMember : public CallableBase
 		{
-			CallableMember(Ret(Own::*function)(Args...), Own* owner)
+			CallableMember(Ret(Own::*function)(Args...), Own& owner)
 				: m_owner(owner)
 				, m_function(function)
 			{ }
 
 			virtual Ret call(Args... args) const override
 			{
-				return (m_owner->*m_function)(forward<Args>(args)...);
+				return (m_owner.*m_function)(forward<Args>(args)...);
 			}
 
 		private:
-			Own* m_owner = nullptr;
+			Own& m_owner;
 			Ret(Own::*m_function)(Args...) = nullptr;
 		};
 
 		template<typename Own>
 		struct CallableMemberConst : public CallableBase
 		{
-			CallableMemberConst(Ret(Own::*function)(Args...) const, const Own* owner)
+			CallableMemberConst(Ret(Own::*function)(Args...) const, const Own& owner)
 				: m_owner(owner)
 				, m_function(function)
 			{ }
 
 			virtual Ret call(Args... args) const override
 			{
-				return (m_owner->*m_function)(forward<Args>(args)...);
+				return (m_owner.*m_function)(forward<Args>(args)...);
 			}
 
 		private:
-			const Own* m_owner = nullptr;
+			const Own& m_owner;
 			Ret(Own::*m_function)(Args...) const = nullptr;
 		};
 

BAN/include/BAN/GUID.h

@@ -1,7 +1,7 @@
 #pragma once
 
 #include <BAN/Optional.h>
-#include <BAN/StringView.h>
+#include <BAN/String.h>
 
 #include <string.h>
 
@@ -19,6 +19,54 @@ namespace BAN
 		{
 			return memcmp(this, &other, sizeof(GUID)) == 0;
 		}
+
+		BAN::ErrorOr<BAN::String> to_string() const
+		{
+			char buffer[37];
+			char* ptr = buffer;
+
+			const auto append_hex_nibble =
+				[&ptr](uint8_t nibble)
+				{
+					if (nibble < 10)
+						*ptr++ = '0' + nibble;
+					else
+						*ptr++ = 'A' + nibble - 10;
+				};
+
+			const auto append_hex_byte =
+				[&append_hex_nibble](uint8_t byte)
+				{
+					append_hex_nibble(byte >> 4);
+					append_hex_nibble(byte & 0xF);
+				};
+
+			append_hex_byte((component1 >> 24) & 0xFF);
+			append_hex_byte((component1 >> 16) & 0xFF);
+			append_hex_byte((component1 >>  8) & 0xFF);
+			append_hex_byte((component1 >>  0) & 0xFF);
+			*ptr++ = '-';
+			append_hex_byte((component2 >>  8) & 0xFF);
+			append_hex_byte((component2 >>  0) & 0xFF);
+			*ptr++ = '-';
+			append_hex_byte((component3 >>  8) & 0xFF);
+			append_hex_byte((component3 >>  0) & 0xFF);
+			*ptr++ = '-';
+			append_hex_byte(component45[0]);
+			append_hex_byte(component45[1]);
+			*ptr++ = '-';
+			append_hex_byte(component45[2]);
+			append_hex_byte(component45[3]);
+			append_hex_byte(component45[4]);
+			append_hex_byte(component45[5]);
+			append_hex_byte(component45[6]);
+			append_hex_byte(component45[7]);
+			*ptr = '\0';
+
+			BAN::String guid;
+			TRY(guid.append(buffer));
+			return BAN::move(guid);
+		}
 	};
 	static_assert(sizeof(GUID) == 16);
 

BAN/include/BAN/HashMap.h

@@ -14,11 +14,17 @@ namespace BAN
 		struct Entry
 		{
 			template<typename... Args>
-			Entry(const Key& key, Args&&... args)
+			Entry(const Key& key, Args&&... args) requires is_constructible_v<T, Args...>
 				: key(key)
 				, value(forward<Args>(args)...)
 			{}
 
+			template<typename... Args>
+			Entry(Key&& key, Args&&... args) requires is_constructible_v<T, Args...>
+				: key(BAN::move(key))
+				, value(forward<Args>(args)...)
+			{}
+
 			Key key;
 			T value;
 		};
@@ -39,10 +45,27 @@ namespace BAN
 		HashMap<Key, T, HASH>& operator=(const HashMap<Key, T, HASH>&);
 		HashMap<Key, T, HASH>& operator=(HashMap<Key, T, HASH>&&);
 
-		ErrorOr<void> insert(const Key&, const T&);
+		ErrorOr<iterator> insert(const Key& key, const T& value)           { return emplace(key, value); }
-		ErrorOr<void> insert(const Key&, T&&);
+		ErrorOr<iterator> insert(const Key& key, T&& value)                { return emplace(key, move(value)); }
+		ErrorOr<iterator> insert(Key&& key, const T& value)                { return emplace(move(key), value); }
+		ErrorOr<iterator> insert(Key&& key, T&& value)                     { return emplace(move(key), move(value)); }
+
+		ErrorOr<iterator> insert_or_assign(const Key& key, const T& value) { return emplace_or_assign(key, value); }
+		ErrorOr<iterator> insert_or_assign(const Key& key, T&& value)      { return emplace_or_assign(key, move(value)); }
+		ErrorOr<iterator> insert_or_assign(Key&& key, const T& value)      { return emplace_or_assign(move(key), value); }
+		ErrorOr<iterator> insert_or_assign(Key&& key, T&& value)           { return emplace_or_assign(move(key), move(value)); }
+
 		template<typename... Args>
-		ErrorOr<void> emplace(const Key&, Args&&...);
+		ErrorOr<iterator> emplace(const Key& key, Args&&... args) requires is_constructible_v<T, Args...>
+		{ return emplace(Key(key), forward<Args>(args)...); }
+		template<typename... Args>
+		ErrorOr<iterator> emplace(Key&&, Args&&...) requires is_constructible_v<T, Args...>;
+
+		template<typename... Args>
+		ErrorOr<iterator> emplace_or_assign(const Key& key, Args&&... args) requires is_constructible_v<T, Args...>
+		{ return emplace_or_assign(Key(key), forward<Args>(args)...); }
+		template<typename... Args>
+		ErrorOr<iterator> emplace_or_assign(Key&&, Args&&...) requires is_constructible_v<T, Args...>;
 
 		iterator begin() { return iterator(m_buckets.end(), m_buckets.begin()); }
 		iterator end()   { return iterator(m_buckets.end(), m_buckets.end()); }
@@ -117,27 +140,36 @@ namespace BAN
 	}
 
 	template<typename Key, typename T, typename HASH>
-	ErrorOr<void> HashMap<Key, T, HASH>::insert(const Key& key, const T& value)
+	template<typename... Args>
+	ErrorOr<typename HashMap<Key, T, HASH>::iterator> HashMap<Key, T, HASH>::emplace(Key&& key, Args&&... args) requires is_constructible_v<T, Args...>
 	{
-		return insert(key, move(T(value)));
+		ASSERT(!contains(key));
-	}
+		TRY(rebucket(m_size + 1));
 
-	template<typename Key, typename T, typename HASH>
+		auto bucket_it = get_bucket_iterator(key);
-	ErrorOr<void> HashMap<Key, T, HASH>::insert(const Key& key, T&& value)
+		TRY(bucket_it->emplace_back(move(key), forward<Args>(args)...));
-	{
+		m_size++;
-		return emplace(key, move(value));
+
+		return iterator(m_buckets.end(), bucket_it, prev(bucket_it->end(), 1));
 	}
 
 	template<typename Key, typename T, typename HASH>
 	template<typename... Args>
-	ErrorOr<void> HashMap<Key, T, HASH>::emplace(const Key& key, Args&&... args)
+	ErrorOr<typename HashMap<Key, T, HASH>::iterator> HashMap<Key, T, HASH>::emplace_or_assign(Key&& key, Args&&... args) requires is_constructible_v<T, Args...>
 	{
-		ASSERT(!contains(key));
+		if (empty())
-		TRY(rebucket(m_size + 1));
+			return emplace(move(key), forward<Args>(args)...);
-		auto& bucket = get_bucket(key);
+
-		TRY(bucket.emplace_back(key, forward<Args>(args)...));
+		auto bucket_it = get_bucket_iterator(key);
-		m_size++;
+		for (auto entry_it = bucket_it->begin(); entry_it != bucket_it->end(); entry_it++)
-		return {};
+		{
+			if (entry_it->key != key)
+				continue;
+			entry_it->value = T(forward<Args>(args)...);
+			return iterator(m_buckets.end(), bucket_it, entry_it);
+		}
+
+		return emplace(move(key), forward<Args>(args)...);
 	}
 
 	template<typename Key, typename T, typename HASH>
@@ -177,7 +209,7 @@ namespace BAN
 		for (Entry& entry : bucket)
 			if (entry.key == key)
 				return entry.value;
-		ASSERT(false);
+		ASSERT_NOT_REACHED();
 	}
 
 	template<typename Key, typename T, typename HASH>
@@ -188,7 +220,7 @@ namespace BAN
 		for (const Entry& entry : bucket)
 			if (entry.key == key)
 				return entry.value;
-		ASSERT(false);
+		ASSERT_NOT_REACHED();
 	}
 
 	template<typename Key, typename T, typename HASH>

BAN/include/BAN/Heap.h

@@ -0,0 +1,89 @@
+#pragma once
+
+#include <BAN/Iterators.h>
+#include <BAN/Swap.h>
+#include <BAN/Traits.h>
+
+namespace BAN
+{
+
+	namespace detail
+	{
+
+		template<typename It, typename Comp>
+		void heapify_up(It begin, size_t index, Comp comp)
+		{
+			size_t parent = (index - 1) / 2;
+			while (parent < index)
+			{
+				if (comp(*(begin + index), *(begin + parent)))
+					break;
+				swap(*(begin + parent), *(begin + index));
+				index = parent;
+				parent = (index - 1) / 2;
+			}
+		}
+
+		template<typename It, typename Comp>
+		void heapify_down(It begin, size_t index, size_t len, Comp comp)
+		{
+			for (;;)
+			{
+				const size_t lchild = 2 * index + 1;
+				const size_t rchild = 2 * index + 2;
+
+				size_t child = 0;
+				if (lchild < len && !comp(*(begin + lchild), *(begin + index)))
+				{
+					if (rchild < len && !comp(*(begin + rchild), *(begin + lchild)))
+						child = rchild;
+					else
+						child = lchild;
+				}
+				else if (rchild < len && !comp(*(begin + rchild), *(begin + index)))
+					child = rchild;
+				else
+					break;
+
+				swap(*(begin + child), *(begin + index));
+				index = child;
+			}
+		}
+
+	}
+
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
+	void make_heap(It begin, It end, Comp comp = {})
+	{
+		const size_t len = distance(begin, end);
+		if (len <= 1)
+			return;
+
+		size_t index = (len - 2) / 2;
+		while (index < len)
+			detail::heapify_down(begin, index--, len, comp);
+	}
+
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
+	void push_heap(It begin, It end, Comp comp = {})
+	{
+		const size_t len = distance(begin, end);
+		detail::heapify_up(begin, len - 1, comp);
+	}
+
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
+	void pop_heap(It begin, It end, Comp comp = {})
+	{
+		const size_t len = distance(begin, end);
+		swap(*begin, *(begin + len - 1));
+		detail::heapify_down(begin, 0, len - 1, comp);
+	}
+
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
+	void sort_heap(It begin, It end, Comp comp = {})
+	{
+		while (begin != end)
+			pop_heap(begin, end--, comp);
+	}
+
+}

BAN/include/BAN/IPv4.h

@@ -9,6 +9,10 @@ namespace BAN
 
 	struct IPv4Address
 	{
+		constexpr IPv4Address()
+			: IPv4Address(0)
+		{ }
+
 		constexpr IPv4Address(uint32_t u32_address)
 		{
 			raw = u32_address;

BAN/include/BAN/LinkedList.h

@@ -34,9 +34,9 @@ namespace BAN
 		ErrorOr<void> insert(iterator, const T&);
 		ErrorOr<void> insert(iterator, T&&);
 		template<typename... Args>
-		ErrorOr<void> emplace_back(Args&&...);
+		ErrorOr<void> emplace_back(Args&&...) requires is_constructible_v<T, Args...>;
 		template<typename... Args>
-		ErrorOr<void> emplace(iterator, Args&&...);
+		ErrorOr<void> emplace(iterator, Args&&...) requires is_constructible_v<T, Args...>;
 
 		void pop_back();
 		iterator remove(iterator);
@@ -196,14 +196,14 @@ namespace BAN
 
 	template<typename T>
 	template<typename... Args>
-	ErrorOr<void> LinkedList<T>::emplace_back(Args&&... args)
+	ErrorOr<void> LinkedList<T>::emplace_back(Args&&... args) requires is_constructible_v<T, Args...>
 	{
 		return emplace(end(), forward<Args>(args)...);
 	}
 
 	template<typename T>
 	template<typename... Args>
-	ErrorOr<void> LinkedList<T>::emplace(iterator iter, Args&&... args)
+	ErrorOr<void> LinkedList<T>::emplace(iterator iter, Args&&... args) requires is_constructible_v<T, Args...>
 	{
 		Node* new_node = TRY(allocate_node(forward<Args>(args)...));
 		insert_node(iter, new_node);

BAN/include/BAN/MacroUtils.h

@@ -0,0 +1,46 @@
+#pragma once
+
+#define _ban_count_args_impl(_0, _1, _2, _3, _4, _5, _6, _7, _8, _9, ...) _9
+#define _ban_count_args(...) _ban_count_args_impl(__VA_ARGS__ __VA_OPT__(,) 9, 8, 7, 6, 5, 4, 3, 2, 1, 0)
+
+#define _ban_concat_impl(a, b) a##b
+#define _ban_concat(a, b) _ban_concat_impl(a, b)
+
+#define _ban_stringify_impl(x) #x
+#define _ban_stringify(x) _ban_stringify_impl(x)
+
+#define _ban_fe_0(f)
+#define _ban_fe_1(f, _0)                                 f(0, _0)
+#define _ban_fe_2(f, _0, _1)                             f(0, _0) f(1, _1)
+#define _ban_fe_3(f, _0, _1, _2)                         f(0, _0) f(1, _1) f(2, _2)
+#define _ban_fe_4(f, _0, _1, _2, _3)                     f(0, _0) f(1, _1) f(2, _2) f(3, _3)
+#define _ban_fe_5(f, _0, _1, _2, _3, _4)                 f(0, _0) f(1, _1) f(2, _2) f(3, _3) f(4, _4)
+#define _ban_fe_6(f, _0, _1, _2, _3, _4, _5)             f(0, _0) f(1, _1) f(2, _2) f(3, _3) f(4, _4) f(5, _5)
+#define _ban_fe_7(f, _0, _1, _2, _3, _4, _5, _6)         f(0, _0) f(1, _1) f(2, _2) f(3, _3) f(4, _4) f(5, _5) f(6, _6)
+#define _ban_fe_8(f, _0, _1, _2, _3, _4, _5, _6, _7)     f(0, _0) f(1, _1) f(2, _2) f(3, _3) f(4, _4) f(5, _5) f(6, _6) f(7, _7)
+#define _ban_fe_9(f, _0, _1, _2, _3, _4, _5, _6, _7, _8) f(0, _0) f(1, _1) f(2, _2) f(3, _3) f(4, _4) f(5, _5) f(6, _6) f(7, _7) f(8, _8)
+#define _ban_for_each(f, ...) _ban_concat(_ban_fe_, _ban_count_args(__VA_ARGS__))(f __VA_OPT__(,) __VA_ARGS__)
+
+#define _ban_fe_comma_0(f)
+#define _ban_fe_comma_1(f, _0)                                 f(0, _0)
+#define _ban_fe_comma_2(f, _0, _1)                             f(0, _0), f(1, _1)
+#define _ban_fe_comma_3(f, _0, _1, _2)                         f(0, _0), f(1, _1), f(2, _2)
+#define _ban_fe_comma_4(f, _0, _1, _2, _3)                     f(0, _0), f(1, _1), f(2, _2), f(3, _3)
+#define _ban_fe_comma_5(f, _0, _1, _2, _3, _4)                 f(0, _0), f(1, _1), f(2, _2), f(3, _3), f(4, _4)
+#define _ban_fe_comma_6(f, _0, _1, _2, _3, _4, _5)             f(0, _0), f(1, _1), f(2, _2), f(3, _3), f(4, _4), f(5, _5)
+#define _ban_fe_comma_7(f, _0, _1, _2, _3, _4, _5, _6)         f(0, _0), f(1, _1), f(2, _2), f(3, _3), f(4, _4), f(5, _5), f(6, _6)
+#define _ban_fe_comma_8(f, _0, _1, _2, _3, _4, _5, _6, _7)     f(0, _0), f(1, _1), f(2, _2), f(3, _3), f(4, _4), f(5, _5), f(6, _6), f(7, _7)
+#define _ban_fe_comma_9(f, _0, _1, _2, _3, _4, _5, _6, _7, _8) f(0, _0), f(1, _1), f(2, _2), f(3, _3), f(4, _4), f(5, _5), f(6, _6), f(7, _7), f(8, _8)
+#define _ban_for_each_comma(f, ...) _ban_concat(_ban_fe_comma_, _ban_count_args(__VA_ARGS__))(f __VA_OPT__(,) __VA_ARGS__)
+
+#define _ban_get_0(a0, ...)                                     a0
+#define _ban_get_1(a0, a1, ...)                                 a1
+#define _ban_get_2(a0, a1, a2, ...)                             a2
+#define _ban_get_3(a0, a1, a2, a3, ...)                         a3
+#define _ban_get_4(a0, a1, a2, a3, a4, ...)                     a4
+#define _ban_get_5(a0, a1, a2, a3, a4, a5, ...)                 a5
+#define _ban_get_6(a0, a1, a2, a3, a4, a5, a6, ...)             a6
+#define _ban_get_7(a0, a1, a2, a3, a4, a5, a6, a7, ...)         a7
+#define _ban_get_8(a0, a1, a2, a3, a4, a5, a6, a7, a8, ...)     a8
+#define _ban_get_9(a0, a1, a2, a3, a4, a5, a6, a7, a8, a9, ...) a9
+#define _ban_get(n, ...) _ban_concat(_ban_get_, n)(__VA_ARGS__)

BAN/include/BAN/Math.h

@@ -1,18 +1,18 @@
 #pragma once
 
 #include <BAN/Limits.h>
+#include <BAN/Numbers.h>
 #include <BAN/Traits.h>
 
-#include <stddef.h>
+#include <float.h>
-#include <stdint.h>
 
 namespace BAN::Math
 {
 
 	template<typename T>
-	inline constexpr T abs(T val)
+	inline constexpr T abs(T x)
 	{
-		return val < 0 ? -val : val;
+		return x < 0 ? -x : x;
 	}
 
 	template<typename T>
@@ -36,12 +36,11 @@ namespace BAN::Math
 	template<integral T>
 	inline constexpr T gcd(T a, T b)
 	{
-		T t;
 		while (b)
 		{
-			t = b;
+			T temp = b;
 			b = a % b;
-			a = t;
+			a = temp;
 		}
 		return a;
 	}
@@ -59,86 +58,408 @@ namespace BAN::Math
 	}
 
 	template<integral T>
-	inline constexpr bool is_power_of_two(T value)
+	inline constexpr bool is_power_of_two(T x)
 	{
-		if (value == 0)
+		if (x == 0)
 			return false;
-		return (value & (value - 1)) == 0;
+		return (x & (x - 1)) == 0;
 	}
 
-	template<BAN::integral T>
+	template<integral T>
-	static constexpr bool will_multiplication_overflow(T a, T b)
+	__attribute__((always_inline))
+	inline constexpr bool will_multiplication_overflow(T a, T b)
 	{
-		if (a == 0 || b == 0)
+		T dummy;
-			return false;
+		return __builtin_mul_overflow(a, b, &dummy);
-		if ((a > 0) == (b > 0))
-			return a > BAN::numeric_limits<T>::max() / b;
-		else
-			return a < BAN::numeric_limits<T>::min() / b;
 	}
 
-	template<BAN::integral T>
+	template<integral T>
-	static constexpr bool will_addition_overflow(T a, T b)
+	__attribute__((always_inline))
+	inline constexpr bool will_addition_overflow(T a, T b)
 	{
-		if (a > 0 && b > 0)
+		T dummy;
-			return a > BAN::numeric_limits<T>::max() - b;
+		return __builtin_add_overflow(a, b, &dummy);
-		if (a < 0 && b < 0)
-			return a < BAN::numeric_limits<T>::min() - b;
-		return false;
 	}
 
 	template<typename T>
 	requires is_same_v<T, unsigned int> || is_same_v<T, unsigned long> || is_same_v<T, unsigned long long>
-	inline constexpr T ilog2(T value)
+	inline constexpr T ilog2(T x)
 	{
 		if constexpr(is_same_v<T, unsigned int>)
-			return sizeof(T) * 8 - __builtin_clz(value) - 1;
+			return sizeof(T) * 8 - __builtin_clz(x) - 1;
 		if constexpr(is_same_v<T, unsigned long>)
-			return sizeof(T) * 8 - __builtin_clzl(value) - 1;
+			return sizeof(T) * 8 - __builtin_clzl(x) - 1;
-		return sizeof(T) * 8 - __builtin_clzll(value) - 1;
+		return sizeof(T) * 8 - __builtin_clzll(x) - 1;
+	}
+
+// This is ugly but my clangd does not like including
+// intrinsic headers at all
+#if !defined(__SSE__) || !defined(__SSE2__)
+#pragma GCC push_options
+#ifndef __SSE__
+#pragma GCC target("sse")
+#endif
+#ifndef __SSE2__
+#pragma GCC target("sse2")
+#endif
+#define BAN_MATH_POP_OPTIONS
+#endif
+
+	template<floating_point T>
+	inline constexpr T floor(T x)
+	{
+		if constexpr(is_same_v<T, float>)
+			return __builtin_floorf(x);
+		if constexpr(is_same_v<T, double>)
+			return __builtin_floor(x);
+		if constexpr(is_same_v<T, long double>)
+			return __builtin_floorl(x);
 	}
 
 	template<floating_point T>
-	inline constexpr T log2(T value)
+	inline constexpr T ceil(T x)
 	{
-		T result;
+		if constexpr(is_same_v<T, float>)
-		asm volatile("fyl2x" : "=t"(result) : "0"(value), "u"((T)1.0) : "st(1)");
+			return __builtin_ceilf(x);
-		return result;
+		if constexpr(is_same_v<T, double>)
+			return __builtin_ceil(x);
+		if constexpr(is_same_v<T, long double>)
+			return __builtin_ceill(x);
 	}
 
 	template<floating_point T>
-	inline constexpr T log10(T value)
+	inline constexpr T round(T x)
 	{
-		constexpr T INV_LOG_2_10 = 0.3010299956639811952137388947244930267681898814621085413104274611;
+		if (x == (T)0.0)
-		T result;
+			return x;
-		asm volatile("fyl2x" : "=t"(result) : "0"(value), "u"(INV_LOG_2_10) : "st(1)");
+		if (x > (T)0.0)
-		return result;
+			return floor<T>(x + (T)0.5);
+		return ceil<T>(x - (T)0.5);
 	}
 
 	template<floating_point T>
-	inline constexpr T log(T value, T base)
+	inline constexpr T trunc(T x)
 	{
-		return log2(value) / log2(base);
+		if constexpr(is_same_v<T, float>)
+			return __builtin_truncf(x);
+		if constexpr(is_same_v<T, double>)
+			return __builtin_trunc(x);
+		if constexpr(is_same_v<T, long double>)
+			return __builtin_truncl(x);
 	}
 
 	template<floating_point T>
-	inline constexpr T pow(T base, T exp)
+	inline constexpr T rint(T x)
 	{
-		T result;
+		asm("frndint" : "+t"(x));
-		asm volatile(
+		return x;
-			"fyl2x;"
+	}
+
+	template<floating_point T>
+	inline constexpr T fmod(T a, T b)
+	{
+		asm(
+			"1:"
+			"fprem;"
+			"fnstsw %%ax;"
+			"testb $4, %%ah;"
+			"jne 1b;"
+			: "+t"(a)
+			: "u"(b)
+			: "ax", "cc"
+		);
+		return a;
+	}
+
+	template<floating_point T>
+	inline constexpr T remainder(T a, T b)
+	{
+		asm(
+			"1:"
+			"fprem1;"
+			"fnstsw %%ax;"
+			"testb $4, %%ah;"
+			"jne 1b;"
+			: "+t"(a)
+			: "u"(b)
+			: "ax", "cc"
+		);
+		return a;
+	}
+
+	template<floating_point T>
+	static T modf(T x, T* iptr)
+	{
+		const T frac = BAN::Math::fmod<T>(x, (T)1.0);
+		*iptr = x - frac;
+		return frac;
+	}
+
+	template<floating_point T>
+	inline constexpr T frexp(T num, int* exp)
+	{
+		if (num == (T)0.0)
+		{
+			*exp = 0;
+			return (T)0.0;
+		}
+
+		T e;
+		asm("fxtract" : "+t"(num), "=u"(e));
+		*exp = (int)e + 1;
+		return num / (T)2.0;
+	}
+
+	template<floating_point T>
+	inline constexpr T copysign(T x, T y)
+	{
+		if ((x < (T)0.0) != (y < (T)0.0))
+			x = -x;
+		return x;
+	}
+
+	namespace detail
+	{
+
+		template<floating_point T>
+		inline constexpr T fyl2x(T x, T y)
+		{
+			asm("fyl2x" : "+t"(x) : "u"(y) : "st(1)");
+			return x;
+		}
+
+	}
+
+	template<floating_point T>
+	inline constexpr T log(T x)
+	{
+		return detail::fyl2x<T>(x, numbers::ln2_v<T>);
+	}
+
+	template<floating_point T>
+	inline constexpr T log2(T x)
+	{
+		return detail::fyl2x<T>(x, 1.0);
+	}
+
+	template<floating_point T>
+	inline constexpr T log10(T x)
+	{
+		return detail::fyl2x<T>(x, numbers::lg2_v<T>);
+	}
+
+	template<floating_point T>
+	inline constexpr T logb(T x)
+	{
+		static_assert(FLT_RADIX == 2);
+		return log2<T>(x);
+	}
+
+	template<floating_point T>
+	inline constexpr T exp2(T x)
+	{
+		if (abs(x) <= (T)1.0)
+		{
+			asm("f2xm1" : "+t"(x));
+			return x + (T)1.0;
+		}
+
+		asm(
 			"fld1;"
 			"fld %%st(1);"
 			"fprem;"
 			"f2xm1;"
 			"faddp;"
 			"fscale;"
-			"fxch %%st(1);"
+			"fstp %%st(1);"
-			"fstp %%st;"
+			: "+t"(x)
-			: "=t"(result)
-			: "0"(base), "u"(exp)
 		);
-		return result;
+
+		return x;
 	}
 
+	template<floating_point T>
+	inline constexpr T exp(T x)
+	{
+		return exp2<T>(x * numbers::log2e_v<T>);
+	}
+
+	template<floating_point T>
+	inline constexpr T pow(T x, T y)
+	{
+		if (x == (T)0.0)
+			return (T)0.0;
+		return exp2<T>(y * log2<T>(x));
+	}
+
+	template<floating_point T>
+	inline constexpr T scalbn(T x, int n)
+	{
+		asm("fscale" : "+t"(x) : "u"(static_cast<T>(n)));
+		return x;
+	}
+
+	template<floating_point T>
+	inline constexpr T ldexp(T x, int y)
+	{
+		const bool exp_sign = y < 0;
+		if (exp_sign)
+			y = -y;
+
+		T exp = (T)1.0;
+		T mult = (T)2.0;
+		while (y)
+		{
+			if (y & 1)
+				exp *= mult;
+			mult *= mult;
+			y >>= 1;
+		}
+
+		if (exp_sign)
+			exp = (T)1.0 / exp;
+
+		return x * exp;
+	}
+
+	template<floating_point T>
+	inline constexpr T sqrt(T x)
+	{
+		if constexpr(BAN::is_same_v<T, float>)
+		{
+			using v4sf = float __attribute__((vector_size(16)));
+			return __builtin_ia32_sqrtss((v4sf) { x, 0.0f, 0.0f, 0.0f })[0];
+		}
+		else if constexpr(BAN::is_same_v<T, double>)
+		{
+			using v2df = double __attribute__((vector_size(16)));
+			return __builtin_ia32_sqrtsd((v2df) { x, 0.0 })[0];
+		}
+		else if constexpr(BAN::is_same_v<T, long double>)
+		{
+			asm("fsqrt" : "+t"(x));
+			return x;
+		}
+	}
+
+	template<floating_point T>
+	inline constexpr T cbrt(T value)
+	{
+		return pow<T>(value, (T)1.0 / (T)3.0);
+	}
+
+	template<floating_point T>
+	inline constexpr T sin(T x)
+	{
+		asm("fsin" : "+t"(x));
+		return x;
+	}
+
+	template<floating_point T>
+	inline constexpr T cos(T x)
+	{
+		asm("fcos" : "+t"(x));
+		return x;
+	}
+
+	template<floating_point T>
+	inline constexpr void sincos(T x, T& sin, T& cos)
+	{
+		asm("fsincos" : "=t"(cos), "=u"(sin) : "0"(x));
+	}
+
+	template<floating_point T>
+	inline constexpr T tan(T x)
+	{
+		T one, ret;
+		asm("fptan" : "=t"(one), "=u"(ret) : "0"(x));
+		return ret;
+	}
+
+	template<floating_point T>
+	inline constexpr T atan2(T y, T x)
+	{
+		asm("fpatan" : "+t"(x) : "u"(y) : "st(1)");
+		return x;
+	}
+
+	template<floating_point T>
+	inline constexpr T atan(T x)
+	{
+		return atan2<T>(x, (T)1.0);
+	}
+
+	template<floating_point T>
+	inline constexpr T asin(T x)
+	{
+		if (x == (T)0.0)
+			return (T)0.0;
+		if (x == (T)1.0)
+			return +numbers::pi_v<T> / (T)2.0;
+		if (x == (T)-1.0)
+			return -numbers::pi_v<T> / (T)2.0;
+		return (T)2.0 * atan<T>(x / ((T)1.0 + sqrt<T>((T)1.0 - x * x)));
+	}
+
+	template<floating_point T>
+	inline constexpr T acos(T x)
+	{
+		if (x == (T)0.0)
+			return numbers::pi_v<T> / (T)2.0;
+		if (x == (T)1.0)
+			return (T)0.0;
+		if (x == (T)-1.0)
+			return numbers::pi_v<T>;
+		return (T)2.0 * atan<T>(sqrt<T>((T)1.0 - x * x) / ((T)1.0 + x));
+	}
+
+	template<floating_point T>
+	inline constexpr T sinh(T x)
+	{
+		return (exp<T>(x) - exp<T>(-x)) / (T)2.0;
+	}
+
+	template<floating_point T>
+	inline constexpr T cosh(T x)
+	{
+		return (exp<T>(x) + exp<T>(-x)) / (T)2.0;
+	}
+
+	template<floating_point T>
+	inline constexpr T tanh(T x)
+	{
+		const T exp_px = exp<T>(+x);
+		const T exp_nx = exp<T>(-x);
+		return (exp_px - exp_nx) / (exp_px + exp_nx);
+	}
+
+	template<floating_point T>
+	inline constexpr T asinh(T x)
+	{
+		return log<T>(x + sqrt<T>(x * x + (T)1.0));
+	}
+
+	template<floating_point T>
+	inline constexpr T acosh(T x)
+	{
+		return log<T>(x + sqrt<T>(x * x - (T)1.0));
+	}
+
+	template<floating_point T>
+	inline constexpr T atanh(T x)
+	{
+		return (T)0.5 * log<T>(((T)1.0 + x) / ((T)1.0 - x));
+	}
+
+	template<floating_point T>
+	inline constexpr T hypot(T x, T y)
+	{
+		return sqrt<T>(x * x + y * y);
+	}
+
+#ifdef BAN_MATH_POP_OPTIONS
+#undef BAN_MATH_POP_OPTIONS
+#pragma GCC pop_options
+#endif
+
 }

BAN/include/BAN/New.h

@@ -9,10 +9,12 @@
 namespace BAN
 {
 	#if defined(__is_kernel)
-		static constexpr void*(&allocator)(size_t) = kmalloc;
+		static constexpr void*(*allocator)(size_t) = kmalloc;
-		static constexpr void(&deallocator)(void*) = kfree;
+		static constexpr void*(*reallocator)(void*, size_t) = nullptr;
+		static constexpr void(*deallocator)(void*) = kfree;
 	#else
-		static constexpr void*(&allocator)(size_t) = malloc;
+		static constexpr void*(*allocator)(size_t) = malloc;
-		static constexpr void(&deallocator)(void*) = free;
+		static constexpr void*(*reallocator)(void*, size_t) = realloc;
+		static constexpr void(*deallocator)(void*) = free;
 	#endif
 }

BAN/include/BAN/Numbers.h

@@ -0,0 +1,28 @@
+#pragma once
+
+#include <BAN/Traits.h>
+
+namespace BAN::numbers
+{
+
+	template<floating_point T> inline constexpr T e_v      = 2.71828182845904523536;
+	template<floating_point T> inline constexpr T log2e_v  = 1.44269504088896340736;
+	template<floating_point T> inline constexpr T lge_v    = 0.43429448190325182765;
+	template<floating_point T> inline constexpr T lg2_v    = 0.30102999566398119521;
+	template<floating_point T> inline constexpr T ln2_v    = 0.69314718055994530942;
+	template<floating_point T> inline constexpr T ln10_v   = 2.30258509299404568402;
+	template<floating_point T> inline constexpr T pi_v     = 3.14159265358979323846;
+	template<floating_point T> inline constexpr T sqrt2_v  = 1.41421356237309504880;
+	template<floating_point T> inline constexpr T sqrt3_v  = 1.73205080756887729353;
+
+	inline constexpr double e      = e_v<double>;
+	inline constexpr double log2e  = log2e_v<double>;
+	inline constexpr double lge    = lge_v<double>;
+	inline constexpr double lg2    = lge_v<double>;
+	inline constexpr double ln2    = ln2_v<double>;
+	inline constexpr double ln10   = ln10_v<double>;
+	inline constexpr double pi     = pi_v<double>;
+	inline constexpr double sqrt2  = sqrt2_v<double>;
+	inline constexpr double sqrt3  = sqrt3_v<double>;
+
+}

BAN/include/BAN/Optional.h

@@ -18,8 +18,6 @@ namespace BAN
 		constexpr Optional(const Optional&);
 		constexpr Optional(const T&);
 		constexpr Optional(T&&);
-		template<typename... Args>
-		constexpr Optional(Args&&...);
 
 		~Optional();
 
@@ -27,7 +25,7 @@ namespace BAN
 		constexpr Optional& operator=(const Optional&);
 
 		template<typename... Args>
-		constexpr Optional& emplace(Args&&...);
+		constexpr Optional& emplace(Args&&...) requires is_constructible_v<T, Args...>;
 
 		constexpr T* operator->();
 		constexpr const T* operator->() const;
@@ -40,11 +38,13 @@ namespace BAN
 		constexpr T release_value();
 		constexpr T& value();
 		constexpr const T& value() const;
+		constexpr T& value_or(T&);
+		constexpr const T& value_or(const T&) const;
 
 		constexpr void clear();
 
 	private:
-		alignas(T) uint8_t m_storage[sizeof(T)];
+		alignas(T) uint8_t m_storage[sizeof(T)] {};
 		bool m_has_value { false };
 	};
 
@@ -83,14 +83,6 @@ namespace BAN
 		new (m_storage) T(move(value));
 	}
 
-	template<typename T>
-	template<typename... Args>
-	constexpr Optional<T>::Optional(Args&&... args)
-		: m_has_value(true)
-	{
-		new (m_storage) T(forward<Args>(args)...);
-	}
-
 	template<typename T>
 	Optional<T>::~Optional()
 	{
@@ -112,14 +104,14 @@ namespace BAN
 	{
 		clear();
 		m_has_value = other.has_value();
-		if (other.has_value)
+		if (other.has_value())
 			new (m_storage) T(other.value());
 		return *this;
 	}
 
 	template<typename T>
 	template<typename... Args>
-	constexpr Optional<T>& Optional<T>::emplace(Args&&... args)
+	constexpr Optional<T>& Optional<T>::emplace(Args&&... args) requires is_constructible_v<T, Args...>
 	{
 		clear();
 		m_has_value = true;
@@ -175,14 +167,30 @@ namespace BAN
 	constexpr T& Optional<T>::value()
 	{
 		ASSERT(has_value());
-		return (T&)m_storage;
+		return *reinterpret_cast<T*>(&m_storage);
 	}
 
 	template<typename T>
 	constexpr const T& Optional<T>::value() const
 	{
 		ASSERT(has_value());
-		return (const T&)m_storage;
+		return *reinterpret_cast<const T*>(&m_storage);
+	}
+
+	template<typename T>
+	constexpr T& Optional<T>::value_or(T& empty)
+	{
+		if (!has_value())
+			return empty;
+		return value();
+	}
+
+	template<typename T>
+	constexpr const T& Optional<T>::value_or(const T& empty) const
+	{
+		if (!has_value())
+			return empty;
+		return value();
 	}
 
 	template<typename T>

BAN/include/BAN/PlacementNew.h

@@ -1,6 +1,10 @@
 #pragma once
 
+#if __has_include(<new>)
+	#include <new>
+#else
 	#include <stddef.h>
 
 	inline void* operator new(size_t, void* addr) { return addr; }
 	inline void* operator new[](size_t, void* addr) { return addr; }
+#endif

BAN/include/BAN/PriorityQueue.h

@@ -0,0 +1,64 @@
+#pragma once
+
+#include "BAN/Errors.h"
+#include <BAN/Vector.h>
+#include <BAN/Heap.h>
+
+namespace BAN
+{
+
+	template<typename T, typename Comp = less<T>>
+	class PriorityQueue
+	{
+	public:
+		PriorityQueue() = default;
+		PriorityQueue(Comp comp)
+			: m_comp(comp)
+		{ }
+
+		ErrorOr<void> push(const T& value)
+		{
+			TRY(m_data.push_back(value));
+			push_heap(m_data.begin(), m_data.end());
+			return {};
+		}
+
+		ErrorOr<void> push(T&& value)
+		{
+			TRY(m_data.push_back(move(value)));
+			push_heap(m_data.begin(), m_data.end());
+			return {};
+		}
+
+		template<typename... Args>
+		ErrorOr<void> emplace(Args&&... args) requires is_constructible_v<T, Args...>
+		{
+			TRY(m_data.emplace_back(forward<Args>(args)...));
+			push_heap(m_data.begin(), m_data.end());
+			return {};
+		}
+
+		void pop()
+		{
+			pop_heap(m_data.begin(), m_data.end());
+			m_data.pop_back();
+		}
+
+		BAN::ErrorOr<void> reserve(Vector<T>::size_type size)
+		{
+			return m_data.reserve(size);
+		}
+
+		T& top() { return m_data.front(); }
+		const T& top() const { return m_data.front(); }
+
+		bool empty() const { return m_data.empty(); }
+		Vector<T>::size_type size() const { return m_data.size(); }
+		Vector<T>::size_type capacity() const { return m_data.capacity(); }
+
+	private:
+		Comp m_comp;
+		Vector<T> m_data;
+	};
+
+}

BAN/include/BAN/Queue.h

@@ -31,7 +31,7 @@ namespace BAN
 		ErrorOr<void> push(T&&);
 		ErrorOr<void> push(const T&);
 		template<typename... Args>
-		ErrorOr<void> emplace(Args&&...);
+		ErrorOr<void> emplace(Args&&...) requires is_constructible_v<T, Args...>;
 
 		ErrorOr<void> reserve(size_type);
 		ErrorOr<void> shrink_to_fit();
@@ -131,7 +131,7 @@ namespace BAN
 
 	template<typename T>
 	template<typename... Args>
-	ErrorOr<void> Queue<T>::emplace(Args&&... args)
+	ErrorOr<void> Queue<T>::emplace(Args&&... args) requires is_constructible_v<T, Args...>
 	{
 		TRY(ensure_capacity(m_size + 1));
 		new (m_data + m_size) T(forward<Args>(args)...);

BAN/include/BAN/RefPtr.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <BAN/Atomic.h>
 #include <BAN/Errors.h>
 #include <BAN/Move.h>
 #include <BAN/NoCopyMove.h>
@@ -22,16 +23,28 @@ namespace BAN
 
 		void ref() const
 		{
-			ASSERT(m_ref_count > 0);
+			uint32_t old = m_ref_count.fetch_add(1, MemoryOrder::memory_order_relaxed);
-			m_ref_count++;
+			ASSERT(old > 0);
+		}
+
+		bool try_ref() const
+		{
+			uint32_t expected = m_ref_count.load(MemoryOrder::memory_order_relaxed);
+			for (;;)
+			{
+				if (expected == 0)
+					return false;
+				if (m_ref_count.compare_exchange(expected, expected + 1, MemoryOrder::memory_order_acquire))
+					return true;
+			}
 		}
 
 		void unref() const
 		{
-			ASSERT(m_ref_count > 0);
+			uint32_t old = m_ref_count.fetch_sub(1);
-			m_ref_count--;
+			ASSERT(old > 0);
-			if (m_ref_count == 0)
+			if (old == 1)
-				delete (const T*)this;
+				delete static_cast<const T*>(this);
 		}
 
 	protected:
@@ -39,7 +52,7 @@ namespace BAN
 		virtual ~RefCounted() { ASSERT(m_ref_count == 0); }
 
 	private:
-		mutable uint32_t m_ref_count = 1;
+		mutable Atomic<uint32_t> m_ref_count = 1;
 	};
 
 	template<typename T>
@@ -63,8 +76,9 @@ namespace BAN
 			return ptr;
 		}
 
+		// NOTE: don't use is_constructible_v<T, Args...> as RefPtr<T> is allowed with friends
 		template<typename... Args>
-		static ErrorOr<RefPtr> create(Args&&... args)
+		static ErrorOr<RefPtr> create(Args&&... args) requires requires(Args&&... args) { T(forward<Args>(args)...); }
 		{
 			T* pointer = new T(forward<Args>(args)...);
 			if (pointer == nullptr)

BAN/include/BAN/Sort.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <BAN/Heap.h>
 #include <BAN/Math.h>
 #include <BAN/Swap.h>
 #include <BAN/Traits.h>
@@ -8,7 +9,7 @@
 namespace BAN::sort
 {
 
-	template<typename It, typename Comp = less<typename It::value_type>>
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
 	void exchange_sort(It begin, It end, Comp comp = {})
 	{
 		for (It lhs = begin; lhs != end; ++lhs)
@@ -42,7 +43,7 @@ namespace BAN::sort
 
 	}
 
-	template<typename It, typename Comp = less<typename It::value_type>>
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
 	void quick_sort(It begin, It end, Comp comp = {})
 	{
 		if (distance(begin, end) <= 1)
@@ -52,14 +53,14 @@ namespace BAN::sort
 		quick_sort(++mid, end, comp);
 	}
 
-	template<typename It, typename Comp = less<typename It::value_type>>
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
 	void insertion_sort(It begin, It end, Comp comp = {})
 	{
 		if (distance(begin, end) <= 1)
 			return;
 		for (It it1 = next(begin, 1); it1 != end; ++it1)
 		{
-			typename It::value_type x = move(*it1);
+			auto x = move(*it1);
 			It it2 = it1;
 			for (; it2 != begin && comp(x, *prev(it2, 1)); --it2)
 				*it2 = move(*prev(it2, 1));
@@ -67,83 +68,7 @@ namespace BAN::sort
 		}
 	}
 
-	namespace detail
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
-	{
-
-		template<typename It, typename Comp>
-		void push_heap(It begin, size_t hole_index, size_t top_index, typename It::value_type value, Comp comp)
-		{
-			size_t parent = (hole_index - 1) / 2;
-			while (hole_index > top_index && comp(*next(begin, parent), value))
-			{
-				*next(begin, hole_index) = move(*next(begin, parent));
-				hole_index = parent;
-				parent = (hole_index - 1) / 2;
-			}
-			*next(begin, hole_index) = move(value);
-		}
-
-		template<typename It, typename Comp>
-		void adjust_heap(It begin, size_t hole_index, size_t len, typename It::value_type value, Comp comp)
-		{
-			const size_t top_index = hole_index;
-			size_t child = hole_index;
-			while (child < (len - 1) / 2)
-			{
-				child = 2 * (child + 1);
-				if (comp(*next(begin, child), *next(begin, child - 1)))
-					child--;
-				*next(begin, hole_index) = move(*next(begin, child));
-				hole_index = child;
-			}
-			if (len % 2 == 0 && child == (len - 2) / 2)
-			{
-				child = 2 * (child + 1);
-				*next(begin, hole_index) = move(*next(begin, child - 1));
-				hole_index = child - 1;
-			}
-			push_heap(begin, hole_index, top_index, move(value), comp);
-		}
-
-	}
-
-	template<typename It, typename Comp = less<typename It::value_type>>
-	void make_heap(It begin, It end, Comp comp = {})
-	{
-		const size_t len = distance(begin, end);
-		if (len <= 1)
-			return;
-
-		size_t parent = (len - 2) / 2;
-		while (true)
-		{
-			detail::adjust_heap(begin, parent, len, move(*next(begin, parent)), comp);
-
-			if (parent == 0)
-				break;
-
-			parent--;
-		}
-	}
-
-	template<typename It, typename Comp = less<typename It::value_type>>
-	void sort_heap(It begin, It end, Comp comp = {})
-	{
-		const size_t len = distance(begin, end);
-		if (len <= 1)
-			return;
-
-		size_t last = len;
-		while (last > 1)
-		{
-			last--;
-			typename It::value_type x = move(*next(begin, last));
-			*next(begin, last) = move(*begin);
-			detail::adjust_heap(begin, 0, last, move(x), comp);
-		}
-	}
-
-	template<typename It, typename Comp = less<typename It::value_type>>
 	void heap_sort(It begin, It end, Comp comp = {})
 	{
 		make_heap(begin, end, comp);
@@ -167,7 +92,7 @@ namespace BAN::sort
 
 	}
 
-	template<typename It, typename Comp = less<typename It::value_type>>
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
 	void intro_sort(It begin, It end, Comp comp = {})
 	{
 		const size_t len = distance(begin, end);
@@ -190,10 +115,10 @@ namespace BAN::sort
 	}
 
 	template<typename It, size_t radix = 256>
-	requires is_unsigned_v<typename It::value_type> && (radix > 0 && (radix & (radix - 1)) == 0)
+	requires is_unsigned_v<it_value_type_t<It>> && (radix > 0 && (radix & (radix - 1)) == 0)
 	BAN::ErrorOr<void> radix_sort(It begin, It end)
 	{
-		using value_type = typename It::value_type;
+		using value_type = it_value_type_t<It>;
 
 		const size_t len = distance(begin, end);
 		if (len <= 1)
@@ -231,7 +156,7 @@ namespace BAN::sort
 		return {};
 	}
 
-	template<typename It, typename Comp = less<typename It::value_type>>
+	template<typename It, typename Comp = less<it_value_type_t<It>>>
 	void sort(It begin, It end, Comp comp = {})
 	{
 		return intro_sort(begin, end, comp);

BAN/include/BAN/Span.h

@@ -14,116 +14,75 @@ namespace BAN
 	public:
 		using value_type = T;
 		using size_type = size_t;
-		using iterator = IteratorSimple<T, Span>;
+		using iterator = IteratorSimple<value_type, Span>;
-		using const_iterator = ConstIteratorSimple<T, Span>;
+		using const_iterator = ConstIteratorSimple<value_type, Span>;
+
+	private:
+		template<typename S>
+		static inline constexpr bool can_init_from_v = is_same_v<value_type, const S> || is_same_v<value_type, S>;
 
 	public:
 		Span() = default;
-		Span(T*, size_type);
+		Span(value_type* data, size_type size)
-		Span(Span<T>&);
+			: m_data(data)
+			, m_size(size)
+		{ }
+
 		template<typename S>
-		requires(is_same_v<T, const S>)
+		Span(const Span<S>& other) requires can_init_from_v<S>
-		Span(const Span<S>&);
+			: m_data(other.m_data)
+			, m_size(other.m_size)
+		{ }
+		template<typename S>
+		Span(Span<S>&& other) requires can_init_from_v<S>
+			: m_data(other.m_data)
+			, m_size(other.m_size)
+		{
+			other.clear();
+		}
+
+		template<typename S>
+		Span& operator=(const Span<S>& other) requires can_init_from_v<S>
+		{
+			m_data = other.m_data;
+			m_size = other.m_size;
+			return *this;
+		}
+		template<typename S>
+		Span& operator=(Span<S>&& other) requires can_init_from_v<S>
+		{
+			m_data = other.m_data;
+			m_size = other.m_size;
+			return *this;
+		}
 
 		iterator begin() { return iterator(m_data); }
 		iterator end() { return iterator(m_data + m_size); }
 		const_iterator begin() const { return const_iterator(m_data); }
 		const_iterator end() const { return const_iterator(m_data + m_size); }
 
-		T& operator[](size_type);
+		value_type& operator[](size_type index) const
-		const T& operator[](size_type) const;
-
-		T* data();
-		const T* data() const;
-
-		bool empty() const;
-		size_type size() const;
-
-		void clear();
-
-		Span slice(size_type, size_type = ~size_type(0));
-
-		Span<const T> as_const() const { return Span<const T>(m_data, m_size); }
-
-	private:
-		T* m_data = nullptr;
-		size_type m_size = 0;
-	};
-
-	template<typename T>
-	Span<T>::Span(T* data, size_type size)
-		: m_data(data)
-		, m_size(size)
 		{
-	}
-
-	template<typename T>
-	Span<T>::Span(Span& other)
-		: m_data(other.data())
-		, m_size(other.size())
-	{
-	}
-
-	template<typename T>
-	template<typename S>
-	requires(is_same_v<T, const S>)
-	Span<T>::Span(const Span<S>& other)
-		: m_data(other.data())
-		, m_size(other.size())
-	{
-	}
-
-	template<typename T>
-	T& Span<T>::operator[](size_type index)
-	{
-		ASSERT(m_data);
 			ASSERT(index < m_size);
 			return m_data[index];
 		}
 
-	template<typename T>
+		value_type* data() const
-	const T& Span<T>::operator[](size_type index) const
-	{
-		ASSERT(m_data);
-		ASSERT(index < m_size);
-		return m_data[index];
-	}
-
-	template<typename T>
-	T* Span<T>::data()
 		{
 			return m_data;
 		}
 
-	template<typename T>
+		bool empty() const { return m_size == 0; }
-	const T* Span<T>::data() const
+		size_type size() const { return m_size; }
-	{
-		return m_data;
-	}
 
-	template<typename T>
+		void clear()
-	bool Span<T>::empty() const
-	{
-		return m_size == 0;
-	}
-
-	template<typename T>
-	typename Span<T>::size_type Span<T>::size() const
-	{
-		return m_size;
-	}
-
-	template<typename T>
-	void Span<T>::clear()
 		{
 			m_data = nullptr;
 			m_size = 0;
 		}
 
-	template<typename T>
+		Span slice(size_type start, size_type length = ~size_type(0)) const
-	Span<T> Span<T>::slice(size_type start, size_type length)
 		{
-		ASSERT(m_data);
 			ASSERT(start <= m_size);
 			if (length == ~size_type(0))
 				length = m_size - start;
@@ -131,4 +90,13 @@ namespace BAN
 			return Span(m_data + start, length);
 		}
 
+		Span<const value_type> as_const() const { return *this; }
+
+	private:
+		value_type* m_data = nullptr;
+		size_type m_size = 0;
+
+		friend class Span<const value_type>;
+	};
+
 }

BAN/include/BAN/String.h

@@ -14,6 +14,7 @@ namespace BAN
 	{
 	public:
 		using size_type = size_t;
+		using value_type = char;
 		using iterator = IteratorSimple<char, String>;
 		using const_iterator = ConstIteratorSimple<char, String>;
 		static constexpr size_type sso_capacity = 15;
@@ -127,7 +128,7 @@ namespace BAN
 		void remove(size_type index)
 		{
 			ASSERT(index < m_size);
-			memcpy(data() + index, data() + index + 1, m_size - index);
+			memmove(data() + index, data() + index + 1, m_size - index);
 			m_size--;
 			data()[m_size] = '\0';
 		}
@@ -352,10 +353,9 @@ namespace BAN::Formatter
 {
 
 	template<typename F>
-	void print_argument(F putc, const String& string, const ValueFormat&)
+	void print_argument(F putc, const String& string, const ValueFormat& format)
 	{
-		for (String::size_type i = 0; i < string.size(); i++)
+		print_argument(putc, string.sv(), format);
-			putc(string[i]);
 	}
 
 }

BAN/include/BAN/StringView.h

@@ -14,6 +14,7 @@ namespace BAN
 	{
 	public:
 		using size_type = size_t;
+		using value_type = char;
 		using const_iterator = ConstIteratorSimple<char, StringView>;
 
 	public:
@@ -21,7 +22,8 @@ namespace BAN
 		constexpr StringView(const char* string, size_type len = -1)
 		{
 			if (len == size_type(-1))
-				len = strlen(string);
+				for (len = 0; string[len];)
+					len++;
 			m_data = string;
 			m_size = len;
 		}
@@ -186,15 +188,10 @@ namespace BAN
 		{
 			if (target.size() > m_size)
 				return false;
-			for (size_type i = 0; i < m_size - target.size(); i++)
+			for (size_type i = 0; i < target.size(); i++)
-			{
+				if (m_data[i] != target[i])
-				bool valid = true;
-				for (size_type j = 0; j < target.size() && valid; j++)
-					valid = (m_data[i + j] == target[j]);
-				if (valid)
-					return true;
-			}
 					return false;
+			return true;
 		}
 
 		constexpr bool contains(char ch) const
@@ -250,10 +247,12 @@ namespace BAN::Formatter
 {
 
 	template<typename F>
-	void print_argument(F putc, const StringView& sv, const ValueFormat&)
+	void print_argument(F putc, const StringView& sv, const ValueFormat& format)
 	{
 		for (StringView::size_type i = 0; i < sv.size(); i++)
 			putc(sv[i]);
+		for (int i = sv.size(); i < format.fill; i++)
+			putc(' ');
 	}
 
 }

BAN/include/BAN/Traits.h

@@ -3,10 +3,10 @@
 namespace BAN
 {
 
-	template<typename T> struct remove_refenrece { using type = T; };
+	template<typename T> struct remove_reference { using type = T; };
-	template<typename T> struct remove_refenrece<T&> { using type =  T; };
+	template<typename T> struct remove_reference<T&> { using type =  T; };
-	template<typename T> struct remove_refenrece<T&&> { using type = T; };
+	template<typename T> struct remove_reference<T&&> { using type = T; };
-	template<typename T> using remove_reference_t = typename remove_refenrece<T>::type;
+	template<typename T> using remove_reference_t = typename remove_reference<T>::type;
 
 	template<typename T> struct remove_const { using type = T; };
 	template<typename T> struct remove_const<const T> { using type = T; };
@@ -61,6 +61,9 @@ namespace BAN
 	template<typename T> struct is_move_constructible { static constexpr bool value = is_constructible_v<T, T&&>; };
 	template<typename T> inline constexpr bool is_move_constructible_v = is_move_constructible<T>::value;
 
+	template<typename T> struct is_trivially_copyable { static constexpr bool value = __is_trivially_copyable(T); };
+	template<typename T> inline constexpr bool is_trivially_copyable_v = is_trivially_copyable<T>::value;
+
 	template<typename T> struct is_integral { static constexpr bool value = requires (T t, T* p, void (*f)(T)) { reinterpret_cast<T>(t); f(0); p + t; }; };
 	template<typename T> inline constexpr bool is_integral_v = is_integral<T>::value;
 	template<typename T> concept integral = is_integral_v<T>;
@@ -90,6 +93,9 @@ namespace BAN
 	template<typename Base, typename Derived> struct is_base_of { static constexpr bool value = __is_base_of(Base, Derived); };
 	template<typename Base, typename Derived> inline constexpr bool is_base_of_v = is_base_of<Base, Derived>::value;
 
+	template<typename T> struct is_pod { static constexpr bool value = __is_pod(T); };
+	template<typename T> inline constexpr bool is_pod_v = is_pod<T>::value;
+
 	namespace detail
 	{
 		template<typename T, bool = is_arithmetic_v<T>> struct is_signed { static constexpr bool value = T(-1) < T(0); };
@@ -136,6 +142,10 @@ namespace BAN
 	template<typename T> using make_signed_t = typename make_signed<T>::type;
 #undef __BAN_TRAITS_MAKE_SIGNED_CV
 
+	template<typename T> struct it_value_type { using value_type = T::value_type; };
+	template<typename T> struct it_value_type<T*> { using value_type = T; };
+	template<typename T> using it_value_type_t = typename it_value_type<T>::value_type;
+
 	template<typename T> struct less	{ constexpr bool operator()(const T& lhs, const T& rhs) const { return lhs < rhs; } };
 	template<typename T> struct equal	{ constexpr bool operator()(const T& lhs, const T& rhs) const { return lhs == rhs; } };
 	template<typename T> struct greater	{ constexpr bool operator()(const T& lhs, const T& rhs) const { return lhs > rhs; } };

BAN/include/BAN/UTF8.h

@@ -18,7 +18,7 @@ namespace BAN::UTF8
 			return 3;
 		if ((first_byte & 0xF8) == 0xF0)
 			return 4;
-		return 0;
+		return UTF8::invalid;
 	}
 
 	template<typename T> requires (sizeof(T) == 1)
@@ -76,6 +76,8 @@ namespace BAN::UTF8
 			}
 		}
 
+		*ptr = '\0';
+
 		return true;
 	}
 

BAN/include/BAN/UniqPtr.h

@@ -33,8 +33,9 @@ namespace BAN
 			return uniq;
 		}
 
+		// NOTE: don't use is_constructible_v<T, Args...> as UniqPtr<T> is allowed with friends
 		template<typename... Args>
-		static BAN::ErrorOr<UniqPtr> create(Args&&... args)
+		static BAN::ErrorOr<UniqPtr> create(Args&&... args) requires requires(Args&&... args) { T(forward<Args>(args)...); }
 		{
 			UniqPtr uniq;
 			uniq.m_pointer = new T(BAN::forward<Args>(args)...);

BAN/include/BAN/Variant.h

@@ -126,6 +126,7 @@ namespace BAN
 		Variant(Variant&& other)
 			: m_index(other.m_index)
 		{
+			if (other.has_value())
 				detail::move_construct<Ts...>(other.m_index, other.m_storage, m_storage);
 			other.clear();
 		}
@@ -133,6 +134,7 @@ namespace BAN
 		Variant(const Variant& other)
 			: m_index(other.m_index)
 		{
+			if (other.has_value())
 				detail::copy_construct<Ts...>(other.m_index, other.m_storage, m_storage);
 		}
 
@@ -157,11 +159,12 @@ namespace BAN
 
 		Variant& operator=(Variant&& other)
 		{
-			if (m_index == other.m_index)
+			if (m_index == other.m_index && m_index != invalid_index())
 				detail::move_assign<Ts...>(m_index, other.m_storage, m_storage);
 			else
 			{
 				clear();
+				if (other.has_value())
 					detail::move_construct<Ts...>(other.m_index, other.m_storage, m_storage);
 				m_index = other.m_index;
 			}
@@ -171,11 +174,12 @@ namespace BAN
 
 		Variant& operator=(const Variant& other)
 		{
-			if (m_index == other.m_index)
+			if (m_index == other.m_index && m_index != invalid_index())
 				detail::copy_assign<Ts...>(m_index, other.m_storage, m_storage);
 			else
 			{
 				clear();
+				if (other.has_value())
 					detail::copy_construct<Ts...>(other.m_index, other.m_storage, m_storage);
 				m_index = other.m_index;
 			}
@@ -217,7 +221,7 @@ namespace BAN
 		}
 
 		template<typename T, typename... Args>
-		void emplace(Args&&... args) requires (can_have<T>())
+		void emplace(Args&&... args) requires (can_have<T>() && is_constructible_v<T, Args...>)
 		{
 			clear();
 			m_index = detail::index<T, Ts...>();
@@ -286,6 +290,16 @@ namespace BAN
 			return **reinterpret_cast<const remove_reference_t<T>**>(m_storage);
 		}
 
+		bool has_value() const
+		{
+			return m_index != invalid_index();
+		}
+
+		explicit operator bool() const
+		{
+			return has_value();
+		}
+
 		void clear()
 		{
 			if (m_index != invalid_index())

BAN/include/BAN/Vector.h

@@ -7,6 +7,7 @@
 #include <BAN/New.h>
 #include <BAN/PlacementNew.h>
 #include <BAN/Span.h>
+#include <BAN/Swap.h>
 
 namespace BAN
 {
@@ -34,9 +35,9 @@ namespace BAN
 		ErrorOr<void> push_back(T&&);
 		ErrorOr<void> push_back(const T&);
 		template<typename... Args>
-		ErrorOr<void> emplace_back(Args&&...);
+		ErrorOr<void> emplace_back(Args&&...) requires is_constructible_v<T, Args...>;
 		template<typename... Args>
-		ErrorOr<void> emplace(size_type, Args&&...);
+		ErrorOr<void> emplace(size_type, Args&&...) requires is_constructible_v<T, Args...>;
 		ErrorOr<void> insert(size_type, T&&);
 		ErrorOr<void> insert(size_type, const T&);
 
@@ -55,7 +56,7 @@ namespace BAN
 		bool contains(const T&) const;
 
 		Span<T> span() { return Span(m_data, m_size); }
-		const Span<T> span() const { return Span(m_data, m_size); }
+		Span<const T> span() const { return Span(m_data, m_size); }
 
 		const T& operator[](size_type) const;
 		T& operator[](size_type);
@@ -65,6 +66,8 @@ namespace BAN
 		const T& front() const;
 		T& front();
 
+		void reverse();
+
 		ErrorOr<void> resize(size_type)				requires is_default_constructible_v<T>;
 		ErrorOr<void> resize(size_type, const T&)	requires is_copy_constructible_v<T>;
 		ErrorOr<void> reserve(size_type);
@@ -166,7 +169,7 @@ namespace BAN
 
 	template<typename T>
 	template<typename... Args>
-	ErrorOr<void> Vector<T>::emplace_back(Args&&... args)
+	ErrorOr<void> Vector<T>::emplace_back(Args&&... args) requires is_constructible_v<T, Args...>
 	{
 		TRY(ensure_capacity(m_size + 1));
 		new (m_data + m_size) T(forward<Args>(args)...);
@@ -176,7 +179,7 @@ namespace BAN
 
 	template<typename T>
 	template<typename... Args>
-	ErrorOr<void> Vector<T>::emplace(size_type index, Args&&... args)
+	ErrorOr<void> Vector<T>::emplace(size_type index, Args&&... args) requires is_constructible_v<T, Args...>
 	{
 		ASSERT(index <= m_size);
 		TRY(ensure_capacity(m_size + 1));
@@ -301,6 +304,13 @@ namespace BAN
 		return m_data[0];
 	}
 
+	template<typename T>
+	void Vector<T>::reverse()
+	{
+		for (size_type i = 0; i < m_size / 2; i++)
+			BAN::swap(m_data[i], m_data[m_size - i - 1]);
+	}
+
 	template<typename T>
 	ErrorOr<void> Vector<T>::resize(size_type size) requires is_default_constructible_v<T>
 	{
@@ -371,10 +381,35 @@ namespace BAN
 	template<typename T>
 	ErrorOr<void> Vector<T>::ensure_capacity(size_type size)
 	{
+		static_assert(alignof(T) <= alignof(max_align_t), "over aligned types not supported");
+
 		if (m_capacity >= size)
 			return {};
-		size_type new_cap = BAN::Math::max<size_type>(size, m_capacity * 2);
+
-		T* new_data = (T*)BAN::allocator(new_cap * sizeof(T));
+		const size_type new_cap = BAN::Math::max<size_type>(size, m_capacity * 2);
+
+		if constexpr (BAN::is_trivially_copyable_v<T>)
+		{
+			if constexpr (BAN::reallocator)
+			{
+				auto* new_data = static_cast<T*>(BAN::reallocator(m_data, new_cap * sizeof(T)));
+				if (new_data == nullptr)
+					return Error::from_errno(ENOMEM);
+				m_data = new_data;
+			}
+			else
+			{
+				auto* new_data = static_cast<T*>(BAN::allocator(new_cap * sizeof(T)));
+				if (new_data == nullptr)
+					return Error::from_errno(ENOMEM);
+				memcpy(new_data, m_data, m_size * sizeof(T));
+				BAN::deallocator(m_data);
+				m_data = new_data;
+			}
+		}
+		else
+		{
+			auto* new_data = static_cast<T*>(BAN::allocator(new_cap * sizeof(T)));
 			if (new_data == nullptr)
 				return Error::from_errno(ENOMEM);
 			for (size_type i = 0; i < m_size; i++)
@@ -384,6 +419,8 @@ namespace BAN
 			}
 			BAN::deallocator(m_data);
 			m_data = new_data;
+		}
+
 		m_capacity = new_cap;
 		return {};
 	}

BAN/include/BAN/WeakPtr.h

@@ -2,6 +2,10 @@
 
 #include <BAN/RefPtr.h>
 
+#if __is_kernel
+#include <kernel/Lock/SpinLock.h>
+#endif
+
 namespace BAN
 {
 
@@ -11,22 +15,37 @@ namespace BAN
 	template<typename T>
 	class WeakPtr;
 
+	// FIXME: Write this without using locks...
 	template<typename T>
 	class WeakLink : public RefCounted<WeakLink<T>>
 	{
 	public:
-		RefPtr<T> lock() { ASSERT(m_ptr); return raw_ptr(); }
+		RefPtr<T> try_lock() const
-		T* raw_ptr() { return m_ptr; }
+		{
-
+#if __is_kernel
+			Kernel::SpinLockGuard _(m_weak_lock);
+#endif
+			if (m_ptr && m_ptr->try_ref())
+				return RefPtr<T>::adopt(m_ptr);
+			return nullptr;
+		}
 		bool valid() const { return m_ptr; }
-		void invalidate() { m_ptr = nullptr; }
+		void invalidate()
+		{
+#if __is_kernel
+			Kernel::SpinLockGuard _(m_weak_lock);
+#endif
+			m_ptr = nullptr;
+		}
 
 	private:
 		WeakLink(T* ptr) : m_ptr(ptr) {}
 
 	private:
 		T* m_ptr;
-
+#if __is_kernel
+		mutable Kernel::SpinLock m_weak_lock;
+#endif
 		friend class RefPtr<WeakLink<T>>;
 	};
 
@@ -80,10 +99,10 @@ namespace BAN
 			return *this;
 		}
 
-		RefPtr<T> lock()
+		RefPtr<T> lock() const
 		{
-			if (valid())
+			if (m_link)
-				return m_link->lock();
+				return m_link->try_lock();
 			return nullptr;
 		}
 

CMakeLists.txt

@@ -4,13 +4,8 @@ if (NOT ${CMAKE_SYSTEM_NAME} STREQUAL "banan-os")
 	message(FATAL_ERROR "CMAKE_SYSTEM_NAME is not banan-os")
 endif ()
 
-#add_compile_options(-mno-sse -mno-sse2)
-add_compile_definitions(__enable_sse=1)
-
 project(banan-os CXX C ASM)
 
-set(BANAN_BASE_SYSROOT ${CMAKE_SOURCE_DIR}/base-sysroot.tar.gz)
-
 set(BANAN_INCLUDE ${BANAN_SYSROOT}/usr/include)
 set(BANAN_LIB     ${BANAN_SYSROOT}/usr/lib)
 set(BANAN_BIN     ${BANAN_SYSROOT}/usr/bin)
@@ -26,14 +21,20 @@ set(CMAKE_INSTALL_SYSCONF    ${BANAN_ETC})
 set(CMAKE_INSTALL_MESSAGE    NEVER)
 set(CMAKE_SKIP_INSTALL_ALL_DEPENDENCY True)
 
+set(CMAKE_STATIC_LIBRARY_PREFIX "")
+set(CMAKE_SHARED_LIBRARY_PREFIX "")
+set(BUILD_SHARED_LIBS True)
+
+set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
+
 # include headers of ${library} to ${target}
 function(banan_include_headers target library)
-	target_include_directories(${target} PRIVATE $<TARGET_PROPERTY:${library},SOURCE_DIR>/include)
+	target_include_directories(${target} PUBLIC $<TARGET_PROPERTY:${library},SOURCE_DIR>/include)
 endfunction()
 
 # include headers and link ${library} to ${target}
 function(banan_link_library target library)
-	target_link_libraries(${target} PRIVATE ${library})
+	target_link_libraries(${target} PUBLIC ${library})
 	banan_include_headers(${target} ${library})
 endfunction()
 
@@ -51,8 +52,3 @@ add_subdirectory(kernel)
 add_subdirectory(bootloader)
 add_subdirectory(BAN)
 add_subdirectory(userspace)
-
-add_custom_target(sysroot
-	COMMAND ${CMAKE_COMMAND} -E make_directory ${BANAN_SYSROOT}
-	COMMAND cd ${BANAN_SYSROOT} && tar xf ${BANAN_BASE_SYSROOT}
-)

README.md

@@ -9,6 +9,8 @@ This is my hobby operating system written in C++. Currently supports x86\_64 and
 
 You can find a live demo [here](https://bananymous.com/banan-os)
 
+If you want to try out DOOM, you should first enter the GUI environment using the `start-gui` command. Then you can run `doom` in the GUI terminal.
+
 ### Features
 
 #### General
@@ -18,15 +20,34 @@ You can find a live demo [here](https://bananymous.com/banan-os)
 - [x] Network stack
 - [x] ELF executable loading
 - [x] AML interpreter (partial)
-- [ ] ELF dynamic linking
+- [x] Basic graphical environment
-- [ ] Graphical desktop
+  - [x] Terminal emulator
+  - [x] Status bar
+  - [x] Program launcher
+  - [ ] Some nice apps
+- [x] ELF dynamic linking
+- [x] copy-on-write memory
+  - [x] file mappings
+  - [ ] anonymous mappings
 
 #### Drivers
 - [x] NVMe disks
 - [x] ATA (IDE, SATA) disks
 - [x] E1000 and E1000E NICs
+- [x] RTL8111/8168/8211/8411 NICs
 - [x] PS2 keyboard (all scancode sets)
 - [x] PS2 mouse
+- [x] USB
+  - [x] xHCI
+  - [ ] EHCI
+  - [ ] OHCI
+  - [ ] UHCI
+  - [x] Keyboard
+  - [x] Mouse
+  - [x] Mass storage
+  - [x] Hubs
+  - [ ] ...
+- [ ] virtio devices (network, storage)
 
 #### Network
 - [x] ARP
@@ -35,6 +56,7 @@ You can find a live demo [here](https://bananymous.com/banan-os)
 - [x] UDP
 - [x] TCP (partial and buggy)
 - [x] Unix domain sockets
+- [ ] SSL
 
 #### Filesystems
 - [x] Virtual filesystem
@@ -44,6 +66,7 @@ You can find a live demo [here](https://bananymous.com/banan-os)
 - [x] Ram
 - [x] Proc
 - [ ] Sys
+- [ ] 9P
 
 #### Bootloader support
 - [x] GRUB
@@ -95,6 +118,8 @@ To change the bootloader you can set environment variable BANAN\_BOOTLOADER; sup
 
 To run with UEFI set environment variable BANAN\_UEFI\_BOOT=1. You will also have to set OVMF\_PATH to the correct OVMF (default */usr/share/ovmf/x64/OVMF.fd*).
 
+To build an image with no physical root filesystem, but an initrd set environment variable BANAN\_INITRD=1. This can be used when testing on hardware with unsupported USB controller.
+
 If you have corrupted your disk image or want to create new one, you can either manually delete *build/banan-os.img* and build system will automatically create you a new one or you can run the following command.
 ```sh
 ./bos image-full
@@ -104,13 +129,13 @@ I have also created shell completion script for zsh. You can either copy the fil
 
 ## Contributing
 
-As the upstream is hosted on my server https://git.bananymous.com/Bananymous/banan-os, please contact me about account creation ([email](mailto:oskari.alaranta@bananymous.com), [discord](https://discord.gg/xMXKt9Wf)) and I will add a account for you. This is done to limit the people with access to the server.
+As the upstream is hosted on my server https://git.bananymous.com/Bananymous/banan-os, merging contributions is not as trivial as it would be on GitHub. You can still send PRs in GitHub in which case I should be able to download the diff and apply it manually. If you want, I can also provide you an account to my git server. In this case please contact me ([email](mailto:oskari.alaranta@bananymous.com), [discord](https://discord.gg/ehjGySwYdK)).
 
-As this is mostly a learning experience for me, I would appreciate if you first contacted me about adding new features (email, discord, issue, ...). Bug fixes are always welcome!
+As this is mostly a learning experience for me, I would appreciate if you first contacted me about adding new features (email, discord, issue, ...). If you send a PR about something I was planning on doing myself and you didn't ask me, I will probably just close it. Bug fixes are always welcome!
 
 Commit message should be formatted followingly
 
-  1. First line is of the form "_Subject: Description_", where _Subject_ tells the area touched (Kernel, Shell, BuildSystem, ...) and _Description_ is brief description of the change done. First line should fit fully in 70 characters.
+  1. First line is of the form "_Subject: Description_", where _Subject_ tells the area touched (Kernel, Shell, BuildSystem, ...) and _Description_ is brief description of the change done. First line should fit fully in 72 characters.
   2. Body of the message should further describe the change and reasoning behind the change.
 
 All commits should pass the pre-commit hook defined in _.pre-commit-config.yaml_. For instructions on how to setup pre-commit, please see https://pre-commit.com/#install.

bootloader/bios/boot.S

@@ -172,3 +172,5 @@ banan_boot_info:
 		.long framebuffer
 	boot_memory_map:
 		.long memory_map
+	boot_kernel_paddr:
+		.long 0

bootloader/bios/command_line.S

@@ -84,4 +84,4 @@ command_line:
 # 100 character command line
 command_line_buffer:
 	.ascii "root=/dev/sda2"
-	.skip 100 - 28
+	.skip 100 - (. - command_line_buffer)

bootloader/bios/utils.S

@@ -306,20 +306,8 @@ memset32:
 	movw $GDT_DATA32, %dx
 	movw %dx, %es
 
-	movl %ecx, %edx
-
-	andl $3, %ecx
 	rep stosb %es:(%edi)
 
-	movl %edx, %ecx
-	shrl $2, %ecx
-
-	movb %al, %ah
-	movw %ax, %dx
-	shll $16, %eax
-	movw %dx, %ax
-	rep stosl %es:(%edi)
-
 	ljmpl $GDT_CODE16, $.memset32_pmode16
 
  .code16
@@ -370,14 +358,8 @@ memcpy32:
 	movw %dx, %ds
 	movw %dx, %es
 
-	movl %ecx, %edx
-	andl $3, %ecx
 	rep movsb %ds:(%esi), %es:(%edi)
 
-	movl %edx, %ecx
-	shrl $2, %ecx
-	rep movsl %ds:(%esi), %es:(%edi)
-
 	ljmpl $GDT_CODE16, $.memcpy32_pmode16
 
  .code16

kernel/CMakeLists.txt

@@ -1,14 +1,16 @@
 set(KERNEL_SOURCES
 	font/prefs.psf.o
 	kernel/ACPI/ACPI.cpp
-	kernel/ACPI/AML.cpp
-	kernel/ACPI/AML/Field.cpp
-	kernel/ACPI/AML/NamedObject.cpp
 	kernel/ACPI/AML/Namespace.cpp
 	kernel/ACPI/AML/Node.cpp
-	kernel/ACPI/AML/Package.cpp
+	kernel/ACPI/AML/OpRegion.cpp
-	kernel/ACPI/AML/Scope.cpp
+	kernel/ACPI/BatterySystem.cpp
+	kernel/ACPI/EmbeddedController.cpp
 	kernel/APIC.cpp
+	kernel/Audio/AC97/Controller.cpp
+	kernel/Audio/Controller.cpp
+	kernel/Audio/HDAudio/AudioFunctionGroup.cpp
+	kernel/Audio/HDAudio/Controller.cpp
 	kernel/BootInfo.cpp
 	kernel/CPUID.cpp
 	kernel/Credentials.cpp
@@ -17,9 +19,13 @@ set(KERNEL_SOURCES
 	kernel/Device/Device.cpp
 	kernel/Device/FramebufferDevice.cpp
 	kernel/Device/NullDevice.cpp
+	kernel/Device/RandomDevice.cpp
 	kernel/Device/ZeroDevice.cpp
+	kernel/ELF.cpp
+	kernel/Epoll.cpp
 	kernel/Errors.cpp
 	kernel/FS/DevFS/FileSystem.cpp
+	kernel/FS/EventFD.cpp
 	kernel/FS/Ext2/FileSystem.cpp
 	kernel/FS/Ext2/Inode.cpp
 	kernel/FS/FAT/FileSystem.cpp
@@ -31,9 +37,11 @@ set(KERNEL_SOURCES
 	kernel/FS/ProcFS/Inode.cpp
 	kernel/FS/TmpFS/FileSystem.cpp
 	kernel/FS/TmpFS/Inode.cpp
+	kernel/FS/USTARModule.cpp
 	kernel/FS/VirtualFileSystem.cpp
 	kernel/GDT.cpp
 	kernel/IDT.cpp
+	kernel/Input/InputDevice.cpp
 	kernel/Input/PS2/Controller.cpp
 	kernel/Input/PS2/Device.cpp
 	kernel/Input/PS2/Keyboard.cpp
@@ -42,6 +50,8 @@ set(KERNEL_SOURCES
 	kernel/Interruptable.cpp
 	kernel/InterruptController.cpp
 	kernel/kernel.cpp
+	kernel/Lock/SpinLock.cpp
+	kernel/Memory/ByteRingBuffer.cpp
 	kernel/Memory/DMARegion.cpp
 	kernel/Memory/FileBackedRegion.cpp
 	kernel/Memory/Heap.cpp
@@ -55,10 +65,12 @@ set(KERNEL_SOURCES
 	kernel/Networking/E1000/E1000.cpp
 	kernel/Networking/E1000/E1000E.cpp
 	kernel/Networking/IPv4Layer.cpp
+	kernel/Networking/Loopback.cpp
 	kernel/Networking/NetworkInterface.cpp
 	kernel/Networking/NetworkLayer.cpp
 	kernel/Networking/NetworkManager.cpp
 	kernel/Networking/NetworkSocket.cpp
+	kernel/Networking/RTL8169/RTL8169.cpp
 	kernel/Networking/TCPSocket.cpp
 	kernel/Networking/UDPSocket.cpp
 	kernel/Networking/UNIX/Socket.cpp
@@ -70,7 +82,6 @@ set(KERNEL_SOURCES
 	kernel/Processor.cpp
 	kernel/Random.cpp
 	kernel/Scheduler.cpp
-	kernel/Semaphore.cpp
 	kernel/SSP.cpp
 	kernel/Storage/ATA/AHCI/Controller.cpp
 	kernel/Storage/ATA/AHCI/Device.cpp
@@ -82,17 +93,34 @@ set(KERNEL_SOURCES
 	kernel/Storage/NVMe/Namespace.cpp
 	kernel/Storage/NVMe/Queue.cpp
 	kernel/Storage/Partition.cpp
+	kernel/Storage/SCSI.cpp
 	kernel/Storage/StorageDevice.cpp
 	kernel/Syscall.cpp
 	kernel/Terminal/FramebufferTerminal.cpp
+	kernel/Terminal/PseudoTerminal.cpp
 	kernel/Terminal/Serial.cpp
+	kernel/Terminal/TerminalDriver.cpp
+	kernel/Terminal/TextModeTerminal.cpp
 	kernel/Terminal/TTY.cpp
 	kernel/Terminal/VirtualTTY.cpp
 	kernel/Thread.cpp
+	kernel/ThreadBlocker.cpp
 	kernel/Timer/HPET.cpp
 	kernel/Timer/PIT.cpp
 	kernel/Timer/RTC.cpp
 	kernel/Timer/Timer.cpp
+	kernel/USB/Controller.cpp
+	kernel/USB/Device.cpp
+	kernel/USB/HID/HIDDriver.cpp
+	kernel/USB/HID/Joystick.cpp
+	kernel/USB/HID/Keyboard.cpp
+	kernel/USB/HID/Mouse.cpp
+	kernel/USB/Hub/HubDriver.cpp
+	kernel/USB/MassStorage/MassStorageDriver.cpp
+	kernel/USB/MassStorage/SCSIDevice.cpp
+	kernel/USB/USBManager.cpp
+	kernel/USB/XHCI/Controller.cpp
+	kernel/USB/XHCI/Device.cpp
 	icxxabi.cpp
 )
 
@@ -111,6 +139,8 @@ if("${BANAN_ARCH}" STREQUAL "x86_64")
 		arch/x86_64/Signal.S
 		arch/x86_64/Syscall.S
 		arch/x86_64/Thread.S
+		arch/x86_64/User.S
+		arch/x86_64/Yield.S
 	)
 elseif("${BANAN_ARCH}" STREQUAL "i686")
 	set(KERNEL_SOURCES
@@ -121,6 +151,8 @@ elseif("${BANAN_ARCH}" STREQUAL "i686")
 		arch/i686/Signal.S
 		arch/i686/Syscall.S
 		arch/i686/Thread.S
+		arch/i686/User.S
+		arch/i686/Yield.S
 	)
 else()
 	message(FATAL_ERROR "unsupported architecure ${BANAN_ARCH}")
@@ -136,10 +168,13 @@ set(BAN_SOURCES
 set(KLIBC_SOURCES
 	klibc/ctype.cpp
 	klibc/string.cpp
+	klibc/arch/${BANAN_ARCH}/string.S
 )
 
-set(LIBELF_SOURCES
+set(LIBDEFLATE_SOURCE
-	../userspace/libraries/LibELF/LibELF/LoadableELF.cpp
+	../userspace/libraries/LibDEFLATE/Compressor.cpp
+	../userspace/libraries/LibDEFLATE/Decompressor.cpp
+	../userspace/libraries/LibDEFLATE/HuffmanTree.cpp
 )
 
 set(LIBFONT_SOURCES
@@ -152,44 +187,62 @@ set(LIBINPUT_SOURCE
 	../userspace/libraries/LibInput/KeyEvent.cpp
 )
 
+set(LIBQR_SOURCE
+	../userspace/libraries/LibQR/QRCode.cpp
+)
+
 set(KERNEL_SOURCES
 	${KERNEL_SOURCES}
 	${BAN_SOURCES}
 	${KLIBC_SOURCES}
-	${LIBELF_SOURCES}
+	${LIBDEFLATE_SOURCE}
 	${LIBFONT_SOURCES}
 	${LIBINPUT_SOURCE}
+	${LIBQR_SOURCE}
 )
 
 add_executable(kernel ${KERNEL_SOURCES})
 
-target_compile_definitions(kernel PUBLIC __is_kernel)
+target_compile_definitions(kernel PRIVATE __is_kernel)
-target_compile_definitions(kernel PUBLIC __arch=${BANAN_ARCH})
+target_compile_definitions(kernel PRIVATE __arch=${BANAN_ARCH})
+target_compile_definitions(kernel PRIVATE LIBDEFLATE_AVOID_STACK=1)
 
-target_compile_options(kernel PUBLIC -O2 -g)
+target_compile_options(kernel PRIVATE
-target_compile_options(kernel PUBLIC $<$<COMPILE_LANGUAGE:CXX>:-Wno-literal-suffix -fno-rtti -fno-exceptions>)
+	-O2 -g
-target_compile_options(kernel PUBLIC -fmacro-prefix-map=${CMAKE_CURRENT_SOURCE_DIR}=.)
+	-fmacro-prefix-map=${CMAKE_CURRENT_SOURCE_DIR}=.
-target_compile_options(kernel PUBLIC -fstack-protector -ffreestanding -Wall -Wextra -Werror -Wstack-usage=1024 -fno-omit-frame-pointer -mgeneral-regs-only)
+	-fstack-protector
+	-ffreestanding
+	-fno-omit-frame-pointer
+	-fstrict-volatile-bitfields
+	-mgeneral-regs-only
+	-Wall -Wextra -Werror -Wstack-usage=1024
+)
 
-# This might not work with other toolchains
+# C++ specific
-target_compile_options(kernel PUBLIC $<$<COMPILE_LANGUAGE:CXX>:-Wno-invalid-offsetof>)
+target_compile_options(kernel PRIVATE
+	-Wno-literal-suffix
+	-Wno-invalid-offsetof
+	-fno-rtti
+	-fno-exceptions
+)
 
 if(ENABLE_KERNEL_UBSAN)
-	target_compile_options(kernel PUBLIC -fsanitize=undefined)
+	target_compile_options(kernel PRIVATE -fsanitize=undefined)
 endif()
 
 if("${BANAN_ARCH}" STREQUAL "x86_64")
-	target_compile_options(kernel PUBLIC -mcmodel=kernel -mno-red-zone)
+	target_compile_options(kernel PRIVATE -mcmodel=kernel -mno-red-zone)
-	target_link_options(kernel PUBLIC LINKER:-z,max-page-size=4096)
+	target_link_options(kernel PRIVATE LINKER:-z,max-page-size=4096)
-	target_link_options(kernel PUBLIC LINKER:-T,${CMAKE_CURRENT_SOURCE_DIR}/arch/x86_64/linker.ld)
+	target_link_options(kernel PRIVATE LINKER:-T,${CMAKE_CURRENT_SOURCE_DIR}/arch/x86_64/linker.ld)
 elseif("${BANAN_ARCH}" STREQUAL "i686")
-	target_link_options(kernel PUBLIC LINKER:-T,${CMAKE_CURRENT_SOURCE_DIR}/arch/i686/linker.ld)
+	target_link_options(kernel PRIVATE LINKER:-T,${CMAKE_CURRENT_SOURCE_DIR}/arch/i686/linker.ld)
 endif()
 
-target_link_options(kernel PUBLIC -ffreestanding -nostdlib)
+target_link_options(kernel PRIVATE -ffreestanding -nostdlib -orphan-handling=error)
 
-execute_process(COMMAND ${CMAKE_CXX_COMPILER} -print-file-name=crtbegin.o OUTPUT_VARIABLE CRTBEGIN OUTPUT_STRIP_TRAILING_WHITESPACE)
+get_target_property(KERNEL_COMPILE_OPTIONS kernel COMPILE_OPTIONS)
-execute_process(COMMAND ${CMAKE_CXX_COMPILER} -print-file-name=crtend.o OUTPUT_VARIABLE CRTEND OUTPUT_STRIP_TRAILING_WHITESPACE)
+execute_process(COMMAND ${CMAKE_CXX_COMPILER} ${KERNEL_COMPILE_OPTIONS} -print-file-name=crtbegin.o OUTPUT_VARIABLE CRTBEGIN OUTPUT_STRIP_TRAILING_WHITESPACE)
+execute_process(COMMAND ${CMAKE_CXX_COMPILER} ${KERNEL_COMPILE_OPTIONS} -print-file-name=crtend.o OUTPUT_VARIABLE CRTEND OUTPUT_STRIP_TRAILING_WHITESPACE)
 
 add_custom_command(
 	TARGET kernel PRE_LINK
@@ -206,9 +259,11 @@ add_custom_command(
 
 banan_include_headers(kernel ban)
 banan_include_headers(kernel libc)
-banan_include_headers(kernel libfont)
+banan_include_headers(kernel libdeflate)
 banan_include_headers(kernel libelf)
+banan_include_headers(kernel libfont)
 banan_include_headers(kernel libinput)
+banan_include_headers(kernel libqr)
 
 banan_install_headers(kernel)
 set_target_properties(kernel PROPERTIES OUTPUT_NAME banan-os.kernel)
@@ -222,7 +277,7 @@ endif()
 
 add_custom_command(
 	OUTPUT font/prefs.psf.o
-	COMMAND cd ${CMAKE_CURRENT_SOURCE_DIR} && objcopy -O ${ELF_FORMAT} -B i386 -I binary font/prefs.psf ${CMAKE_CURRENT_BINARY_DIR}/font/prefs.psf.o
+	COMMAND cd ${CMAKE_CURRENT_SOURCE_DIR} && mkdir -p ${CMAKE_CURRENT_BINARY_DIR}/font && objcopy -O ${ELF_FORMAT} -B i386 -I binary font/prefs.psf ${CMAKE_CURRENT_BINARY_DIR}/font/prefs.psf.o
 )
 
 set(CMAKE_CXX_LINK_EXECUTABLE "${CMAKE_CXX_COMPILER} <CMAKE_CXX_LINK_FLAGS> <FLAGS> <LINK_FLAGS> -o <TARGET> ${CMAKE_CURRENT_BINARY_DIR}/crti.o ${CMAKE_CURRENT_BINARY_DIR}/crtbegin.o <OBJECTS> ${CMAKE_CURRENT_BINARY_DIR}/crtend.o ${CMAKE_CURRENT_BINARY_DIR}/crtn.o -lgcc ")

kernel/arch/i686/PageTable.cpp

@@ -1,3 +1,4 @@
+#include <kernel/BootInfo.h>
 #include <kernel/CPUID.h>
 #include <kernel/Lock/SpinLock.h>
 #include <kernel/Memory/kmalloc.h>
@@ -9,6 +10,9 @@ extern uint8_t g_kernel_end[];
 extern uint8_t g_kernel_execute_start[];
 extern uint8_t g_kernel_execute_end[];
 
+extern uint8_t g_kernel_writable_start[];
+extern uint8_t g_kernel_writable_end[];
+
 extern uint8_t g_userspace_start[];
 extern uint8_t g_userspace_end[];
 
@@ -17,9 +21,15 @@ namespace Kernel
 
 	SpinLock PageTable::s_fast_page_lock;
 
+	constexpr uint64_t s_page_flag_mask = 0x8000000000000FFF;
+	constexpr uint64_t s_page_addr_mask = ~s_page_flag_mask;
+
+	static bool s_is_post_heap_done = false;
+
 	static PageTable* s_kernel = nullptr;
 	static bool s_has_nxe = false;
 	static bool s_has_pge = false;
+	static bool s_has_pat = false;
 
 	static paddr_t s_global_pdpte = 0;
 
@@ -32,8 +42,6 @@ namespace Kernel
 			result |= Flags::Execute;
 		if (entry & Flags::Reserved)
 			result |= Flags::Reserved;
-		if (entry & Flags::CacheDisable)
-			result |= Flags::CacheDisable;
 		if (entry & Flags::UserSupervisor)
 			result |= Flags::UserSupervisor;
 		if (entry & Flags::ReadWrite)
@@ -43,7 +51,7 @@ namespace Kernel
 		return result;
 	}
 
-	void PageTable::initialize()
+	void PageTable::initialize_pre_heap()
 	{
 		if (CPUID::has_nxe())
 			s_has_nxe = true;
@@ -51,6 +59,9 @@ namespace Kernel
 		if (CPUID::has_pge())
 			s_has_pge = true;
 
+		if (CPUID::has_pat())
+			s_has_pat = true;
+
 		ASSERT(s_kernel == nullptr);
 		s_kernel = new PageTable();
 		ASSERT(s_kernel);
@@ -59,6 +70,11 @@ namespace Kernel
 		s_kernel->initial_load();
 	}
 
+	void PageTable::initialize_post_heap()
+	{
+		s_is_post_heap_done = true;
+	}
+
 	void PageTable::initial_load()
 	{
 		if (s_has_nxe)
@@ -82,6 +98,17 @@ namespace Kernel
 			);
 		}
 
+		if (s_has_pat)
+		{
+			asm volatile(
+				"movl $0x277, %%ecx;"
+				"rdmsr;"
+				"movw $0x0401, %%dx;"
+				"wrmsr;"
+				::: "eax", "ecx", "edx", "memory"
+			);
+		}
+
 		// enable write protect
 		asm volatile(
 			"movl %%cr0, %%eax;"
@@ -112,6 +139,18 @@ namespace Kernel
 		return (uint64_t*)page;
 	}
 
+	template<typename T>
+	static paddr_t V2P(const T vaddr)
+	{
+		return (vaddr_t)vaddr - KERNEL_OFFSET + g_boot_info.kernel_paddr;
+	}
+
+	template<typename T>
+	static uint64_t* P2V(const T paddr)
+	{
+		return reinterpret_cast<uint64_t*>(reinterpret_cast<paddr_t>(paddr) - g_boot_info.kernel_paddr + KERNEL_OFFSET);
+	}
+
 	void PageTable::initialize_kernel()
 	{
 		ASSERT(s_global_pdpte == 0);
@@ -121,21 +160,13 @@ namespace Kernel
 
 		prepare_fast_page();
 
-		// Map main bios area below 1 MiB
-		map_range_at(
-			0x000E0000,
-			P2V(0x000E0000),
-			0x00100000 - 0x000E0000,
-			PageTable::Flags::Present
-		);
-
 		// Map (phys_kernel_start -> phys_kernel_end) to (virt_kernel_start -> virt_kernel_end)
 		ASSERT((vaddr_t)g_kernel_start % PAGE_SIZE == 0);
 		map_range_at(
 			V2P(g_kernel_start),
 			(vaddr_t)g_kernel_start,
 			g_kernel_end - g_kernel_start,
-			Flags::ReadWrite | Flags::Present
+			Flags::Present
 		);
 
 		// Map executable kernel memory as executable
@@ -146,6 +177,14 @@ namespace Kernel
 			Flags::Execute | Flags::Present
 		);
 
+		// Map writable kernel memory as writable
+		map_range_at(
+			V2P(g_kernel_writable_start),
+			(vaddr_t)g_kernel_writable_start,
+			g_kernel_writable_end - g_kernel_writable_start,
+			Flags::ReadWrite | Flags::Present
+		);
+
 		// Map userspace memory
 		map_range_at(
 			V2P(g_userspace_start),
@@ -161,22 +200,23 @@ namespace Kernel
 		constexpr uint64_t pde   = (fast_page() >> 21) & 0x1FF;
 		constexpr uint64_t pte   = (fast_page() >> 12) & 0x1FF;
 
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(m_highest_paging_struct));
+		const uint64_t* pdpt = P2V(m_highest_paging_struct);
 		ASSERT(pdpt[pdpte] & Flags::Present);
 
-		uint64_t* pd = reinterpret_cast<uint64_t*>(P2V(pdpt[pdpte]) & PAGE_ADDR_MASK);
+		uint64_t* pd = P2V(pdpt[pdpte] & s_page_addr_mask);
 		ASSERT(!(pd[pde] & Flags::Present));
 		pd[pde] = V2P(allocate_zeroed_page_aligned_page()) | Flags::ReadWrite | Flags::Present;
 
-		uint64_t* pt = reinterpret_cast<uint64_t*>(P2V(pd[pde]) & PAGE_ADDR_MASK);
+		uint64_t* pt = P2V(pd[pde] & s_page_addr_mask);
-		ASSERT(!(pt[pte] & Flags::Present));
+		ASSERT(pt[pte] == 0);
-		pt[pte] = V2P(allocate_zeroed_page_aligned_page());
+		pt[pte] = Flags::Reserved;
 	}
 
 	void PageTable::map_fast_page(paddr_t paddr)
 	{
 		ASSERT(s_kernel);
 		ASSERT(paddr);
+		ASSERT(paddr % PAGE_SIZE == 0);
 
 		ASSERT(s_fast_page_lock.current_processor_has_lock());
 
@@ -184,14 +224,14 @@ namespace Kernel
 		constexpr uint64_t pde   = (fast_page() >> 21) & 0x1FF;
 		constexpr uint64_t pte   = (fast_page() >> 12) & 0x1FF;
 
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(s_kernel->m_highest_paging_struct));
+		uint64_t* pdpt = P2V(s_kernel->m_highest_paging_struct);
-		uint64_t* pd   = reinterpret_cast<uint64_t*>(P2V(pdpt[pdpte] & PAGE_ADDR_MASK));
+		uint64_t* pd   = P2V(pdpt[pdpte] & s_page_addr_mask);
-		uint64_t* pt   = reinterpret_cast<uint64_t*>(P2V(pd[pde] & PAGE_ADDR_MASK));
+		uint64_t* pt   = P2V(pd[pde] & s_page_addr_mask);
 
 		ASSERT(!(pt[pte] & Flags::Present));
 		pt[pte] = paddr | Flags::ReadWrite | Flags::Present;
 
-		invalidate(fast_page());
+		asm volatile("invlpg (%0)" :: "r"(fast_page()) : "memory");
 	}
 
 	void PageTable::unmap_fast_page()
@@ -204,14 +244,14 @@ namespace Kernel
 		constexpr uint64_t pde   = (fast_page() >> 21) & 0x1FF;
 		constexpr uint64_t pte   = (fast_page() >> 12) & 0x1FF;
 
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(s_kernel->m_highest_paging_struct));
+		uint64_t* pdpt = P2V(s_kernel->m_highest_paging_struct);
-		uint64_t* pd   = reinterpret_cast<uint64_t*>(P2V(pdpt[pdpte] & PAGE_ADDR_MASK));
+		uint64_t* pd   = P2V(pdpt[pdpte] & s_page_addr_mask);
-		uint64_t* pt   = reinterpret_cast<uint64_t*>(P2V(pd[pde] & PAGE_ADDR_MASK));
+		uint64_t* pt   = P2V(pd[pde] & s_page_addr_mask);
 
 		ASSERT(pt[pte] & Flags::Present);
-		pt[pte] = 0;
+		pt[pte] = Flags::Reserved;
 
-		invalidate(fast_page());
+		asm volatile("invlpg (%0)" :: "r"(fast_page()) : "memory");
 	}
 
 	BAN::ErrorOr<PageTable*> PageTable::create_userspace()
@@ -233,7 +273,7 @@ namespace Kernel
 		m_highest_paging_struct = V2P(kmalloc(32, 32, true));
 		ASSERT(m_highest_paging_struct);
 
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(m_highest_paging_struct));
+		uint64_t* pdpt = P2V(m_highest_paging_struct);
 		pdpt[0] = 0;
 		pdpt[1] = 0;
 		pdpt[2] = 0;
@@ -243,18 +283,20 @@ namespace Kernel
 
 	PageTable::~PageTable()
 	{
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(m_highest_paging_struct));
+		if (m_highest_paging_struct == 0)
+			return;
 
+		uint64_t* pdpt = P2V(m_highest_paging_struct);
 		for (uint32_t pdpte = 0; pdpte < 3; pdpte++)
 		{
 			if (!(pdpt[pdpte] & Flags::Present))
 				continue;
-			uint64_t* pd = reinterpret_cast<uint64_t*>(P2V(pdpt[pdpte] & PAGE_ADDR_MASK));
+			uint64_t* pd = P2V(pdpt[pdpte] & s_page_addr_mask);
 			for (uint32_t pde = 0; pde < 512; pde++)
 			{
 				if (!(pd[pde] & Flags::Present))
 					continue;
-				kfree(reinterpret_cast<uint64_t*>(P2V(pd[pde] & PAGE_ADDR_MASK)));
+				kfree(P2V(pd[pde] & s_page_addr_mask));
 			}
 			kfree(pd);
 		}
@@ -265,18 +307,58 @@ namespace Kernel
 	{
 		SpinLockGuard _(m_lock);
 		ASSERT(m_highest_paging_struct < 0x100000000);
-		const uint32_t pdpt_lo = m_highest_paging_struct;
+		asm volatile("movl %0, %%cr3" :: "r"(static_cast<uint32_t>(m_highest_paging_struct)));
-		asm volatile("movl %0, %%cr3" :: "r"(pdpt_lo));
 		Processor::set_current_page_table(this);
 	}
 
-	void PageTable::invalidate(vaddr_t vaddr)
+	void PageTable::invalidate_range(vaddr_t vaddr, size_t pages, bool send_smp_message)
 	{
 		ASSERT(vaddr % PAGE_SIZE == 0);
-		asm volatile("invlpg (%0)" :: "r"(vaddr) : "memory");
+
+		const bool is_userspace = (vaddr < KERNEL_OFFSET);
+		if (is_userspace && this != &PageTable::current())
+			;
+		else if (pages <= 32 || !s_is_post_heap_done)
+		{
+			for (size_t i = 0; i < pages; i++, vaddr += PAGE_SIZE)
+				asm volatile("invlpg (%0)" :: "r"(vaddr));
+		}
+		else if (is_userspace || !s_has_pge)
+		{
+			asm volatile("movl %0, %%cr3" :: "r"(static_cast<uint32_t>(m_highest_paging_struct)));
+		}
+		else
+		{
+			asm volatile(
+				"movl %%cr4, %%eax;"
+
+				"andl $~0x80, %%eax;"
+				"movl %%eax, %%cr4;"
+
+				"movl %0, %%cr3;"
+
+				"orl $0x80, %%eax;"
+				"movl %%eax, %%cr4;"
+				:
+				: "r"(static_cast<uint32_t>(m_highest_paging_struct))
+				: "eax"
+			);
 		}
 
-	void PageTable::unmap_page(vaddr_t vaddr)
+		if (send_smp_message)
+		{
+			Processor::broadcast_smp_message({
+				.type = Processor::SMPMessage::Type::FlushTLB,
+				.flush_tlb = {
+					.vaddr      = vaddr,
+					.page_count = pages,
+					.page_table = vaddr < KERNEL_OFFSET ? this : nullptr,
+				}
+			});
+		}
+	}
+
+	void PageTable::unmap_page(vaddr_t vaddr, bool invalidate)
 	{
 		ASSERT(vaddr);
 		ASSERT(vaddr % PAGE_SIZE == 0);
@@ -293,30 +375,33 @@ namespace Kernel
 		SpinLockGuard _(m_lock);
 
 		if (is_page_free(vaddr))
-		{
+			Kernel::panic("trying to unmap unmapped page 0x{H}", vaddr);
-			dwarnln("unmapping unmapped page {8H}", vaddr);
-			return;
-		}
 
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(m_highest_paging_struct));
+		uint64_t* pdpt = P2V(m_highest_paging_struct);
-		uint64_t* pd   = reinterpret_cast<uint64_t*>(P2V(pdpt[pdpte] & PAGE_ADDR_MASK));
+		uint64_t* pd   = P2V(pdpt[pdpte] & s_page_addr_mask);
-		uint64_t* pt   = reinterpret_cast<uint64_t*>(P2V(pd[pde] & PAGE_ADDR_MASK));
+		uint64_t* pt   = P2V(pd[pde] & s_page_addr_mask);
+
+		const paddr_t old_paddr = pt[pte] & s_page_addr_mask;
 
 		pt[pte] = 0;
-		invalidate(vaddr);
+
+		if (invalidate && old_paddr != 0)
+			invalidate_page(vaddr, true);
 	}
 
 	void PageTable::unmap_range(vaddr_t vaddr, size_t size)
 	{
-		vaddr_t s_page = vaddr / PAGE_SIZE;
+		ASSERT(vaddr % PAGE_SIZE == 0);
-		vaddr_t e_page = BAN::Math::div_round_up<vaddr_t>(vaddr + size, PAGE_SIZE);
+
+		size_t page_count = range_page_count(vaddr, size);
 
 		SpinLockGuard _(m_lock);
-		for (vaddr_t page = s_page; page < e_page; page++)
+		for (vaddr_t page = 0; page < page_count; page++)
-			unmap_page(page * PAGE_SIZE);
+			unmap_page(vaddr + page * PAGE_SIZE, false);
+		invalidate_range(vaddr, page_count, true);
 	}
 
-	void PageTable::map_page_at(paddr_t paddr, vaddr_t vaddr, flags_t flags)
+	void PageTable::map_page_at(paddr_t paddr, vaddr_t vaddr, flags_t flags, MemoryType memory_type, bool invalidate)
 	{
 		ASSERT(vaddr);
 		ASSERT(vaddr != fast_page());
@@ -338,19 +423,24 @@ namespace Kernel
 			extra_flags |= 1ull << 63;
 		if (flags & Flags::Reserved)
 			extra_flags |= Flags::Reserved;
-		if (flags & Flags::CacheDisable)
+
-			extra_flags |= Flags::CacheDisable;
+		if (memory_type == MemoryType::Uncached)
+			extra_flags |= (1ull << 4);
+		if (s_has_pat && memory_type == MemoryType::WriteCombining)
+			extra_flags |= (1ull << 7);
+		if (s_has_pat && memory_type == MemoryType::WriteThrough)
+			extra_flags |= (1ull << 7) | (1ull << 3);
 
 		// NOTE: we add present here, since it has to be available in higher level structures
 		flags_t uwr_flags = (flags & (Flags::UserSupervisor | Flags::ReadWrite)) | Flags::Present;
 
 		SpinLockGuard _(m_lock);
 
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(m_highest_paging_struct));
+		uint64_t* pdpt = P2V(m_highest_paging_struct);
 		if (!(pdpt[pdpte] & Flags::Present))
 			pdpt[pdpte] = V2P(allocate_zeroed_page_aligned_page()) | Flags::Present;
 
-		uint64_t* pd = reinterpret_cast<uint64_t*>(P2V(pdpt[pdpte] & PAGE_ADDR_MASK));
+		uint64_t* pd = P2V(pdpt[pdpte] & s_page_addr_mask);
 		if ((pd[pde] & uwr_flags) != uwr_flags)
 		{
 			if (!(pd[pde] & Flags::Present))
@@ -361,13 +451,17 @@ namespace Kernel
 		if (!(flags & Flags::Present))
 			uwr_flags &= ~Flags::Present;
 
-		uint64_t* pt = reinterpret_cast<uint64_t*>(P2V(pd[pde] & PAGE_ADDR_MASK));
+		uint64_t* pt = P2V(pd[pde] & s_page_addr_mask);
+
+		const paddr_t old_paddr = pt[pte] & s_page_addr_mask;
+
 		pt[pte] = paddr | uwr_flags | extra_flags;
 
-		invalidate(vaddr);
+		if (invalidate && old_paddr != 0)
+			invalidate_page(vaddr, true);
 	}
 
-	void PageTable::map_range_at(paddr_t paddr, vaddr_t vaddr, size_t size, flags_t flags)
+	void PageTable::map_range_at(paddr_t paddr, vaddr_t vaddr, size_t size, flags_t flags, MemoryType memory_type)
 	{
 		ASSERT(vaddr);
 		ASSERT(paddr % PAGE_SIZE == 0);
@@ -377,7 +471,50 @@ namespace Kernel
 
 		SpinLockGuard _(m_lock);
 		for (size_t page = 0; page < page_count; page++)
-			map_page_at(paddr + page * PAGE_SIZE, vaddr + page * PAGE_SIZE, flags);
+			map_page_at(paddr + page * PAGE_SIZE, vaddr + page * PAGE_SIZE, flags, memory_type, false);
+		invalidate_range(vaddr, page_count, true);
+	}
+
+	void PageTable::remove_writable_from_range(vaddr_t vaddr, size_t size)
+	{
+		ASSERT(vaddr);
+		ASSERT(vaddr % PAGE_SIZE == 0);
+
+		uint32_t pdpte = (vaddr >> 30) & 0x1FF;
+		uint32_t pde   = (vaddr >> 21) & 0x1FF;
+		uint32_t pte   = (vaddr >> 12) & 0x1FF;
+
+		const uint32_t e_pdpte = ((vaddr + size - 1) >> 30) & 0x1FF;
+		const uint32_t e_pde   = ((vaddr + size - 1) >> 21) & 0x1FF;
+		const uint32_t e_pte   = ((vaddr + size - 1) >> 12) & 0x1FF;
+
+		SpinLockGuard _(m_lock);
+
+		const uint64_t* pdpt = P2V(m_highest_paging_struct);
+		for (; pdpte <= e_pdpte; pdpte++)
+		{
+			if (!(pdpt[pdpte] & Flags::Present))
+				continue;
+			const uint64_t* pd = P2V(pdpt[pdpte] & s_page_addr_mask);
+			for (; pde < 512; pde++)
+			{
+				if (pdpte == e_pdpte && pde > e_pde)
+					break;
+				if (!(pd[pde] & Flags::ReadWrite))
+					continue;
+				uint64_t* pt = P2V(pd[pde] & s_page_addr_mask);
+				for (; pte < 512; pte++)
+				{
+					if (pdpte == e_pdpte && pde == e_pde && pte > e_pte)
+						break;
+					pt[pte] &= ~static_cast<uint64_t>(Flags::ReadWrite);
+				}
+				pte = 0;
+			}
+			pde = 0;
+		}
+
+		invalidate_range(vaddr, size / PAGE_SIZE, true);
 	}
 
 	uint64_t PageTable::get_page_data(vaddr_t vaddr) const
@@ -390,15 +527,15 @@ namespace Kernel
 
 		SpinLockGuard _(m_lock);
 
-		uint64_t* pdpt = (uint64_t*)P2V(m_highest_paging_struct);
+		const uint64_t* pdpt = P2V(m_highest_paging_struct);
 		if (!(pdpt[pdpte] & Flags::Present))
 			return 0;
 
-		uint64_t* pd = (uint64_t*)P2V(pdpt[pdpte] & PAGE_ADDR_MASK);
+		const uint64_t* pd = P2V(pdpt[pdpte] & s_page_addr_mask);
 		if (!(pd[pde] & Flags::Present))
 			return 0;
 
-		uint64_t* pt = (uint64_t*)P2V(pd[pde] & PAGE_ADDR_MASK);
+		const uint64_t* pt = P2V(pd[pde] & s_page_addr_mask);
 		if (!(pt[pte] & Flags::Used))
 			return 0;
 
@@ -412,8 +549,7 @@ namespace Kernel
 
 	paddr_t PageTable::physical_address_of(vaddr_t vaddr) const
 	{
-		uint64_t page_data = get_page_data(vaddr);
+		return get_page_data(vaddr) & s_page_addr_mask;
-		return (page_data & PAGE_ADDR_MASK) & ~(1ull << 63);
 	}
 
 	bool PageTable::is_page_free(vaddr_t vaddr) const
@@ -434,13 +570,13 @@ namespace Kernel
 		return true;
 	}
 
-	bool PageTable::reserve_page(vaddr_t vaddr, bool only_free)
+	bool PageTable::reserve_page(vaddr_t vaddr, bool only_free, bool send_smp_message)
 	{
 		SpinLockGuard _(m_lock);
 		ASSERT(vaddr % PAGE_SIZE == 0);
 		if (only_free && !is_page_free(vaddr))
 			return false;
-		map_page_at(0, vaddr, Flags::Reserved);
+		map_page_at(0, vaddr, Flags::Reserved, MemoryType::Normal, send_smp_message);
 		return true;
 	}
 
@@ -454,7 +590,9 @@ namespace Kernel
 		if (only_free && !is_range_free(vaddr, bytes))
 			return false;
 		for (size_t offset = 0; offset < bytes; offset += PAGE_SIZE)
-			reserve_page(vaddr + offset);
+			reserve_page(vaddr + offset, true, false);
+		invalidate_range(vaddr, bytes / PAGE_SIZE, true);
+
 		return true;
 	}
 
@@ -467,39 +605,37 @@ namespace Kernel
 		if (size_t rem = last_address % PAGE_SIZE)
 			last_address -= rem;
 
-		const uint32_t s_pdpte = (first_address >> 30) & 0x1FF;
+		uint32_t pdpte = (first_address >> 30) & 0x1FF;
-		const uint32_t s_pde   = (first_address >> 21) & 0x1FF;
+		uint32_t pde   = (first_address >> 21) & 0x1FF;
-		const uint32_t s_pte   = (first_address >> 12) & 0x1FF;
+		uint32_t pte   = (first_address >> 12) & 0x1FF;
 
-		const uint32_t e_pdpte = (last_address >> 30) & 0x1FF;
+		const uint32_t e_pdpte = ((last_address - 1) >> 30) & 0x1FF;
-		const uint32_t e_pde   = (last_address >> 21) & 0x1FF;
+		const uint32_t e_pde   = ((last_address - 1) >> 21) & 0x1FF;
-		const uint32_t e_pte   = (last_address >> 12) & 0x1FF;
+		const uint32_t e_pte   = ((last_address - 1) >> 12) & 0x1FF;
 
 		SpinLockGuard _(m_lock);
 
 		// Try to find free page that can be mapped without
 		// allocations (page table with unused entries)
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(m_highest_paging_struct));
+		const uint64_t* pdpt = P2V(m_highest_paging_struct);
-		for (uint32_t pdpte = s_pdpte; pdpte < 4; pdpte++)
+		for (; pdpte <= e_pdpte; pdpte++)
 		{
-			if (pdpte > e_pdpte)
-				break;
 			if (!(pdpt[pdpte] & Flags::Present))
 				continue;
-			uint64_t* pd = reinterpret_cast<uint64_t*>(P2V(pdpt[pdpte] & PAGE_ADDR_MASK));
+			const uint64_t* pd = P2V(pdpt[pdpte] & s_page_addr_mask);
-			for (uint32_t pde = s_pde; pde < 512; pde++)
+			for (; pde < 512; pde++)
 			{
 				if (pdpte == e_pdpte && pde > e_pde)
 					break;
 				if (!(pd[pde] & Flags::Present))
 					continue;
-				uint64_t* pt = (uint64_t*)P2V(pd[pde] & PAGE_ADDR_MASK);
+				const uint64_t* pt = P2V(pd[pde] & s_page_addr_mask);
-				for (uint32_t pte = s_pte; pte < 512; pte++)
+				for (; pte < 512; pte++)
 				{
-					if (pdpte == e_pdpte && pde == e_pde && pte >= e_pte)
+					if (pdpte == e_pdpte && pde == e_pde && pte > e_pte)
 						break;
-					if (!(pt[pte] & Flags::Used))
+					if (pt[pte] & Flags::Used)
-					{
+						continue;
 					vaddr_t vaddr = 0;
 					vaddr |= (vaddr_t)pdpte << 30;
 					vaddr |= (vaddr_t)pde   << 21;
@@ -507,8 +643,9 @@ namespace Kernel
 					ASSERT(reserve_page(vaddr));
 					return vaddr;
 				}
+				pte = 0;
 			}
-			}
+			pde = 0;
 		}
 
 		// Find any free page
@@ -521,7 +658,7 @@ namespace Kernel
 			}
 		}
 
-		ASSERT_NOT_REACHED();
+		return 0;
 	}
 
 	vaddr_t PageTable::reserve_free_contiguous_pages(size_t page_count, vaddr_t first_address, vaddr_t last_address)
@@ -554,7 +691,7 @@ namespace Kernel
 			}
 		}
 
-		ASSERT_NOT_REACHED();
+		return 0;
 	}
 
 	static void dump_range(vaddr_t start, vaddr_t end, PageTable::flags_t flags)
@@ -577,7 +714,7 @@ namespace Kernel
 		flags_t flags = 0;
 		vaddr_t start = 0;
 
-		uint64_t* pdpt = reinterpret_cast<uint64_t*>(P2V(m_highest_paging_struct));
+		const uint64_t* pdpt = P2V(m_highest_paging_struct);
 		for (uint32_t pdpte = 0; pdpte < 4; pdpte++)
 		{
 			if (!(pdpt[pdpte] & Flags::Present))
@@ -586,7 +723,7 @@ namespace Kernel
 				start = 0;
 				continue;
 			}
-			uint64_t* pd = (uint64_t*)P2V(pdpt[pdpte] & PAGE_ADDR_MASK);
+			const uint64_t* pd = P2V(pdpt[pdpte] & s_page_addr_mask);
 			for (uint64_t pde = 0; pde < 512; pde++)
 			{
 				if (!(pd[pde] & Flags::Present))
@@ -595,7 +732,7 @@ namespace Kernel
 					start = 0;
 					continue;
 				}
-				uint64_t* pt = (uint64_t*)P2V(pd[pde] & PAGE_ADDR_MASK);
+				const uint64_t* pt = P2V(pd[pde] & s_page_addr_mask);
 				for (uint64_t pte = 0; pte < 512; pte++)
 				{
 					if (parse_flags(pt[pte]) != flags)

kernel/arch/i686/Signal.S

@@ -1,35 +1,86 @@
-.section .userspace, "aw"
+.section .userspace, "ax"
 
 // stack contains
-//    return address
+//    (4 bytes)  return address (on return stack)
-//    signal number
+//    (4 bytes)  return stack
-//    signal handler
+//    (4 bytes)  return rflags
+//    (8 bytes)  restore sigmask
+//    (36 bytes) siginfo_t
+//    (4 bytes)  signal number
+//    (4 bytes)  signal handler
 
 .global signal_trampoline
 signal_trampoline:
+	pushl %esi // gregs
+	pushl %edi
+	pushl %edx
+	pushl %ecx
+	pushl %ebx
+	pushl %eax
 	pushl %ebp
-	movl %esp, %ebp
 
-	pusha
+	movl 80(%esp), %eax
+	pushl %eax; addl $4, (%esp)
+	pushl (%eax)
 
-	movl 40(%esp), %edi
+	// FIXME: populate these
-	movl 36(%esp), %eax
+	xorl %eax, %eax
+	pushl %eax // stack
+	pushl %eax
+	pushl %eax
+	pushl %eax // sigset
+	pushl %eax
+	pushl %eax // link
+
+	movl    %esp,  %edx // ucontext
+	leal 68(%esp), %esi // siginfo
+	movl 64(%esp), %edi // signal number
+	movl 60(%esp), %eax // handlers
 
 	// align stack to 16 bytes
-	movl %esp, %ebx
+	movl %esp, %ebp
-	andl $0x0F, %ebx
+	andl $-16, %esp
-	subl %ebx, %esp
 
-	subl $12, %esp
+	subl $512, %esp
+	fxsave (%esp)
+
+	subl $4, %esp
+	pushl %edx
+	pushl %esi
 	pushl %edi
 	call *%eax
 	addl $16, %esp
 
-	// restore stack
+	fxrstor (%esp)
-	addl %ebx, %esp
+	addl $512, %esp
-	popa
 
-	leave
+	// restore stack
+	movl %ebp, %esp
+	addl $24, %esp
+
+	// restore sigmask
+	movl $83, %eax      // SYS_SIGPROCMASK
+	movl $3,  %ebx      // SIG_SETMASK
+	leal 72(%esp), %ecx // set
+	xorl %edx, %edx     // oset
+	int $0xF0
+
+	// restore registers
 	addl $8, %esp
+	popl %ebp
+	popl %eax
+	popl %ebx
+	popl %ecx
+	popl %edx
+	popl %edi
+	popl %esi
+
+	// skip handler, number, siginfo_t, sigmask
+	addl $52, %esp
+
+	// restore flags
+	popf
+
+	movl (%esp), %esp
 
 	ret

kernel/arch/i686/Syscall.S

@@ -1,12 +1,6 @@
 // arguments in EAX, EBX, ECX, EDX, ESI, EDI
 .global asm_syscall_handler
 asm_syscall_handler:
-	# save segment registers
-	pushw %ds
-	pushw %es
-	pushw %fs
-	pushw %gs
-
 	# save general purpose registers
 	pushl %ebx
 	pushl %ecx
@@ -14,10 +8,14 @@ asm_syscall_handler:
 	pushl %edi
 	pushl %esi
 	pushl %ebp
+	cld
 
-	# align stack and push arguments
+	# align stack
-	pushl %esp
+	movl %esp, %ebp
-	addl $32, (%esp)
+	andl $-16, %esp
+
+	# push arguments
+	subl $8, %esp
 	pushl %edi
 	pushl %esi
 	pushl %edx
@@ -34,7 +32,17 @@ asm_syscall_handler:
 	movw %ax, %gs
 
 	call cpp_syscall_handler
-	addl $28, %esp
+
+	movl %ebp, %esp
+
+	# restore userspace segments
+	movw $(0x20 | 3), %bx
+	movw %bx, %ds
+	movw %bx, %es
+	movw $(0x30 | 3), %bx
+	movw %bx, %fs
+	movw $(0x38 | 3), %bx
+	movw %bx, %gs
 
 	# restore general purpose registers
 	popl %ebp
@@ -44,12 +52,6 @@ asm_syscall_handler:
 	popl %ecx
 	popl %ebx
 
-	# restore segment registers
-	popw %gs
-	popw %fs
-	popw %es
-	popw %ds
-
 	iret
 
 .global sys_fork_trampoline
@@ -61,7 +63,7 @@ sys_fork_trampoline:
 
 	call read_ip
 	testl %eax, %eax
-	jz .reload_stack
+	jz .done
 
 	movl %esp, %ebx
 
@@ -77,9 +79,3 @@ sys_fork_trampoline:
 	popl %ebx
 	popl %ebp
 	ret
-
- .reload_stack:
-	call get_thread_start_sp
-	movl %eax, %esp
-	xorl %eax, %eax
-	jmp .done

kernel/arch/i686/Thread.S

@@ -7,9 +7,6 @@ read_ip:
 # void start_kernel_thread()
 .global start_kernel_thread
 start_kernel_thread:
-	call get_thread_start_sp
-	movl %eax, %esp
-
 	# STACK LAYOUT
 	#   on_exit arg
 	#   on_exit func
@@ -31,38 +28,15 @@ start_kernel_thread:
 	subl $12, %esp
 	pushl %edi
 	call *%esi
-	addl $16, %esp
-
 
 .global start_userspace_thread
 start_userspace_thread:
-	call get_thread_start_sp
-	movl %eax, %esp
-
-	# STACK LAYOUT
-	#   entry
-	#   argc
-	#   argv
-	#   envp
-	#   userspace stack
-
-	call get_userspace_thread_stack_top
-
 	movw $(0x20 | 3), %bx
 	movw %bx, %ds
 	movw %bx, %es
+	movw $(0x30 | 3), %bx
 	movw %bx, %fs
+	movw $(0x38 | 3), %bx
 	movw %bx, %gs
-	xorw %bx, %bx
 
-	popl %edx
-	popl %esi
-	popl %edi
-	popl %ecx
-
-	pushl $(0x20 | 3)
-	pushl %eax
-	pushl $0x202
-	pushl $(0x18 | 3)
-	pushl %ecx
 	iret

kernel/arch/i686/User.S

@@ -0,0 +1,54 @@
+# bool safe_user_memcpy(void*, const void*, size_t)
+.global safe_user_memcpy
+.global safe_user_memcpy_end
+.global safe_user_memcpy_fault
+safe_user_memcpy:
+	xorl %eax, %eax
+	xchgl 4(%esp), %edi
+	xchgl 8(%esp), %esi
+	movl 12(%esp), %ecx
+	movl %edi, %edx
+	rep movsb
+	movl 4(%esp), %edi
+	movl 8(%esp), %esi
+	incl %eax
+safe_user_memcpy_fault:
+	ret
+safe_user_memcpy_end:
+
+# bool safe_user_strncpy(void*, const void*, size_t)
+.global safe_user_strncpy
+.global safe_user_strncpy_end
+.global safe_user_strncpy_fault
+safe_user_strncpy:
+	xchgl 4(%esp), %edi
+	xchgl 8(%esp), %esi
+	movl 12(%esp), %ecx
+
+	testl %ecx, %ecx
+	jz safe_user_strncpy_fault
+
+ .safe_user_strncpy_loop:
+	movb (%esi), %al
+	movb %al, (%edi)
+	testb %al, %al
+	jz .safe_user_strncpy_done
+
+	incl %edi
+	incl %esi
+	decl %ecx
+	jnz .safe_user_strncpy_loop
+
+ safe_user_strncpy_fault:
+	xorl %eax, %eax
+	jmp .safe_user_strncpy_return
+
+ .safe_user_strncpy_done:
+	movl $1, %eax
+
+ .safe_user_strncpy_return:
+	movl 4(%esp), %edi
+	movl 8(%esp), %esi
+	ret
+
+safe_user_strncpy_end:

kernel/arch/i686/Yield.S

@@ -0,0 +1,25 @@
+.global asm_yield_trampoline
+asm_yield_trampoline:
+	leal 4(%esp), %ecx
+	movl 4(%esp), %esp
+
+	pushl -4(%ecx)
+	pushl %ecx
+	pushl %eax
+	pushl %ebx
+	pushl %esi
+	pushl %edi
+	pushl %ebp
+
+	pushl %esp
+	call scheduler_on_yield
+	addl $4, %esp
+
+	popl %ebp
+	popl %edi
+	popl %esi
+	popl %ebx
+	popl %eax
+	movl 4(%esp), %ecx
+	movl 0(%esp), %esp
+	jmp *%ecx

kernel/arch/i686/boot.S

@@ -11,9 +11,28 @@
 
 .code32
 
-# multiboot2 header
+// video mode info, page align modules
+.set multiboot_flags, (1 << 2) | (1 << 0)
+
 .section .multiboot, "aw"
-	.align 8
+multiboot_start:
+	.long 0x1BADB002
+	.long multiboot_flags
+	.long -(0x1BADB002 + multiboot_flags)
+
+	.long 0
+	.long 0
+	.long 0
+	.long 0
+	.long 0
+
+	.long 0
+	.long FB_WIDTH
+	.long FB_HEIGHT
+	.long FB_BPP
+multiboot_end:
+
+.section .multiboot2, "aw"
 multiboot2_start:
 	.long 0xE85250D6
 	.long 0
@@ -36,6 +55,12 @@ multiboot2_start:
 	.long 12
 	.long V2P(_start)
 
+	# page align modules
+	.align 8
+	.short 6
+	.short 0
+	.long 8
+
 	.align 8
 	.short 0
 	.short 0
@@ -43,7 +68,6 @@ multiboot2_start:
 multiboot2_end:
 
 .section .bananboot, "aw"
-	.align 8
 bananboot_start:
 	.long 0xBABAB007
 	.long -(0xBABAB007 + FB_WIDTH + FB_HEIGHT + FB_BPP)
@@ -53,10 +77,10 @@ bananboot_start:
 bananboot_end:
 
 .section .bss, "aw", @nobits
-	.align 4096
+    .global g_boot_stack_top
-	boot_stack_bottom:
+	g_boot_stack_bottom:
 		.skip 4096 * 4
-	boot_stack_top:
+	g_boot_stack_top:
 
 	.global g_kernel_cmdline
 	g_kernel_cmdline:
@@ -161,6 +185,13 @@ enable_sse:
 	movl %eax, %cr4
 	ret
 
+enable_tsc:
+	# allow userspace to use RDTSC
+	movl %cr4, %ecx
+	andl $0xFFFFFFFB, %ecx
+	movl %ecx, %cr4
+	ret
+
 initialize_paging:
 	# enable PAE
 	movl %cr4, %ecx
@@ -188,7 +219,7 @@ _start:
 	movl %ebx, V2P(bootloader_info)
 
 	# load boot stack
-	movl $V2P(boot_stack_top), %esp
+	movl $V2P(g_boot_stack_top), %esp
 
 	# load boot GDT
 	lgdt V2P(boot_gdtr)
@@ -203,10 +234,11 @@ gdt_flush:
 	# do processor initialization
 	call check_requirements
 	call enable_sse
+	call enable_tsc
 	call initialize_paging
 
 	# load higher half stack pointer
-	movl $boot_stack_top, %esp
+	movl $g_boot_stack_top, %esp
 
 	# jump to higher half
 	leal higher_half, %ecx
@@ -216,6 +248,13 @@ higher_half:
 	# call global constuctors
 	call _init
 
+	movl $g_init_array_start, %ebx
+	jmp 2f
+ 1: call *(%ebx)
+	addl $4, %ebx
+ 2: cmpl $g_init_array_end, %ebx
+	jne 1b
+
 	# call to the kernel itself (clear ebp for stacktrace)
 	xorl %ebp, %ebp
 
@@ -235,26 +274,31 @@ system_halt:
 	jmp 1b
 
 
+#define AP_V2P(vaddr) ((vaddr) - ap_trampoline + 0xF000)
+
 .section .ap_init, "ax"
 
 .code16
 .global ap_trampoline
 ap_trampoline:
 	jmp 1f
+
 .align 8
 ap_stack_ptr:
 	.skip 4
-1:
+ap_stack_loaded:
-	cli; cld
+	.skip 1
-	ljmpl $0x00, $ap_cs_clear
-ap_cs_clear:
 
+1:	cli; cld
+	ljmpl $0x00, $AP_V2P(ap_cs_clear)
+
+ap_cs_clear:
 	# load ap gdt and enter protected mode
-	lgdt ap_gdtr
+	lgdt AP_V2P(ap_gdtr)
 	movl %cr0, %eax
 	orb $1, %al
 	movl %eax, %cr0
-	ljmpl $0x08, $ap_protected_mode
+	ljmpl $0x08, $AP_V2P(ap_protected_mode)
 
 .code32
 ap_protected_mode:
@@ -263,16 +307,16 @@ ap_protected_mode:
 	movw %ax, %ss
 	movw %ax, %es
 
-	movl ap_stack_ptr, %esp
+	movl AP_V2P(ap_stack_ptr), %esp
-	movb $1, V2P(g_ap_stack_loaded)
+	movb $1, AP_V2P(ap_stack_loaded)
 
-	call V2P(enable_sse)
+	leal V2P(enable_sse),        %ecx; call *%ecx
-
+	leal V2P(enable_tsc),        %ecx; call *%ecx
-	call V2P(initialize_paging)
+	leal V2P(initialize_paging), %ecx; call *%ecx
 
 	# load boot gdt and enter long mode
 	lgdt V2P(boot_gdtr)
-	ljmpl $0x08, $ap_flush_gdt
+	ljmpl $0x08, $AP_V2P(ap_flush_gdt)
 
 ap_flush_gdt:
 	# move stack pointer to higher half

kernel/arch/i686/crt0.S

@@ -1,23 +0,0 @@
-.section .text
-
-.global _start
-_start:
-	# Set up end of the stack frame linked list.
-	movl $0, %ebp
-	pushl %ebp # rip=0
-	pushl %ebp # rbp=0
-	movl %esp, %ebp
-
-	# Prepare signals, memory allocation, stdio and such.
-	#call initialize_standard_library
-
-	# Run the global constructors.
-	call _init
-
-	# Run main
-	call main
-
-	# Terminate the process with the exit code.
-	movl %eax, %edi
-	call exit
-.size _start, . - _start

kernel/arch/i686/crti.S

@@ -1,9 +1,9 @@
-/* x86 crti.s */
+/* i686 crti.s */
 .section .init
 .global _init
 .type _init, @function
 _init:
-	push %ebp
+	pushl %ebp
 	movl %esp, %ebp
 	/* gcc will nicely put the contents of crtbegin.o's .init section here. */
 
@@ -11,6 +11,6 @@ _init:
 .global _fini
 .type _fini, @function
 _fini:
-	push %ebp
+	pushl %ebp
 	movl %esp, %ebp
 	/* gcc will nicely put the contents of crtbegin.o's .fini section here. */

kernel/arch/i686/crtn.S

@@ -1,4 +1,4 @@
-/* x86 crtn.s */
+/* i686 crtn.s */
 .section .init
 	/* gcc will nicely put the contents of crtend.o's .init section here. */
 	popl %ebp

kernel/arch/i686/interrupts.S

@@ -1,85 +1,107 @@
-.macro push_userspace
+.macro intr_header, n
-	pushw %gs
-	pushw %fs
-	pushw %es
-	pushw %ds
 	pushal
-.endm
+	testb $3, \n+8*4(%esp)
-
+	jz 1f
-.macro load_kernel_segments
 	movw $0x10, %ax
 	movw %ax, %ds
 	movw %ax, %es
 	movw %ax, %fs
-
 	movw $0x28, %ax
 	movw %ax, %gs
+1:	cld
 .endm
 
-.macro pop_userspace
+.macro intr_footer, n
-	popal
+	testb $3, \n+8*4(%esp)
-	popw %ds
+	jz 1f
-	popw %es
+	call cpp_check_signal
-	popw %fs
+	movw $(0x20 | 3), %bx
-	popw %gs
+	movw %bx, %ds
+	movw %bx, %es
+	movw $(0x30 | 3), %bx
+	movw %bx, %fs
+	movw $(0x38 | 3), %bx
+	movw %bx, %gs
+1:	popal
 .endm
 
 isr_stub:
-	push_userspace
+	intr_header 12
-	load_kernel_segments
-
 	movl %cr0, %eax; pushl %eax
 	movl %cr2, %eax; pushl %eax
 	movl %cr3, %eax; pushl %eax
 	movl %cr4, %eax; pushl %eax
 
-	movl %esp,     %eax // register ptr
+	movl 48(%esp), %edi // isr number
-	leal 64(%esp), %ebx // interrupt stack ptr
+	movl 52(%esp), %esi // error code
-	movl 60(%esp), %ecx // error code
+	leal 56(%esp), %edx // interrupt stack ptr
-	movl 56(%esp), %edx // isr number
+	movl %esp,     %ecx // register ptr
+
+	# stack frame for stack trace
+	leal 56(%esp), %eax
+	pushl (%eax)
+	pushl %ebp
+
+	movl %esp, %ebp
+	andl $-16, %esp
 
-	subl $12, %esp
-	pushl %eax
-	pushl %ebx
 	pushl %ecx
 	pushl %edx
+	pushl %esi
+	pushl %edi
 	call cpp_isr_handler
-	addl $44, %esp
 
-	pop_userspace
+	movl %ebp, %esp
+	addl $24, %esp
+
+	intr_footer 12
 	addl $8, %esp
 	iret
 
 irq_stub:
-	push_userspace
+	intr_header 12
-	load_kernel_segments
 
-	movl 40(%esp), %eax # interrupt number
+	movl 32(%esp), %edi # interrupt number
+
+	movl %esp, %ebp
+	andl $-16, %esp
 
 	subl $12, %esp
-	pushl %eax
+	pushl %edi
 	call cpp_irq_handler
-	addl $16, %esp
 
-	pop_userspace
+	movl %ebp, %esp
+
+	intr_footer 12
 	addl $8, %esp
 	iret
 
-.global asm_yield_handler
+.global asm_ipi_handler
-asm_yield_handler:
+asm_ipi_handler:
-	# This can only be called from kernel, so no segment saving is needed
+	intr_header 4
-	pushal
 
-	movl %esp,     %eax # interrupt registers ptr
+	movl %esp, %ebp
-	leal 32(%esp), %ebx # interrupt stack ptr
+	andl $-16, %esp
 
-	subl $4, %esp
+	call cpp_ipi_handler
-	pushl %eax
-	pushl %ebx
-	call cpp_yield_handler
-	addl $12, %esp
 
-	popal
+	movl %ebp, %esp
+
+	intr_footer 4
+	iret
+
+.global asm_timer_handler
+asm_timer_handler:
+	intr_header 4
+
+	movl %esp, %ebp
+	andl $-16, %esp
+
+	call cpp_timer_handler
+
+	movl %ebp, %esp
+
+	intr_footer 4
 	iret
 
 .macro isr n
@@ -138,36 +160,26 @@ isr 29
 isr 30
 isr 31
 
-irq 0
+.irp i,  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, \
-irq 1
+        10, 11, 12, 13, 14, 15, 16, 17, 18, 19, \
-irq 2
+        20, 21, 22, 23, 24, 25, 26, 27, 28, 29, \
-irq 3
+        30, 31, 32, 33, 34, 35, 36, 37, 38, 39, \
-irq 4
+        40, 41, 42, 43, 44, 45, 46, 47, 48, 49, \
-irq 5
+        50, 51, 52, 53, 54, 55, 56, 57, 58, 59, \
-irq 6
+        60, 61, 62, 63, 64, 65, 66, 67, 68, 69, \
-irq 7
+        70, 71, 72, 73, 74, 75, 76, 77, 78, 79, \
-irq 8
+        80, 81, 82, 83, 84, 85, 86, 87, 88, 89, \
-irq 9
+        90, 91, 92, 93, 94, 95, 96, 97, 98, 99, \
-irq 10
+       100,101,102,103,104,105,106,107,108,109, \
-irq 11
+       110,111,112,113,114,115,116,117,118,119, \
-irq 12
+       120,121,122,123,124,125,126,127,128,129, \
-irq 13
+       130,131,132,133,134,135,136,137,138,139, \
-irq 14
+       140,141,142,143,144,145,146,147,148,149, \
-irq 15
+       150,151,152,153,154,155,156,157,158,159, \
-irq 16
+       160,161,162,163,164,165,166,167,168,169, \
-irq 17
+       170,171,172,173,174,175,176,177,178,179, \
-irq 18
+       180,181,182,183,184,185,186,187,188,189, \
-irq 19
+       190,191,192,193,194,195,196,197,198,199, \
-irq 20
+       200,201,202,203,204,205,206,207
-irq 21
+	irq \i
-irq 22
+.endr
-irq 23
-irq 24
-irq 25
-irq 26
-irq 27
-irq 28
-irq 29
-irq 30
-irq 31
-irq 32

kernel/arch/i686/linker.ld

@@ -4,13 +4,6 @@ KERNEL_OFFSET = 0xC0000000;
 
 SECTIONS
 {
-	. = 0xF000;
-	.ap_init ALIGN(4K) : AT(ADDR(.ap_init))
-	{
-		g_ap_init_addr = .;
-		*(.ap_init)
-	}
-
 	. = 0x00100000 + KERNEL_OFFSET;
 
 	g_kernel_start = .;
@@ -18,6 +11,7 @@ SECTIONS
 	{
 		g_kernel_execute_start = .;
 		*(.multiboot)
+		*(.multiboot2)
 		*(.bananboot)
 		*(.text.*)
 	}
@@ -28,18 +22,31 @@ SECTIONS
 		g_userspace_end = .;
 		g_kernel_execute_end = .;
 	}
+	.ap_init ALIGN(4K) : AT(ADDR(.ap_init) - KERNEL_OFFSET)
+	{
+		g_ap_init_addr = .;
+		*(.ap_init)
+	}
 	.rodata ALIGN(4K) : AT(ADDR(.rodata) - KERNEL_OFFSET)
 	{
 		*(.rodata.*)
 	}
+	.init_array ALIGN(4K) : AT(ADDR(.init_array) - KERNEL_OFFSET)
+	{
+		g_init_array_start = .;
+		*(.init_array)
+		g_init_array_end = .;
+	}
 	.data ALIGN(4K) : AT(ADDR(.data) - KERNEL_OFFSET)
 	{
+		g_kernel_writable_start = .;
 		*(.data)
 	}
 	.bss ALIGN(4K) : AT(ADDR(.bss) - KERNEL_OFFSET)
 	{
 		*(COMMON)
 		*(.bss)
+		g_kernel_writable_end = .;
 	}
 	g_kernel_end = .;
 }

kernel/arch/x86_64/Signal.S

@@ -1,57 +1,97 @@
-.section .userspace, "aw"
+.section .userspace, "ax"
 
 // stack contains
-//    return address
+//    (8 bytes)  return address (on return stack)
-//    signal number
+//    (8 bytes)  return stack
-//    signal handler
+//    (8 bytes)  return rflags
+//    (8 bytes)  restore sigmask
+//    (56 bytes) siginfo_t
+//    (8 bytes)  signal number
+//    (8 bytes)  signal handler
 
 .global signal_trampoline
 signal_trampoline:
-	pushq %rax
+	pushq %r15 // gregs
-	pushq %rbx
-	pushq %rcx
-	pushq %rdx
-	pushq %rbp
-	pushq %rdi
-	pushq %rsi
-	pushq %r8
-	pushq %r9
-	pushq %r10
-	pushq %r11
-	pushq %r12
-	pushq %r13
 	pushq %r14
-	pushq %r15
+	pushq %r13
+	pushq %r12
+	pushq %r11
+	pushq %r10
+	pushq %r9
+	pushq %r8
+	pushq %rsi
+	pushq %rdi
+	pushq %rdx
+	pushq %rcx
+	pushq %rbx
+	pushq %rax
+	pushq %rbp
 
-	movq 128(%rsp), %rdi
+	movq 208(%rsp), %rax
-	movq 120(%rsp), %rax
+	pushq %rax; addq $(128 + 8), (%rsp)
+	pushq (%rax)
+
+	// FIXME: populate these
+	xorq %rax, %rax
+	pushq %rax // stack
+	pushq %rax
+	pushq %rax
+	pushq %rax // sigset
+	pushq %rax // link
+
+	movq  %rsp,     %rdx // ucontext
+	leaq 192(%rsp), %rsi // siginfo
+	movq 184(%rsp), %rdi // signal number
+	movq 176(%rsp), %rax // handler
 
 	// align stack to 16 bytes
-	movq %rsp, %rbx
+	movq %rsp, %rbp
-	andq $0x0F, %rbx
+	andq $-16, %rsp
-	subq %rbx, %rsp
+
+	subq $512, %rsp
+	fxsave64 (%rsp)
 
 	call *%rax
 
-	// restore stack
+	fxrstor64 (%rsp)
-	addq %rbx, %rsp
+	addq $512, %rsp
-	popq %r15
-	popq %r14
-	popq %r13
-	popq %r12
-	popq %r11
-	popq %r10
-	popq %r9
-	popq %r8
-	popq %rsi
-	popq %rdi
-	popq %rbp
-	popq %rdx
-	popq %rcx
-	popq %rbx
-	popq %rax
 
+	// restore stack
+	movq %rbp, %rsp
+	addq $40, %rsp
+
+	// restore sigmask
+	movq $83, %rdi       // SYS_SIGPROCMASK
+	movq $3,  %rsi       // SIG_SETMASK
+	leaq 192(%rsp), %rdx // set
+	xorq %r10, %r10      // oset
+	syscall
+
+	// restore registers
 	addq $16, %rsp
+	popq %rbp
+	popq %rax
+	popq %rbx
+	popq %rcx
+	popq %rdx
+	popq %rdi
+	popq %rsi
+	popq %r8
+	popq %r9
+	popq %r10
+	popq %r11
+	popq %r12
+	popq %r13
+	popq %r14
+	popq %r15
+
+	// skip handler, number, siginfo_t, sigmask
+	addq $80, %rsp
+
+	// restore flags
+	popfq
+
+	movq (%rsp), %rsp
 
 	// return over red-zone
 	ret $128

kernel/arch/x86_64/Syscall.S

@@ -1,48 +1,26 @@
-// arguments in RAX, RBX, RCX, RDX, RSI, RDI
-// System V ABI: RDI, RSI, RDX, RCX, R8, R9
 .global asm_syscall_handler
 asm_syscall_handler:
-	pushq %rbx
+	swapgs
-	pushq %rcx
+
-	pushq %rdx
+	movq %rsp, %rax
-	pushq %rdi
+	movq %gs:8, %rsp
-	pushq %rsi
+
-	pushq %rbp
+	pushq $(0x20 | 3)
-	pushq %r8
+	pushq %rax
-	pushq %r9
-	pushq %r10
 	pushq %r11
-	pushq %r12
+	pushq $(0x28 | 3)
-	pushq %r13
+	pushq %rcx
-	pushq %r14
+	subq $8, %rsp
-	pushq %r15
 
-	movq %rsi, %r8
+	movq %r10, %rcx
-	movq %rdi, %r9
-	movq %rax, %rdi
-	movq %rbx, %rsi
-	xchgq %rcx, %rdx
-	leaq 112(%rsp), %rbx
-	pushq %rbx
 	call cpp_syscall_handler
-	addq $8, %rsp
 
-	popq %r15
+	movq  8(%rsp), %rcx
-	popq %r14
+	movq 24(%rsp), %r11
-	popq %r13
+	movq 32(%rsp), %rsp
-	popq %r12
-	popq %r11
-	popq %r10
-	popq %r9
-	popq %r8
-	popq %rbp
-	popq %rsi
-	popq %rdi
-	popq %rdx
-	popq %rcx
-	popq %rbx
-	iretq
 
+	swapgs
+	sysretq
 
 .global sys_fork_trampoline
 sys_fork_trampoline:
@@ -55,7 +33,7 @@ sys_fork_trampoline:
 
 	call read_ip
 	testq %rax, %rax
-	je .reload_stack
+	jz .done
 
 	movq %rax, %rsi
 	movq %rsp, %rdi
@@ -69,9 +47,3 @@ sys_fork_trampoline:
 	popq %rbp
 	popq %rbx
 	ret
-
- .reload_stack:
-	call get_thread_start_sp
-	movq %rax, %rsp
-	xorq %rax, %rax
-	jmp .done

kernel/arch/x86_64/Thread.S

@@ -7,9 +7,6 @@ read_ip:
 # void start_kernel_thread()
 .global start_kernel_thread
 start_kernel_thread:
-	call get_thread_start_sp
-	movq %rax, %rsp
-
 	# STACK LAYOUT
 	#   on_exit arg
 	#   on_exit func
@@ -27,26 +24,5 @@ start_kernel_thread:
 
 .global start_userspace_thread
 start_userspace_thread:
-	call get_thread_start_sp
+	swapgs
-	movq %rax, %rsp
-
-	# STACK LAYOUT
-	#   entry
-	#   argc
-	#   argv
-	#   envp
-	#   userspace stack
-
-	call get_userspace_thread_stack_top
-
-	popq %rdx
-	popq %rsi
-	popq %rdi
-	popq %rcx
-
-	pushq $(0x20 | 3)
-	pushq %rax
-	pushq $0x202
-	pushq $(0x18 | 3)
-	pushq %rcx
 	iretq

kernel/arch/x86_64/User.S

@@ -0,0 +1,87 @@
+# bool safe_user_memcpy(void*, const void*, size_t)
+.global safe_user_memcpy
+.global safe_user_memcpy_end
+.global safe_user_memcpy_fault
+safe_user_memcpy:
+	xorq %rax, %rax
+	movq %rdx, %rcx
+	rep movsb
+	incq %rax
+safe_user_memcpy_fault:
+	ret
+safe_user_memcpy_end:
+
+# bool safe_user_strncpy(void*, const void*, size_t)
+.global safe_user_strncpy
+.global safe_user_strncpy_end
+.global safe_user_strncpy_fault
+safe_user_strncpy:
+	movq %rdx, %rcx
+	testq %rcx, %rcx
+	jz safe_user_strncpy_fault
+
+ .safe_user_strncpy_align_loop:
+	testb $0x7, %sil
+	jz .safe_user_strncpy_align_done
+
+	movb (%rsi), %al
+	movb %al, (%rdi)
+	testb %al, %al
+	jz .safe_user_strncpy_done
+
+	incq %rdi
+	incq %rsi
+	decq %rcx
+	jnz .safe_user_strncpy_align_loop
+	jmp safe_user_strncpy_fault
+
+ .safe_user_strncpy_align_done:
+	movq $0x0101010101010101, %r8
+	movq $0x8080808080808080, %r9
+
+ .safe_user_strncpy_qword_loop:
+	cmpq $8, %rcx
+	jb .safe_user_strncpy_qword_done
+
+	movq (%rsi), %rax
+	movq %rax, %r10
+	movq %rax, %r11
+
+	# https://graphics.stanford.edu/~seander/bithacks.html#ZeroInWord
+	subq %r8, %r10
+	notq %r11
+	andq %r11, %r10
+	andq %r9, %r10
+	jnz .safe_user_strncpy_byte_loop
+
+	movq %rax, (%rdi)
+
+	addq $8, %rdi
+	addq $8, %rsi
+	subq $8, %rcx
+	jnz .safe_user_strncpy_qword_loop
+	jmp safe_user_strncpy_fault
+
+ .safe_user_strncpy_qword_done:
+	testq %rcx, %rcx
+	jz safe_user_strncpy_fault
+
+ .safe_user_strncpy_byte_loop:
+	movb (%rsi), %al
+	movb %al, (%rdi)
+	testb %al, %al
+	jz .safe_user_strncpy_done
+
+	incq %rdi
+	incq %rsi
+	decq %rcx
+	jnz .safe_user_strncpy_byte_loop
+
+ safe_user_strncpy_fault:
+	xorq %rax, %rax
+	ret
+
+ .safe_user_strncpy_done:
+	movb $1, %al
+	ret
+safe_user_strncpy_end:

kernel/arch/x86_64/Yield.S

@@ -0,0 +1,29 @@
+.global asm_yield_trampoline
+asm_yield_trampoline:
+	leaq 8(%rsp), %rcx
+	movq %rdi, %rsp
+
+	subq $8, %rsp
+	pushq -8(%rcx)
+	pushq %rcx
+	pushq %rax
+	pushq %rbx
+	pushq %rbp
+	pushq %r12
+	pushq %r13
+	pushq %r14
+	pushq %r15
+
+	movq %rsp, %rdi
+	call scheduler_on_yield
+
+	popq %r15
+	popq %r14
+	popq %r13
+	popq %r12
+	popq %rbp
+	popq %rbx
+	popq %rax
+	movq 8(%rsp), %rcx
+	movq 0(%rsp), %rsp
+	jmp *%rcx

kernel/arch/x86_64/boot.S

@@ -11,9 +11,28 @@
 
 .code32
 
-# multiboot2 header
+// custom addresses, video mode info, page align modules
+.set multiboot_flags, (1 << 16) | (1 << 2) | (1 << 0)
+
 .section .multiboot, "aw"
-	.align 8
+multiboot_start:
+	.long 0x1BADB002
+	.long multiboot_flags
+	.long -(0x1BADB002 + multiboot_flags)
+
+	.long V2P(multiboot_start)
+	.long V2P(g_kernel_start)
+	.long V2P(g_kernel_bss_start)
+	.long V2P(g_kernel_end)
+	.long V2P(_start)
+
+	.long 0
+	.long FB_WIDTH
+	.long FB_HEIGHT
+	.long FB_BPP
+multiboot_end:
+
+.section .multiboot2, "aw"
 multiboot2_start:
 	.long 0xE85250D6
 	.long 0
@@ -36,6 +55,12 @@ multiboot2_start:
 	.long 12
 	.long V2P(_start)
 
+	# page align modules
+	.align 8
+	.short 6
+	.short 0
+	.long 8
+
 	.align 8
 	.short 0
 	.short 0
@@ -43,7 +68,6 @@ multiboot2_start:
 multiboot2_end:
 
 .section .bananboot, "aw"
-	.align 8
 bananboot_start:
 	.long 0xBABAB007
 	.long -(0xBABAB007 + FB_WIDTH + FB_HEIGHT + FB_BPP)
@@ -53,9 +77,10 @@ bananboot_start:
 bananboot_end:
 
 .section .bss, "aw", @nobits
-	boot_stack_bottom:
+    .global g_boot_stack_top
-		.skip 4096 * 64
+	g_boot_stack_bottom:
-	boot_stack_top:
+		.skip 4096 * 4
+	g_boot_stack_top:
 
 	.global g_kernel_cmdline
 	g_kernel_cmdline:
@@ -108,9 +133,6 @@ g_ap_startup_done:
 .global g_ap_running_count
 g_ap_running_count:
 	.byte 0
-.global g_ap_stack_loaded
-g_ap_stack_loaded:
-	.byte 0
 
 .section .text
 
@@ -158,6 +180,13 @@ enable_sse:
 	movl %eax, %cr4
 	ret
 
+enable_tsc:
+	# allow userspace to use RDTSC
+	movl %cr4, %ecx
+	andl $0xFFFFFFFB, %ecx
+	movl %ecx, %cr4
+	ret
+
 initialize_paging:
 	# enable PAE
 	movl %cr4, %ecx
@@ -190,11 +219,11 @@ _start:
 	movl %eax, V2P(bootloader_magic)
 	movl %ebx, V2P(bootloader_info)
 
-	movl $V2P(boot_stack_top), %esp
+	movl $V2P(g_boot_stack_top), %esp
 
 	call check_requirements
 	call enable_sse
-
+	call enable_tsc
 	call initialize_paging
 
 	# flush gdt and jump to 64 bit
@@ -220,6 +249,13 @@ higher_half:
 	# call global constuctors
 	call _init
 
+	movq $g_init_array_start, %rbx
+	jmp 2f
+ 1: call *(%rbx)
+	addq $8, %rbx
+ 2: cmpq $g_init_array_end, %rbx
+	jne 1b
+
 	# call to the kernel itself (clear rbp for stacktrace)
 	xorq %rbp, %rbp
 
@@ -237,26 +273,31 @@ system_halt:
 	jmp 1b
 
 
+#define AP_V2P(vaddr) ((vaddr) - ap_trampoline + 0xF000)
+
 .section .ap_init, "ax"
 
 .code16
 .global ap_trampoline
 ap_trampoline:
 	jmp 1f
+
 .align 8
 ap_stack_ptr:
 	.skip 4
-1:
+ap_stack_loaded:
-	cli; cld
+	.skip 1
-	ljmpl $0x00, $ap_cs_clear
-ap_cs_clear:
 
+1:	cli; cld
+	ljmpl $0x00, $AP_V2P(ap_cs_clear)
+
+ap_cs_clear:
 	# load ap gdt and enter protected mode
-	lgdt ap_gdtr
+	lgdt AP_V2P(ap_gdtr)
 	movl %cr0, %eax
 	orb $1, %al
 	movl %eax, %cr0
-	ljmpl $0x08, $ap_protected_mode
+	ljmpl $0x08, $AP_V2P(ap_protected_mode)
 
 .code32
 ap_protected_mode:
@@ -265,16 +306,16 @@ ap_protected_mode:
 	movw %ax, %ss
 	movw %ax, %es
 
-	movl ap_stack_ptr, %esp
+	movl AP_V2P(ap_stack_ptr), %esp
-	movb $1, V2P(g_ap_stack_loaded)
+	movb $1, AP_V2P(ap_stack_loaded)
 
-	call V2P(enable_sse)
+	leal V2P(enable_sse),        %ecx; call *%ecx
-
+	leal V2P(enable_tsc),        %ecx; call *%ecx
-	call V2P(initialize_paging)
+	leal V2P(initialize_paging), %ecx; call *%ecx
 
 	# load boot gdt and enter long mode
 	lgdt V2P(boot_gdtr)
-	ljmpl $0x08, $ap_long_mode
+	ljmpl $0x08, $AP_V2P(ap_long_mode)
 
 .code64
 ap_long_mode:
@@ -282,22 +323,20 @@ ap_long_mode:
 	movl %esp, %esp
 	addq $KERNEL_OFFSET, %rsp
 
-	# jump to higher half
-	movabsq $ap_higher_half, %rcx
-	jmp *%rcx
-
-ap_higher_half:
 	# clear rbp for stacktrace
 	xorq %rbp, %rbp
 
+	xorb %al, %al
 1:	pause
-	cmpb $0, g_ap_startup_done
+	cmpb %al, g_ap_startup_done
 	jz 1b
 
 	lock incb g_ap_running_count
 
-	call ap_main
+	# jump to ap_main in higher half
-	jmp system_halt
+	movabsq $ap_main, %rcx
+	call *%rcx
+	jmp V2P(system_halt)
 
 ap_gdt:
 	.quad 0x0000000000000000 # null descriptor

kernel/arch/x86_64/interrupts.S

@@ -1,4 +1,4 @@
-.macro pushaq
+.macro intr_header, n
 	pushq %rax
 	pushq %rcx
 	pushq %rdx
@@ -14,10 +14,18 @@
 	pushq %r13
 	pushq %r14
 	pushq %r15
+	testb $3, \n+15*8(%rsp)
+	jz 1f
+	swapgs
+1:	cld
 .endm
 
-.macro popaq
+.macro intr_footer, n
-	popq %r15
+	testb $3, \n+15*8(%rsp)
+	jz 1f
+	call cpp_check_signal
+	swapgs
+1:	popq %r15
 	popq %r14
 	popq %r13
 	popq %r12
@@ -35,8 +43,7 @@
 .endm
 
 isr_stub:
-	pushaq
+	intr_header 24
-
 	movq %cr0, %rax; pushq %rax
 	movq %cr2, %rax; pushq %rax
 	movq %cr3, %rax; pushq %rax
@@ -49,25 +56,33 @@ isr_stub:
 	call cpp_isr_handler
 	addq $32, %rsp
 
-	popaq
+	intr_footer 24
 	addq $16, %rsp
 	iretq
 
 irq_stub:
-	pushaq
+	intr_header 24
+	xorq %rbp, %rbp
 	movq 120(%rsp), %rdi	# irq number
 	call cpp_irq_handler
-	popaq
+	intr_footer 24
 	addq $16, %rsp
 	iretq
 
-.global asm_yield_handler
+.global asm_ipi_handler
-asm_yield_handler:
+asm_ipi_handler:
-	pushaq
+	intr_header 8
-	leaq 120(%rsp), %rdi # interrupt stack ptr
+	xorq %rbp, %rbp
-	movq     %rsp,  %rsi # interrupt register ptr
+	call cpp_ipi_handler
-	call cpp_yield_handler
+	intr_footer 8
-	popaq
+	iretq
+
+.global asm_timer_handler
+asm_timer_handler:
+	intr_header 8
+	xorq %rbp, %rbp
+	call cpp_timer_handler
+	intr_footer 8
 	iretq
 
 .macro isr n
@@ -126,36 +141,26 @@ isr 29
 isr 30
 isr 31
 
-irq 0
+.irp i,  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, \
-irq 1
+        10, 11, 12, 13, 14, 15, 16, 17, 18, 19, \
-irq 2
+        20, 21, 22, 23, 24, 25, 26, 27, 28, 29, \
-irq 3
+        30, 31, 32, 33, 34, 35, 36, 37, 38, 39, \
-irq 4
+        40, 41, 42, 43, 44, 45, 46, 47, 48, 49, \
-irq 5
+        50, 51, 52, 53, 54, 55, 56, 57, 58, 59, \
-irq 6
+        60, 61, 62, 63, 64, 65, 66, 67, 68, 69, \
-irq 7
+        70, 71, 72, 73, 74, 75, 76, 77, 78, 79, \
-irq 8
+        80, 81, 82, 83, 84, 85, 86, 87, 88, 89, \
-irq 9
+        90, 91, 92, 93, 94, 95, 96, 97, 98, 99, \
-irq 10
+       100,101,102,103,104,105,106,107,108,109, \
-irq 11
+       110,111,112,113,114,115,116,117,118,119, \
-irq 12
+       120,121,122,123,124,125,126,127,128,129, \
-irq 13
+       130,131,132,133,134,135,136,137,138,139, \
-irq 14
+       140,141,142,143,144,145,146,147,148,149, \
-irq 15
+       150,151,152,153,154,155,156,157,158,159, \
-irq 16
+       160,161,162,163,164,165,166,167,168,169, \
-irq 17
+       170,171,172,173,174,175,176,177,178,179, \
-irq 18
+       180,181,182,183,184,185,186,187,188,189, \
-irq 19
+       190,191,192,193,194,195,196,197,198,199, \
-irq 20
+       200,201,202,203,204,205,206,207
-irq 21
+	irq \i
-irq 22
+.endr
-irq 23
-irq 24
-irq 25
-irq 26
-irq 27
-irq 28
-irq 29
-irq 30
-irq 31
-irq 32

kernel/arch/x86_64/linker.ld

@@ -4,13 +4,6 @@ KERNEL_OFFSET = 0xFFFFFFFF80000000;
 
 SECTIONS
 {
-	. = 0xF000;
-	.ap_init ALIGN(4K) : AT(ADDR(.ap_init))
-	{
-		g_ap_init_addr = .;
-		*(.ap_init)
-	}
-
 	. = 0x00100000 + KERNEL_OFFSET;
 
 	g_kernel_start = .;
@@ -18,6 +11,7 @@ SECTIONS
 	{
 		g_kernel_execute_start = .;
 		*(.multiboot)
+		*(.multiboot2)
 		*(.bananboot)
 		*(.text.*)
 	}
@@ -28,18 +22,32 @@ SECTIONS
 		g_userspace_end = .;
 		g_kernel_execute_end = .;
 	}
+	.ap_init ALIGN(4K) : AT(ADDR(.ap_init) - KERNEL_OFFSET)
+	{
+		g_ap_init_addr = .;
+		*(.ap_init)
+	}
 	.rodata ALIGN(4K) : AT(ADDR(.rodata) - KERNEL_OFFSET)
 	{
 		*(.rodata.*)
 	}
+	.init_array ALIGN(4K) : AT(ADDR(.init_array) - KERNEL_OFFSET)
+	{
+		g_init_array_start = .;
+		*(.init_array)
+		g_init_array_end = .;
+	}
 	.data ALIGN(4K) : AT(ADDR(.data) - KERNEL_OFFSET)
 	{
+		g_kernel_writable_start = .;
 		*(.data)
 	}
 	.bss ALIGN(4K) : AT(ADDR(.bss) - KERNEL_OFFSET)
 	{
+		g_kernel_bss_start = .;
 		*(COMMON)
 		*(.bss)
+		g_kernel_writable_end = .;
 	}
 	g_kernel_end = .;
 }

kernel/icxxabi.cpp

@@ -42,20 +42,20 @@ namespace __cxxabiv1
 {
 	using __guard = uint64_t;
 
-	int __cxa_guard_acquire (__guard* g)
+	extern "C" int __cxa_guard_acquire (__guard* g)
 	{
 		uint8_t* byte = reinterpret_cast<uint8_t*>(g);
 		uint8_t zero = 0;
 		return __atomic_compare_exchange_n(byte, &zero, 1, false, __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE);
 	}
 
-	void __cxa_guard_release (__guard* g)
+	extern "C" void __cxa_guard_release (__guard* g)
 	{
 		uint8_t* byte = reinterpret_cast<uint8_t*>(g);
 		__atomic_store_n(byte, 0, __ATOMIC_RELEASE);
 	}
 
-	void __cxa_guard_abort (__guard*)
+	extern "C" void __cxa_guard_abort (__guard*)
 	{
 		Kernel::panic("__cxa_guard_abort");
 	}

kernel/include/kernel/ACPI/ACPI.h

@@ -1,10 +1,11 @@
 #pragma once
 
 #include <BAN/Vector.h>
-#include <kernel/ACPI/AML/Method.h>
 #include <kernel/ACPI/AML/Namespace.h>
+#include <kernel/ACPI/EmbeddedController.h>
 #include <kernel/ACPI/Headers.h>
 #include <kernel/Memory/Types.h>
+#include <kernel/ThreadBlocker.h>
 
 namespace Kernel::ACPI
 {
@@ -28,25 +29,38 @@ namespace Kernel::ACPI
 		//   2: SAPIC
 		BAN::ErrorOr<void> enter_acpi_mode(uint8_t mode);
 
-		// This function will power off the system
+		BAN::ErrorOr<void> initialize_acpi_devices();
-		// This function will return only if there was an error
-		void poweroff();
 
-		// This function will reset the system
+		AML::Namespace* acpi_namespace() { return m_namespace; }
-		// This function will return only if there was an error
+
-		void reset();
+		BAN::ErrorOr<void> poweroff();
+		BAN::ErrorOr<void> reset();
+
+		BAN::ErrorOr<void> register_gpe_handler(uint8_t gpe, void (*callback)(void*), void* argument);
 
 		void handle_irq() override;
 
+		BAN::Span<BAN::UniqPtr<EmbeddedController>> embedded_controllers() { return m_embedded_controllers.span(); }
+
 	private:
 		ACPI() = default;
 		BAN::ErrorOr<void> initialize_impl();
 
 		FADT& fadt() { return *m_fadt; }
 
-		bool prepare_sleep(uint8_t sleep_state);
+		BAN::ErrorOr<void> prepare_sleep(uint8_t sleep_state);
 		void acpi_event_task();
 
+		BAN::ErrorOr<void> load_aml_tables(BAN::StringView name, bool all);
+
+		BAN::ErrorOr<void> route_interrupt_link_device(const AML::Scope& device, uint64_t& routed_irq_mask);
+
+		BAN::ErrorOr<void> initialize_embedded_controller(const AML::Scope& embedded_controller);
+		BAN::ErrorOr<void> initialize_embedded_controllers();
+
+		BAN::Optional<GAS> find_gpe_block(size_t index);
+		bool enable_gpe(uint8_t gpe);
+
 	private:
 		paddr_t m_header_table_paddr = 0;
 		vaddr_t m_header_table_vaddr = 0;
@@ -63,11 +77,28 @@ namespace Kernel::ACPI
 
 		FADT* m_fadt { nullptr };
 
-		Semaphore m_event_semaphore;
+		ThreadBlocker m_event_thread_blocker;
-		BAN::Array<BAN::RefPtr<AML::Method>, 0xFF> m_gpe_methods;
+
+		BAN::Vector<BAN::UniqPtr<EmbeddedController>> m_embedded_controllers;
+
+		struct GPEHandler
+		{
+			bool has_callback { false };
+			union {
+				AML::Reference* method;
+				struct
+				{
+					void (*callback)(void*);
+					void* argument;
+				};
+			};
+		};
+		bool m_has_any_gpes { false };
+		AML::Scope m_gpe_scope;
+		BAN::Array<GPEHandler, 0xFF> m_gpe_methods;
 
 		bool m_hardware_reduced { false };
-		BAN::RefPtr<AML::Namespace> m_namespace;
+		AML::Namespace* m_namespace { nullptr };
 	};
 
 }

kernel/include/kernel/ACPI/AML.h

@@ -1,11 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/Headers.h>
-#include <kernel/ACPI/AML/Namespace.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	BAN::RefPtr<AML::Namespace> initialize_namespace();
-
-}

kernel/include/kernel/ACPI/AML/Buffer.h

@@ -1,212 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Integer.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Buffer : public AML::Node
-	{
-		BAN::Vector<uint8_t> buffer;
-
-		Buffer()
-			: AML::Node(Node::Type::Buffer)
-		{}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			return this;
-		}
-
-		static ParseResult parse(AML::ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::BufferOp);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto buffer_pkg = AML::parse_pkg(context.aml_data);
-			if (!buffer_pkg.has_value())
-				return ParseResult::Failure;
-
-			auto buffer_context = context;
-			buffer_context.aml_data = buffer_pkg.value();
-
-			auto buffer_size_object = AML::parse_object(buffer_context);
-			if (!buffer_size_object.success())
-				return ParseResult::Failure;
-
-			auto buffer_size = buffer_size_object.node()->as_integer();
-			if (!buffer_size.has_value())
-				return ParseResult::Failure;
-
-			uint32_t actual_buffer_size = BAN::Math::max<uint32_t>(buffer_size.value(), buffer_context.aml_data.size());
-
-			auto buffer = MUST(BAN::RefPtr<Buffer>::create());
-			MUST(buffer->buffer.resize(actual_buffer_size, 0));
-			for (uint32_t i = 0; i < buffer_context.aml_data.size(); i++)
-					buffer->buffer[i] = buffer_context.aml_data[i];
-
-#if AML_DEBUG_LEVEL >= 2
-			buffer->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return ParseResult(buffer);
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("Buffer ({} bytes)", buffer.size());
-		}
-	};
-
-	struct BufferField : AML::NamedObject
-	{
-		BAN::RefPtr<Buffer> buffer;
-		size_t field_bit_offset;
-		size_t field_bit_size;
-
-		BufferField(AML::NameSeg name, BAN::RefPtr<Buffer> buffer, size_t field_bit_offset, size_t field_bit_size)
-			: AML::NamedObject(Node::Type::BufferField, name)
-			, buffer(buffer)
-			, field_bit_offset(field_bit_offset)
-			, field_bit_size(field_bit_size)
-		{}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			ASSERT(buffer);
-			ASSERT(field_bit_offset + field_bit_size <= buffer->buffer.size() * 8);
-
-			uint64_t value = 0;
-
-			const size_t byte_offset = field_bit_offset / 8;
-			const size_t bit_offset = field_bit_offset % 8;
-			if (field_bit_size == 1)
-			{
-				value = (buffer->buffer[byte_offset] >> bit_offset) & 1;
-			}
-			else
-			{
-				ASSERT(bit_offset == 0);
-				for (size_t byte = 0; byte < field_bit_size / 8; byte++)
-					value |= buffer->buffer[byte_offset + byte] << byte;
-			}
-
-			return MUST(BAN::RefPtr<AML::Integer>::create(value));
-		}
-
-		bool store(BAN::RefPtr<AML::Node> node) override
-		{
-			ASSERT(buffer);
-			ASSERT(field_bit_offset + field_bit_size <= buffer->buffer.size() * 8);
-
-			auto value = node->as_integer();
-			if (!value.has_value())
-				return false;
-
-			const size_t byte_offset = field_bit_offset / 8;
-			const size_t bit_offset = field_bit_offset % 8;
-			if (field_bit_size == 1)
-			{
-				buffer->buffer[byte_offset] &= ~(1 << bit_offset);
-				buffer->buffer[byte_offset] |= (value.value() & 1) << bit_offset;
-			}
-			else
-			{
-				ASSERT(bit_offset == 0);
-				for (size_t byte = 0; byte < field_bit_size / 8; byte++)
-					buffer->buffer[byte_offset + byte] = (value.value() >> (byte * 8)) & 0xFF;
-			}
-
-			return true;
-		}
-
-		static ParseResult parse(AML::ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-
-			size_t field_bit_size = 0;
-			switch (static_cast<Byte>(context.aml_data[0]))
-			{
-				case AML::Byte::CreateBitFieldOp:
-					field_bit_size = 1;
-					break;
-				case AML::Byte::CreateByteFieldOp:
-					field_bit_size = 8;
-					break;
-				case AML::Byte::CreateWordFieldOp:
-					field_bit_size = 16;
-					break;
-				case AML::Byte::CreateDWordFieldOp:
-					field_bit_size = 32;
-					break;
-				case AML::Byte::CreateQWordFieldOp:
-					field_bit_size = 64;
-					break;
-				default:
-					ASSERT_NOT_REACHED();
-			}
-			context.aml_data = context.aml_data.slice(1);
-
-			auto buffer_result = AML::parse_object(context);
-			if (!buffer_result.success())
-				return ParseResult::Failure;
-			auto buffer_node = buffer_result.node() ? buffer_result.node()->evaluate() : nullptr;
-			if (!buffer_node || buffer_node->type != Node::Type::Buffer)
-			{
-				AML_ERROR("Buffer source does not evaluate to a Buffer");
-				return ParseResult::Failure;
-			}
-			auto buffer = static_cast<Buffer*>(buffer_node.ptr());
-
-			auto index_result = AML::parse_object(context);
-			if (!index_result.success())
-				return ParseResult::Failure;
-			auto index = index_result.node() ? index_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!index.has_value())
-			{
-				AML_ERROR("Failed to parse index for BufferField");
-				return ParseResult::Failure;
-			}
-			size_t field_bit_offset = index.value();
-			if (field_bit_size != 1)
-				field_bit_offset *= 8;
-
-			auto field_name = AML::NameString::parse(context.aml_data);
-			if (!field_name.has_value())
-				return ParseResult::Failure;
-			if (field_name->path.empty())
-			{
-				AML_ERROR("Empty field name for BufferField");
-				return ParseResult::Failure;
-			}
-
-			auto field = MUST(BAN::RefPtr<BufferField>::create(field_name->path.back(), buffer, field_bit_offset, field_bit_size));
-			if (!Namespace::root_namespace()->add_named_object(context, field_name.value(), field))
-				return ParseResult::Failure;
-
-#if AML_DEBUG_LEVEL >= 2
-			field->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return ParseResult::Success;
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("BufferField {} at bit offset {} ({} bits) to { ", name, field_bit_offset, field_bit_size);
-			buffer->debug_print(0);
-			AML_DEBUG_PRINT(" }");
-		}
-
-	};
-
-}

kernel/include/kernel/ACPI/AML/Bytes.h

@@ -145,19 +145,35 @@ namespace Kernel::ACPI::AML
 		DataRegionOp = 0x88,
 	};
 
-	static constexpr bool is_digit_char(uint8_t ch)
+	inline constexpr bool is_digit_char(uint8_t ch)
 	{
 		return '0' <= ch && ch <= '9';
 	}
 
-	static constexpr bool is_lead_name_char(uint8_t ch)
+	inline constexpr bool is_lead_name_char(uint8_t ch)
 	{
 		return ('A' <= ch && ch <= 'Z') || ch == '_';
 	}
 
-	static constexpr bool is_name_char(uint8_t ch)
+	inline constexpr bool is_name_char(uint8_t ch)
 	{
 		return is_lead_name_char(ch) || is_digit_char(ch);
 	}
 
+	inline constexpr bool is_name_string_start(uint8_t ch)
+	{
+		if (is_lead_name_char(ch))
+			return true;
+		switch (static_cast<AML::Byte>(ch))
+		{
+			case AML::Byte::RootChar:
+			case AML::Byte::ParentPrefixChar:
+			case AML::Byte::MultiNamePrefix:
+			case AML::Byte::DualNamePrefix:
+				return true;
+			default:
+				return false;
+		}
+	}
+
 }

kernel/include/kernel/ACPI/AML/Device.h

@@ -1,57 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Method.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-#include <kernel/ACPI/AML/Scope.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Device : public AML::Scope
-	{
-		Device(NameSeg name)
-			: Scope(Node::Type::Device, name)
-		{}
-
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::DeviceOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto device_pkg = AML::parse_pkg(context.aml_data);
-			if (!device_pkg.has_value())
-				return ParseResult::Failure;
-
-			auto name_string = AML::NameString::parse(device_pkg.value());
-			if (!name_string.has_value())
-				return ParseResult::Failure;
-
-			auto device = MUST(BAN::RefPtr<Device>::create(name_string->path.back()));
-			if (!Namespace::root_namespace()->add_named_object(context, name_string.value(), device))
-				return ParseResult::Failure;
-
-			return device->enter_context_and_parse_term_list(context, name_string.value(), device_pkg.value());
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("Device ");
-			name.debug_print();
-			AML_DEBUG_PRINTLN(" {");
-			Namespace::root_namespace()->for_each_child(scope,
-				[&](const auto&, const auto& child)
-				{
-					child->debug_print(indent + 1);
-					AML_DEBUG_PRINTLN("");
-				}
-			);
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("}");
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Expression.h

@@ -1,216 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Integer.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Expression
-	{
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			switch (static_cast<Byte>(context.aml_data[0]))
-			{
-				// unary
-				case AML::Byte::IncrementOp:
-				case AML::Byte::DecrementOp:
-				{
-					auto opcode = (static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::IncrementOp) ? AML::Byte::AddOp : AML::Byte::SubtractOp;
-					context.aml_data = context.aml_data.slice(1);
-
-					auto source_result = AML::parse_object(context);
-					if (!source_result.success())
-						return ParseResult::Failure;
-					auto source_node = source_result.node() ? source_result.node()->evaluate() : BAN::RefPtr<AML::Node>();
-					if (!source_node || source_node->type != AML::Node::Type::Integer)
-					{
-						AML_ERROR("UnaryOp source not integer");
-						return ParseResult::Failure;
-					}
-
-					auto source_integer = static_cast<AML::Integer*>(source_node.ptr());
-					if (source_integer->constant)
-					{
-						AML_ERROR("UnaryOp source is constant");
-						return ParseResult::Failure;
-					}
-
-					source_integer->value += (opcode == AML::Byte::AddOp) ? 1 : -1;
-					return ParseResult(source_integer);
-				}
-				case AML::Byte::NotOp:
-					AML_TODO("NotOp", context.aml_data[0]);
-					return ParseResult::Failure;
-				case AML::Byte::LNotOp:
-				{
-					context.aml_data = context.aml_data.slice(1);
-
-					auto node_result = AML::parse_object(context);
-					if (!node_result.success())
-						return ParseResult::Failure;
-
-					auto value = node_result.node() ? node_result.node()->as_integer() : BAN::Optional<uint64_t>();
-					if (!value.has_value())
-					{
-						AML_ERROR("Logical NotOp source is not integer");
-						return ParseResult::Failure;
-					}
-
-					auto result = value.value() ? Integer::Constants::Zero : Integer::Constants::Ones;
-					return ParseResult(result);
-				}
-				case AML::Byte::AddOp:
-				case AML::Byte::AndOp:
-				case AML::Byte::ModOp:
-				case AML::Byte::MultiplyOp:
-				case AML::Byte::NandOp:
-				case AML::Byte::NorOp:
-				case AML::Byte::OrOp:
-				case AML::Byte::ShiftLeftOp:
-				case AML::Byte::ShiftRightOp:
-				case AML::Byte::SubtractOp:
-				case AML::Byte::XorOp:
-					return parse_binary_op(context);
-				case AML::Byte::LAndOp:
-				case AML::Byte::LEqualOp:
-				case AML::Byte::LGreaterOp:
-				case AML::Byte::LLessOp:
-				case AML::Byte::LOrOp:
-					return parse_logical_binary_op(context);
-				case AML::Byte::DivideOp:
-					AML_TODO("DivideOp");
-					return ParseResult::Failure;
-				default:
-					ASSERT_NOT_REACHED();
-			}
-		}
-
-	private:
-		static ParseResult parse_binary_op(ParseContext& context)
-		{
-			auto opcode = static_cast<AML::Byte>(context.aml_data[0]);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto lhs_result = AML::parse_object(context);
-			if (!lhs_result.success())
-				return ParseResult::Failure;
-			auto lhs_value = lhs_result.node() ? lhs_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!lhs_value.has_value())
-			{
-				AML_ERROR("BinaryOP {2H} LHS not an integer", static_cast<uint8_t>(opcode));
-				if (lhs_result.node())
-					lhs_result.node()->debug_print(1);
-				AML_DEBUG_PRINTLN("");
-				return ParseResult::Failure;
-			}
-
-			auto rhs_result = AML::parse_object(context);
-			if (!rhs_result.success())
-				return ParseResult::Failure;
-			auto rhs_value = lhs_result.node() ? rhs_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!rhs_value.has_value())
-			{
-				AML_ERROR("BinaryOP {2H} RHS not an integer", static_cast<uint8_t>(opcode));
-				if (rhs_result.node())
-					rhs_result.node()->debug_print(1);
-				AML_DEBUG_PRINTLN("");
-				return ParseResult::Failure;
-			}
-
-			if (context.aml_data.size() < 1)
-			{
-				AML_ERROR("BinaryOP {2H} missing target", static_cast<uint8_t>(opcode));
-				return ParseResult::Failure;
-			}
-			BAN::RefPtr<AML::Node> target_node;
-			if (context.aml_data[0] == 0x00)
-				context.aml_data = context.aml_data.slice(1);
-			else
-			{
-				auto target_result = AML::parse_object(context);
-				if (!target_result.success())
-					return ParseResult::Failure;
-				target_node = target_result.node();
-				if (!target_node)
-				{
-					AML_ERROR("BinaryOP {2H} target invalid", static_cast<uint8_t>(opcode));
-					return ParseResult::Failure;
-				}
-			}
-
-			uint64_t (*func)(uint64_t, uint64_t) = nullptr;
-			switch (opcode)
-			{
-				case AML::Byte::AddOp:			func = [](uint64_t a, uint64_t b) { return a + b; }; break;
-				case AML::Byte::AndOp:			func = [](uint64_t a, uint64_t b) { return a & b; }; break;
-				case AML::Byte::ModOp:			func = [](uint64_t a, uint64_t b) { return a % b; }; break;
-				case AML::Byte::MultiplyOp:		func = [](uint64_t a, uint64_t b) { return a * b; }; break;
-				case AML::Byte::NandOp:			func = [](uint64_t a, uint64_t b) { return ~(a & b); }; break;
-				case AML::Byte::NorOp:			func = [](uint64_t a, uint64_t b) { return ~(a | b); }; break;
-				case AML::Byte::OrOp:			func = [](uint64_t a, uint64_t b) { return a | b; }; break;
-				case AML::Byte::ShiftLeftOp:	func = [](uint64_t a, uint64_t b) { return a << b; }; break;
-				case AML::Byte::ShiftRightOp:	func = [](uint64_t a, uint64_t b) { return a >> b; }; break;
-				case AML::Byte::SubtractOp:		func = [](uint64_t a, uint64_t b) { return a - b; }; break;
-				case AML::Byte::XorOp:			func = [](uint64_t a, uint64_t b) { return a ^ b; }; break;
-				default:
-					ASSERT_NOT_REACHED();
-			}
-
-			uint64_t result = func(lhs_value.value(), rhs_value.value());
-			auto result_node = MUST(BAN::RefPtr<AML::Integer>::create(result));
-
-			if (target_node && !target_node->store(result_node))
-			{
-				AML_ERROR("BinaryOp {2H} failed to store result", static_cast<uint8_t>(opcode));
-				return ParseResult::Failure;
-			}
-
-			return ParseResult(result_node);
-		}
-
-		static ParseResult parse_logical_binary_op(ParseContext& context)
-		{
-			auto opcode = static_cast<AML::Byte>(context.aml_data[0]);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto lhs_result = AML::parse_object(context);
-			if (!lhs_result.success())
-				return ParseResult::Failure;
-			auto lhs_value = lhs_result.node() ? lhs_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!lhs_value.has_value())
-			{
-				AML_TODO("Logical BinaryOP {2H} LHS not integer", static_cast<uint8_t>(opcode));
-				return ParseResult::Failure;
-			}
-
-			auto rhs_result = AML::parse_object(context);
-			if (!rhs_result.success())
-				return ParseResult::Failure;
-			auto rhs_value = rhs_result.node() ? rhs_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!rhs_value.has_value())
-			{
-				AML_TODO("Logical BinaryOP {2H} RHS not integer", static_cast<uint8_t>(opcode));
-				return ParseResult::Failure;
-			}
-
-			BAN::RefPtr<AML::Integer> (*func)(uint64_t, uint64_t) = nullptr;
-			switch (opcode)
-			{
-				case AML::Byte::LAndOp:			func = [](uint64_t a, uint64_t b) { return a && b ? Integer::Constants::Ones : Integer::Constants::Zero; }; break;
-				case AML::Byte::LEqualOp:		func = [](uint64_t a, uint64_t b) { return a == b ? Integer::Constants::Ones : Integer::Constants::Zero; }; break;
-				case AML::Byte::LGreaterOp:		func = [](uint64_t a, uint64_t b) { return a > b  ? Integer::Constants::Ones : Integer::Constants::Zero; }; break;
-				case AML::Byte::LLessOp:		func = [](uint64_t a, uint64_t b) { return a < b  ? Integer::Constants::Ones : Integer::Constants::Zero; }; break;
-				case AML::Byte::LOrOp:			func = [](uint64_t a, uint64_t b) { return a || b ? Integer::Constants::Ones : Integer::Constants::Zero; }; break;
-				default:
-					ASSERT_NOT_REACHED();
-			}
-
-			return ParseResult(func(lhs_value.value(), rhs_value.value()));
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Field.h

@@ -1,141 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/NamedObject.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-#include <kernel/ACPI/AML/Region.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct FieldRules
-	{
-		enum class AccessType
-		{
-			Any = 0,
-			Byte = 1,
-			Word = 2,
-			DWord = 3,
-			QWord = 4,
-			Buffer = 5,
-		};
-		AccessType access_type;
-
-		enum class LockRule
-		{
-			NoLock = 0,
-			Lock = 1,
-		};
-		LockRule lock_rule;
-
-		enum class UpdateRule
-		{
-			Preserve = 0,
-			WriteAsOnes = 1,
-			WriteAsZeros = 2,
-		};
-		UpdateRule update_rule;
-
-		enum class AccessAttrib
-		{
-			Normal = 0,
-			Bytes = 1,
-			RawBytes = 2,
-			RawProcessBytes = 3,
-		};
-		AccessAttrib access_attrib = AccessAttrib::Normal;
-		uint8_t access_length = 0;
-	};
-
-	struct FieldElement : public NamedObject
-	{
-		uint64_t bit_offset;
-		uint64_t bit_count;
-
-		FieldRules access_rules;
-
-		BAN::RefPtr<OpRegion> op_region;
-
-		FieldElement(NameSeg name, uint64_t bit_offset, uint64_t bit_count, FieldRules access_rules)
-			: NamedObject(Node::Type::FieldElement, name)
-			, bit_offset(bit_offset)
-			, bit_count(bit_count)
-			, access_rules(access_rules)
-		{}
-
-		BAN::RefPtr<Node> evaluate() override;
-		bool store(BAN::RefPtr<Node> source) override;
-
-		void debug_print(int indent) const override;
-
-	private:
-		BAN::Optional<uint64_t> evaluate_internal();
-		bool store_internal(uint64_t value);
-
-		friend struct IndexFieldElement;
-		friend struct BankFieldElement;
-	};
-
-	struct Field
-	{
-		static ParseResult parse(ParseContext& context);
-	};
-
-	struct IndexFieldElement : public NamedObject
-	{
-		uint64_t bit_offset;
-		uint64_t bit_count;
-
-		FieldRules access_rules;
-
-		BAN::RefPtr<FieldElement> index_element;
-		BAN::RefPtr<FieldElement> data_element;
-
-		IndexFieldElement(NameSeg name, uint64_t bit_offset, uint64_t bit_count, FieldRules access_rules)
-			: NamedObject(Node::Type::IndexFieldElement, name)
-			, bit_offset(bit_offset)
-			, bit_count(bit_count)
-			, access_rules(access_rules)
-		{}
-
-		BAN::RefPtr<Node> evaluate() override;
-		bool store(BAN::RefPtr<Node> source) override;
-
-		void debug_print(int indent) const override;
-	};
-
-	struct IndexField
-	{
-		static ParseResult parse(ParseContext& context);
-	};
-
-	struct BankFieldElement : public NamedObject
-	{
-		uint64_t bit_offset;
-		uint64_t bit_count;
-
-		FieldRules access_rules;
-
-		BAN::RefPtr<OpRegion> op_region;
-		BAN::RefPtr<FieldElement> bank_selector;
-		uint64_t bank_value;
-
-		BankFieldElement(NameSeg name, uint64_t bit_offset, uint64_t bit_count, FieldRules access_rules)
-			: NamedObject(Node::Type::BankFieldElement, name)
-			, bit_offset(bit_offset)
-			, bit_count(bit_count)
-			, access_rules(access_rules)
-		{}
-
-		BAN::RefPtr<Node> evaluate() override;
-		bool store(BAN::RefPtr<Node> source) override;
-
-		void debug_print(int indent) const override;
-	};
-
-	struct BankField
-	{
-		static ParseResult parse(ParseContext& context);
-	};
-
-}

kernel/include/kernel/ACPI/AML/IfElse.h

@@ -1,64 +0,0 @@
-#pragma once
-
-#include <BAN/HashMap.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct IfElse
-	{
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::IfOp);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto if_pkg = AML::parse_pkg(context.aml_data);
-			if (!if_pkg.has_value())
-				return ParseResult::Failure;
-
-			auto outer_aml_data = context.aml_data;
-			context.aml_data = if_pkg.value();
-
-			auto predicate_result = AML::parse_object(context);
-			if (!predicate_result.success())
-				return ParseResult::Failure;
-			auto predicate = predicate_result.node() ? predicate_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!predicate.has_value())
-			{
-				AML_ERROR("If predicate is not an integer");
-				return ParseResult::Failure;
-			}
-
-			// Else
-			BAN::ConstByteSpan else_pkg;
-			if (outer_aml_data.size() >= 1 && static_cast<AML::Byte>(outer_aml_data[0]) == Byte::ElseOp)
-			{
-				outer_aml_data = outer_aml_data.slice(1);
-				auto else_pkg_result = AML::parse_pkg(outer_aml_data);
-				if (!else_pkg_result.has_value())
-					return ParseResult::Failure;
-				else_pkg = else_pkg_result.value();
-			}
-			if (!predicate.value())
-				context.aml_data = else_pkg;
-
-			while (context.aml_data.size() > 0)
-			{
-				auto object_result = AML::parse_object(context);
-				if (object_result.returned())
-					return ParseResult(ParseResult::Result::Returned, object_result.node());
-				if (!object_result.success())
-					return ParseResult::Failure;
-			}
-
-			context.aml_data = outer_aml_data;
-
-			return ParseResult::Success;
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Index.h

@@ -1,106 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Buffer.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/Package.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Reference.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Index
-	{
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::IndexOp);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto source_result = AML::parse_object(context);
-			if (!source_result.success())
-				return ParseResult::Failure;
-			auto source = source_result.node() ? source_result.node()->evaluate() : BAN::RefPtr<AML::Node>();
-			if (!source)
-			{
-				AML_ERROR("IndexOp source is null");
-				return ParseResult::Failure;
-			}
-
-			auto index_result = AML::parse_object(context);
-			if (!index_result.success())
-				return ParseResult::Failure;
-			auto index = index_result.node() ? index_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!index.has_value())
-			{
-				AML_ERROR("IndexOp index is not an integer");
-				return ParseResult::Failure;
-			}
-
-			BAN::RefPtr<AML::Reference> result;
-			switch (source->type)
-			{
-				case AML::Node::Type::Buffer:
-				{
-					auto buffer = static_cast<AML::Buffer*>(source.ptr());
-					if (index.value() >= buffer->buffer.size())
-					{
-						AML_ERROR("IndexOp index is out of buffer bounds");
-						return ParseResult::Failure;
-					}
-					auto buffer_field = MUST(BAN::RefPtr<BufferField>::create(NameSeg(""_sv), buffer, index.value() * 8, 8));
-					result = MUST(BAN::RefPtr<AML::Reference>::create(buffer_field));
-					break;
-				}
-				case AML::Node::Type::Package:
-				{
-					auto package = static_cast<AML::Package*>(source.ptr());
-					if (index.value() >= package->elements.size())
-					{
-						AML_ERROR("IndexOp index is out of package bounds");
-						return ParseResult::Failure;
-					}
-					auto package_element = package->elements[index.value()];
-					result = MUST(BAN::RefPtr<AML::Reference>::create(package_element));
-					break;
-				}
-				case AML::Node::Type::String:
-					AML_TODO("IndexOp source String");
-					return ParseResult::Failure;
-				default:
-					AML_ERROR("IndexOp source is not a Buffer, Package, or String");
-					return ParseResult::Failure;
-			}
-
-#if AML_DEBUG_LEVEL >= 2
-			AML_DEBUG_PRINT("Index {}, ", index.value());
-			source->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			if (context.aml_data.size() < 1)
-				return ParseResult::Failure;
-
-			if (context.aml_data[0] == 0x00)
-				context.aml_data = context.aml_data.slice(1);
-			else
-			{
-				auto destination_result = AML::parse_object(context);
-				if (!destination_result.success())
-					return ParseResult::Failure;
-				auto destination = destination_result.node();
-				if (!destination)
-				{
-					AML_ERROR("IndexOp failed to resolve destination");
-					return ParseResult::Failure;
-				}
-
-				if (!destination->store(result))
-					return ParseResult::Failure;
-			}
-
-			return ParseResult(result);
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Integer.h

@@ -1,131 +0,0 @@
-#pragma once
-
-#include <BAN/Endianness.h>
-#include <BAN/Optional.h>
-#include <BAN/String.h>
-#include <BAN/Vector.h>
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/Utils.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Integer : public Node
-	{
-		struct Constants
-		{
-			// Initialized in Namespace::create_root_namespace
-			static BAN::RefPtr<Integer> Zero;
-			static BAN::RefPtr<Integer> One;
-			static BAN::RefPtr<Integer> Ones;
-		};
-
-		uint64_t value;
-		const bool constant;
-
-		Integer(uint64_t value, bool constant = false)
-			: Node(Node::Type::Integer)
-			, value(value)
-			, constant(constant)
-		{}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			return this;
-		}
-
-		bool store(BAN::RefPtr<AML::Node> store_node) override
-		{
-			if (constant)
-			{
-				AML_ERROR("Cannot store to constant integer");
-				return false;
-			}
-			auto store_value = store_node->as_integer();
-			if (!store_value.has_value())
-			{
-				AML_ERROR("Cannot store non-integer to integer");
-				return false;
-			}
-			value = store_value.value();
-			return true;
-		}
-
-		static ParseResult parse(BAN::ConstByteSpan& aml_data)
-		{
-			switch (static_cast<AML::Byte>(aml_data[0]))
-			{
-				case AML::Byte::ZeroOp:
-					aml_data = aml_data.slice(1);
-					return ParseResult(Constants::Zero);
-				case AML::Byte::OneOp:
-					aml_data = aml_data.slice(1);
-					return ParseResult(Constants::One);
-				case AML::Byte::OnesOp:
-					aml_data = aml_data.slice(1);
-					return ParseResult(Constants::Ones);
-				case AML::Byte::BytePrefix:
-				{
-					if (aml_data.size() < 2)
-						return ParseResult::Failure;
-					uint8_t value = aml_data[1];
-					aml_data = aml_data.slice(2);
-					return ParseResult(MUST(BAN::RefPtr<Integer>::create(value)));
-				}
-				case AML::Byte::WordPrefix:
-				{
-					if (aml_data.size() < 3)
-						return ParseResult::Failure;
-					uint16_t value = BAN::little_endian_to_host<uint16_t>(
-						*reinterpret_cast<const uint16_t*>(&aml_data[1])
-					);
-					aml_data = aml_data.slice(3);
-					return ParseResult(MUST(BAN::RefPtr<Integer>::create(value)));
-				}
-				case AML::Byte::DWordPrefix:
-				{
-					if (aml_data.size() < 5)
-						return ParseResult::Failure;
-					uint32_t value = BAN::little_endian_to_host<uint32_t>(
-						*reinterpret_cast<const uint32_t*>(&aml_data[1])
-					);
-					aml_data = aml_data.slice(5);
-					return ParseResult(MUST(BAN::RefPtr<Integer>::create(value)));
-				}
-				case AML::Byte::QWordPrefix:
-				{
-					if (aml_data.size() < 9)
-						return ParseResult::Failure;
-					uint64_t value = BAN::little_endian_to_host<uint64_t>(
-						*reinterpret_cast<const uint64_t*>(&aml_data[1])
-					);
-					aml_data = aml_data.slice(9);
-					return ParseResult(MUST(BAN::RefPtr<Integer>::create(value)));
-				}
-				default:
-					ASSERT_NOT_REACHED();
-			}
-		}
-
-		void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			if (!constant)
-				AML_DEBUG_PRINT("0x{H}", value);
-			else
-			{
-				AML_DEBUG_PRINT("Const ");
-				if (value == Constants::Zero->value)
-					AML_DEBUG_PRINT("Zero");
-				else if (value == Constants::One->value)
-					AML_DEBUG_PRINT("One");
-				else if (value == Constants::Ones->value)
-					AML_DEBUG_PRINT("Ones");
-				else
-					ASSERT_NOT_REACHED();
-			}
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Method.h

@@ -1,175 +0,0 @@
-#pragma once
-
-#include <BAN/Function.h>
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Namespace.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-#include <kernel/ACPI/AML/Scope.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Method : public AML::Scope
-	{
-		Kernel::Mutex mutex;
-		uint8_t arg_count;
-		bool serialized;
-		uint8_t sync_level;
-
-		BAN::Function<BAN::RefPtr<AML::Node>(ParseContext&)> override_function;
-		BAN::ConstByteSpan term_list;
-
-		Method(AML::NameSeg name, uint8_t arg_count, bool serialized, uint8_t sync_level)
-			: AML::Scope(Node::Type::Method, name)
-			, arg_count(arg_count)
-			, serialized(serialized)
-			, sync_level(sync_level)
-		{}
-
-		static ParseResult parse(AML::ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::MethodOp);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto method_pkg = AML::parse_pkg(context.aml_data);
-			if (!method_pkg.has_value())
-				return ParseResult::Failure;
-
-			auto name_string = AML::NameString::parse(method_pkg.value());
-			if (!name_string.has_value())
-				return ParseResult::Failure;
-
-			if (method_pkg->size() < 1)
-				return ParseResult::Failure;
-			auto method_flags = method_pkg.value()[0];
-			method_pkg = method_pkg.value().slice(1);
-
-			auto method = MUST(BAN::RefPtr<Method>::create(
-				name_string.value().path.back(),
-				method_flags & 0x07,
-				(method_flags >> 3) & 0x01,
-				method_flags >> 4
-			));
-			if (!Namespace::root_namespace()->add_named_object(context, name_string.value(), method))
-				return ParseResult::Failure;
-			method->term_list = method_pkg.value();
-
-#if AML_DEBUG_LEVEL >= 2
-			method->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return ParseResult::Success;
-		}
-
-		BAN::Optional<BAN::RefPtr<AML::Node>> invoke(
-			BAN::RefPtr<AML::Node> arg0 = {},
-			BAN::RefPtr<AML::Node> arg1 = {},
-			BAN::RefPtr<AML::Node> arg2 = {},
-			BAN::RefPtr<AML::Node> arg3 = {},
-			BAN::RefPtr<AML::Node> arg4 = {},
-			BAN::RefPtr<AML::Node> arg5 = {},
-			BAN::RefPtr<AML::Node> arg6 = {}
-		)
-		{
-			BAN::Vector<uint8_t> sync_stack;
-			return invoke_with_sync_stack(sync_stack, arg0, arg1, arg2, arg3, arg4, arg5, arg6);
-		}
-
-		BAN::Optional<BAN::RefPtr<AML::Node>> invoke_with_sync_stack(
-			BAN::Vector<uint8_t>& current_sync_stack,
-			BAN::RefPtr<AML::Node> arg0 = {},
-			BAN::RefPtr<AML::Node> arg1 = {},
-			BAN::RefPtr<AML::Node> arg2 = {},
-			BAN::RefPtr<AML::Node> arg3 = {},
-			BAN::RefPtr<AML::Node> arg4 = {},
-			BAN::RefPtr<AML::Node> arg5 = {},
-			BAN::RefPtr<AML::Node> arg6 = {}
-		)
-		{
-			if (serialized && !current_sync_stack.empty() && sync_level < current_sync_stack.back())
-			{
-				AML_ERROR("Trying to evaluate method {} with lower sync level than current sync level", scope);
-				return {};
-			}
-
-			ParseContext context;
-			context.aml_data = term_list;
-			context.scope = scope;
-			context.method_args[0] = MUST(BAN::RefPtr<AML::Register>::create(arg0));
-			context.method_args[1] = MUST(BAN::RefPtr<AML::Register>::create(arg1));
-			context.method_args[2] = MUST(BAN::RefPtr<AML::Register>::create(arg2));
-			context.method_args[3] = MUST(BAN::RefPtr<AML::Register>::create(arg3));
-			context.method_args[4] = MUST(BAN::RefPtr<AML::Register>::create(arg4));
-			context.method_args[5] = MUST(BAN::RefPtr<AML::Register>::create(arg5));
-			context.method_args[6] = MUST(BAN::RefPtr<AML::Register>::create(arg6));
-			context.sync_stack = BAN::move(current_sync_stack);
-			for (auto& local : context.method_locals)
-				local = MUST(BAN::RefPtr<AML::Register>::create());
-
-			if (serialized)
-			{
-				mutex.lock();
-				MUST(context.sync_stack.push_back(sync_level));
-			}
-
-#if AML_DEBUG_LEVEL >= 2
-			AML_DEBUG_PRINTLN("Evaluating {}", scope);
-#endif
-
-			BAN::Optional<BAN::RefPtr<AML::Node>> return_value = BAN::RefPtr<AML::Node>();
-
-			if (override_function)
-				return_value = override_function(context);
-			else
-			{
-				while (context.aml_data.size() > 0)
-				{
-					auto parse_result = AML::parse_object(context);
-					if (parse_result.returned())
-					{
-						return_value = parse_result.node();
-						break;
-					}
-					if (!parse_result.success())
-					{
-						AML_ERROR("Method {} evaluate failed", scope);
-						return_value = {};
-						break;
-					}
-				}
-			}
-
-			while (!context.created_objects.empty())
-			{
-				Namespace::root_namespace()->remove_named_object(context.created_objects.back());
-				context.created_objects.pop_back();
-			}
-
-			if (serialized)
-			{
-				context.sync_stack.pop_back();
-				mutex.unlock();
-			}
-
-			current_sync_stack = BAN::move(context.sync_stack);
-
-			return return_value;
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("Method ");
-			name.debug_print();
-			AML_DEBUG_PRINTLN("({} args, {}Serialized, 0x{H}) {", arg_count, serialized ? "" : "Not", sync_level);
-			AML_DEBUG_PRINT_INDENT(indent + 1);
-			AML_DEBUG_PRINTLN("TermList: {} bytes", term_list.size());
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("}");
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Mutex.h

@@ -1,166 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Integer.h>
-#include <kernel/ACPI/AML/NamedObject.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/Lock/Mutex.h>
-#include <kernel/Timer/Timer.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Mutex : public AML::NamedObject
-	{
-		Kernel::Mutex mutex;
-		uint8_t sync_level;
-
-		Mutex(NameSeg name, uint8_t sync_level)
-			: NamedObject(Node::Type::Mutex, name)
-			, sync_level(sync_level)
-		{}
-
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-
-			switch (static_cast<AML::ExtOp>(context.aml_data[1]))
-			{
-				case AML::ExtOp::MutexOp:
-					return parse_mutex(context);
-				case AML::ExtOp::AcquireOp:
-					return parse_acquire(context);
-				case AML::ExtOp::ReleaseOp:
-					return parse_release(context);
-				default:
-					ASSERT_NOT_REACHED();
-			}
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("Mutex ");
-			name.debug_print();
-			AML_DEBUG_PRINT(" (SyncLevel: {})", sync_level);
-		}
-
-	private:
-		static ParseResult parse_mutex(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::MutexOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto name = NameString::parse(context.aml_data);
-			if (!name.has_value())
-				return ParseResult::Failure;
-
-			if (context.aml_data.size() < 1)
-				return ParseResult::Failure;
-			auto sync_level = context.aml_data[0];
-			context.aml_data = context.aml_data.slice(1);
-
-			if (sync_level & 0xF0)
-			{
-				AML_ERROR("Invalid sync level {}", sync_level);
-				return ParseResult::Failure;
-			}
-
-			auto mutex = MUST(BAN::RefPtr<Mutex>::create(name->path.back(), sync_level));
-			if (!Namespace::root_namespace()->add_named_object(context, name.value(), mutex))
-				return ParseResult::Failure;
-
-#if AML_DEBUG_LEVEL >= 2
-			mutex->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return ParseResult::Success;
-		}
-
-		static ParseResult parse_acquire(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::AcquireOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto mutex_result = AML::parse_object(context);
-			if (!mutex_result.success() || !mutex_result.node() || mutex_result.node()->type != AML::Node::Type::Mutex)
-			{
-				AML_ERROR("Acquire does not name a valid mutex");
-				return ParseResult::Failure;
-			}
-
-			auto* mutex = static_cast<AML::Mutex*>(mutex_result.node().ptr());
-			if (mutex->sync_level < context.sync_level())
-			{
-				AML_ERROR("Trying to acquire mutex with lower sync level than current sync level");
-				return ParseResult::Failure;
-			}
-
-			if (context.aml_data.size() < 2)
-			{
-				AML_ERROR("Missing timeout value");
-				return ParseResult::Failure;
-			}
-			uint16_t timeout = context.aml_data[0] | (context.aml_data[1] << 8);
-			context.aml_data = context.aml_data.slice(2);
-
-			if (timeout >= 0xFFFF)
-				mutex->mutex.lock();
-			else
-			{
-				// FIXME: This is a very inefficient way to wait for a mutex
-				uint64_t wake_time = SystemTimer::get().ms_since_boot() + timeout;
-				while (!mutex->mutex.try_lock())
-				{
-					if (SystemTimer::get().ms_since_boot() >= wake_time)
-						return ParseResult(Integer::Constants::Ones);
-					SystemTimer::get().sleep(1);
-				}
-			}
-
-			MUST(context.sync_stack.push_back(mutex->sync_level));
-			return ParseResult(Integer::Constants::Zero);
-		}
-
-		static ParseResult parse_release(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::ReleaseOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto mutex_result = AML::parse_object(context);
-			if (!mutex_result.success() || !mutex_result.node() || mutex_result.node()->type != AML::Node::Type::Mutex)
-			{
-				AML_ERROR("Release does not name a valid mutex");
-				return ParseResult::Failure;
-			}
-
-			if (context.sync_stack.empty())
-			{
-				AML_ERROR("Trying to release mutex without having acquired it");
-				return ParseResult::Failure;
-			}
-
-			auto* mutex = static_cast<AML::Mutex*>(mutex_result.node().ptr());
-			if (mutex->sync_level != context.sync_level())
-			{
-				AML_ERROR("Trying to release mutex with different sync level than current sync level");
-				return ParseResult::Failure;
-			}
-
-			mutex->mutex.unlock();
-			context.sync_stack.pop_back();
-
-			return ParseResult::Success;
-		}
-
-	};
-
-}

kernel/include/kernel/ACPI/AML/NamedObject.h

@@ -1,42 +0,0 @@
-#pragma once
-
-#include <BAN/HashMap.h>
-#include <kernel/ACPI/AML/Names.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct NamedObject : public Node
-	{
-		BAN::RefPtr<NamedObject> parent;
-		NameSeg name;
-
-		NamedObject(Node::Type type, NameSeg name) : Node(type), name(name) {}
-	};
-
-	struct Name : public NamedObject
-	{
-		BAN::RefPtr<AML::Node> object;
-
-		Name(NameSeg name, BAN::RefPtr<AML::Node> object)
-			: NamedObject(Node::Type::Name, name), object(BAN::move(object))
-		{}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			ASSERT(object);
-			return object->evaluate();
-		}
-
-		bool store(BAN::RefPtr<AML::Node> node) override
-		{
-			ASSERT(object);
-			object = node;
-			return true;
-		}
-
-		static ParseResult parse(ParseContext& context);
-		virtual void debug_print(int indent) const override;
-	};
-
-}

kernel/include/kernel/ACPI/AML/Names.h

@@ -1,241 +0,0 @@
-#pragma once
-
-#include <BAN/Optional.h>
-#include <BAN/String.h>
-#include <BAN/Vector.h>
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/Utils.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct NameSeg
-	{
-		union {
-			char chars[4];
-			uint32_t u32;
-		};
-
-		NameSeg() = default;
-
-		NameSeg(BAN::StringView name)
-		{
-			ASSERT(name.size() <= 4);
-			for (size_t i = 0; i < name.size(); i++)
-				chars[i] = static_cast<char>(name[i]);
-			for (size_t i = name.size(); i < 4; i++)
-				chars[i] = '_';
-		}
-
-		NameSeg(BAN::ConstByteSpan& aml_data)
-		{
-			ASSERT(aml_data.size() >= 4);
-			for (size_t i = 0; i < 4; i++)
-				chars[i] = static_cast<char>(aml_data[i]);
-			aml_data = aml_data.slice(4);
-		}
-
-		BAN::StringView sv() const
-		{
-			size_t len = 4;
-			while (len > 0 && chars[len - 1] == '_')
-				len--;
-			return BAN::StringView(chars, len);
-		}
-
-		static BAN::Optional<NameSeg> parse(BAN::ConstByteSpan& aml_data)
-		{
-			if (aml_data.size() < 4)
-				return {};
-
-			if (!is_lead_name_char(aml_data[0])
-				|| !is_name_char(aml_data[1])
-				|| !is_name_char(aml_data[2])
-				|| !is_name_char(aml_data[3]))
-				return {};
-
-			return NameSeg(aml_data);
-		}
-
-		constexpr bool operator==(const NameSeg& other) const
-		{
-			return u32 == other.u32;
-		}
-
-		void debug_print() const
-		{
-			size_t len = 4;
-			while (len > 0 && chars[len - 1] == '_')
-				len--;
-			for (size_t i = 0; i < len; i++)
-				AML_DEBUG_PUTC(chars[i]);
-		}
-	};
-
-	struct NameString
-	{
-		BAN::String prefix;
-		BAN::Vector<NameSeg> path;
-
-		NameString() = default;
-		NameString(BAN::StringView str)
-		{
-			if (!str.empty() && str.front() == '\\')
-			{
-				MUST(prefix.push_back('\\'));
-				str = str.substring(1);
-			}
-			else
-			{
-				while (str.size() > 0 && str.front() == '^')
-				{
-					MUST(prefix.push_back('^'));
-					str = str.substring(1);
-				}
-			}
-
-			while (!str.empty())
-			{
-				ASSERT(str[0] != '.');
-				size_t len = 1;
-				while (len < str.size() && str[len] != '.')
-					len++;
-				ASSERT(len <= 4);
-
-				MUST(path.push_back(NameSeg(str.substring(0, len))));
-				str = str.substring(len);
-
-				if (!str.empty())
-				{
-					ASSERT(str[0] == '.');
-					str = str.substring(1);
-				}
-			}
-		}
-
-		static bool can_parse(BAN::ConstByteSpan aml_data)
-		{
-			if (aml_data.size() == 0)
-				return false;
-			switch (static_cast<AML::Byte>(aml_data[0]))
-			{
-				case AML::Byte::RootChar:
-				case AML::Byte::ParentPrefixChar:
-				case AML::Byte::NullName:
-				case AML::Byte::DualNamePrefix:
-				case AML::Byte::MultiNamePrefix:
-					return true;
-				default:
-					return is_lead_name_char(aml_data[0]);
-			}
-		}
-
-		static BAN::Optional<NameString> parse(BAN::ConstByteSpan& aml_data)
-		{
-			if (aml_data.size() == 0)
-				return {};
-
-			NameString result;
-
-			if (static_cast<AML::Byte>(aml_data[0]) == AML::Byte::RootChar)
-			{
-				MUST(result.prefix.push_back('\\'));
-				aml_data = aml_data.slice(1);
-			}
-			else
-			{
-				while (aml_data.size() > 0 && static_cast<AML::Byte>(aml_data[0]) == AML::Byte::ParentPrefixChar)
-				{
-					MUST(result.prefix.push_back(aml_data[0]));
-					aml_data = aml_data.slice(1);
-				}
-			}
-
-			if (aml_data.size() == 0)
-				return {};
-
-			size_t name_count = 1;
-			switch (static_cast<AML::Byte>(aml_data[0]))
-			{
-				case AML::Byte::NullName:
-					name_count = 0;
-					aml_data = aml_data.slice(1);
-					break;
-				case AML::Byte::DualNamePrefix:
-					name_count = 2;
-					aml_data = aml_data.slice(1);
-					break;
-				case AML::Byte::MultiNamePrefix:
-					if (aml_data.size() < 2)
-						return {};
-					name_count = aml_data[1];
-					aml_data = aml_data.slice(2);
-					break;
-				default:
-					break;
-			}
-
-			for (size_t i = 0; i < name_count; i++)
-			{
-				auto name_seg = NameSeg::parse(aml_data);
-				if (!name_seg.has_value())
-					return {};
-				MUST(result.path.push_back(name_seg.release_value()));
-			}
-
-			return result;
-		}
-
-		void debug_print() const
-		{
-			for (size_t i = 0; i < prefix.size(); i++)
-				AML_DEBUG_PUTC(prefix[i]);
-			if (!path.empty())
-				path.front().debug_print();
-			for (size_t i = 1; i < path.size(); i++)
-			{
-				AML_DEBUG_PUTC('.');
-				path[i].debug_print();
-			}
-		}
-	};
-
-}
-
-namespace BAN
-{
-
-	template<>
-	struct hash<Kernel::ACPI::AML::NameSeg>
-	{
-		constexpr hash_t operator()(Kernel::ACPI::AML::NameSeg name) const
-		{
-			return hash<uint32_t>()(name.u32);
-		}
-	};
-
-	template<typename F>
-	void Formatter::print_argument(F putc, const Kernel::ACPI::AML::NameSeg& name_seg, const ValueFormat&)
-	{
-		size_t len = 4;
-		while (len > 0 && name_seg.chars[len - 1] == '_')
-			len--;
-		for (size_t i = 0; i < len; i++)
-			putc(name_seg.chars[i]);
-	}
-
-	template<typename F>
-	void Formatter::print_argument(F putc, const Kernel::ACPI::AML::NameString& name_string, const ValueFormat&)
-	{
-		print_argument(putc, name_string.prefix, {});
-		if (!name_string.path.empty())
-			print_argument(putc, name_string.path.front(), {});
-		for (size_t i = 1; i < name_string.path.size(); i++)
-		{
-			putc('.');
-			print_argument(putc, name_string.path[i], {});
-		}
-	}
-
-}

kernel/include/kernel/ACPI/AML/Namespace.h

@@ -1,63 +1,74 @@
 #pragma once
 
+#include <BAN/Bitcast.h>
+#include <BAN/ByteSpan.h>
+#include <BAN/Function.h>
 #include <BAN/HashMap.h>
-#include <kernel/ACPI/AML/Scope.h>
+#include <BAN/HashSet.h>
-#include <kernel/ACPI/Headers.h>
+#include <BAN/Iteration.h>
-#include <kernel/Lock/Mutex.h>
+
+#include <kernel/ACPI/AML/Node.h>
 
 namespace Kernel::ACPI::AML
 {
 
-	struct Namespace : public AML::Scope
+	struct Namespace
 	{
-		static BAN::RefPtr<AML::Namespace> root_namespace();
+		BAN_NON_COPYABLE(Namespace);
+		BAN_NON_MOVABLE(Namespace);
+	public:
+		Namespace() = default;
+		~Namespace();
 
-		template<typename F>
+		static BAN::ErrorOr<void> prepare_root_namespace();
-		static void for_each_child(const AML::NameString& scope, const F& callback)
+		static Namespace& root_namespace();
+
+		BAN::ErrorOr<void> post_load_initialize();
+
+		BAN::ErrorOr<void> parse(BAN::ConstByteSpan);
+
+		BAN::ErrorOr<Node> evaluate(BAN::StringView path) { return evaluate(Scope {}, path); }
+		BAN::ErrorOr<Node> evaluate(const Scope& scope, BAN::StringView);
+
+		// returns empty scope if object already exited
+		BAN::ErrorOr<Scope> add_named_object(ParseContext& context, const NameString& name_string, Node&& node);
+		BAN::ErrorOr<Scope> add_alias(ParseContext& scope, const NameString& name_string, Reference* reference);
+
+		BAN::ErrorOr<void> remove_named_object(const Scope& absolute_path);
+
+		// node is nullptr if it is not found
+		struct FindResult
 		{
-			auto canonical_path = root_namespace()->resolve_path(scope, {}, FindMode::ForceAbsolute);
+			Scope path;
-			ASSERT(canonical_path.has_value());
+			Reference* node { nullptr };
-
-			for (auto& [path, child] : root_namespace()->m_objects)
-			{
-				if (path.size() < canonical_path->size() + 1)
-					continue;
-				if (canonical_path->size() != 1 && path[canonical_path->size()] != '.')
-					continue;
-				if (path.sv().substring(0, canonical_path->size()) != canonical_path->sv())
-					continue;
-				if (path.sv().substring(canonical_path->size() + 1).contains('.'))
-					continue;
-				callback(path, child);
-			}
-		}
-
-		Namespace(NameSeg name) : AML::Scope(Node::Type::Namespace, name) {}
-
-		static BAN::RefPtr<AML::Namespace> create_root_namespace();
-		bool parse(const SDTHeader& header);
-
-		void debug_print(int indent) const override;
-
-		enum class FindMode
-		{
-			Normal,
-			ForceAbsolute,
 		};
-		BAN::Optional<BAN::String> resolve_path(const AML::NameString& relative_base, const AML::NameString& relative_path, FindMode mode, bool check_existence = true) const;
+		BAN::ErrorOr<FindResult> find_named_object(const Scope& scope, const NameString& name_string, bool force_absolute = false);
 
-		// Find an object in the namespace. Returns nullptr if the object is not found.
+		BAN::ErrorOr<Scope> find_reference_scope(const Reference* reference);
-		BAN::RefPtr<NamedObject> find_object(const AML::NameString& relative_base, const AML::NameString& relative_path, FindMode mode);
 
-		// Add an object to the namespace. Returns false if the parent object could not be added.
+		BAN::ErrorOr<void> for_each_child(const Scope&, const BAN::Function<BAN::Iteration(BAN::StringView, Reference*)>&);
-		bool add_named_object(ParseContext&, const AML::NameString& object_path, BAN::RefPtr<NamedObject> object);
+		BAN::ErrorOr<void> for_each_child(const Scope&, const BAN::Function<BAN::Iteration(const Scope&, Reference*)>&);
 
-		// Remove an object from the namespace. Returns false if the object could not be removed.
+		BAN::ErrorOr<BAN::Vector<Scope>> find_device_with_eisa_id(BAN::StringView eisa_id);
-		bool remove_named_object(const AML::NameString& absolute_path);
+		BAN::ErrorOr<BAN::Vector<Scope>> find_device_with_eisa_id(BAN::Span<BAN::StringView> eisa_ids);
 
 	private:
-		BAN::HashMap<BAN::String, BAN::RefPtr<NamedObject>> m_objects;
+		BAN::ErrorOr<Scope> resolve_path(const Scope& scope, const NameString& name_string);
-		mutable Mutex m_object_mutex;
+
+		BAN::ErrorOr<void> initialize_scope(const Scope& scope);
+
+		BAN::ErrorOr<void> opregion_call_reg(const Scope& scope, const Node& opregion);
+
+		BAN::ErrorOr<uint64_t> evaluate_sta(const Scope& scope);
+		BAN::ErrorOr<void> evaluate_ini(const Scope& scope);
+
+		BAN::ErrorOr<void> initialize_op_regions();
+
+	private:
+		bool m_has_initialized_namespace { false };
+		BAN::HashMap<Scope, Reference*> m_named_objects;
+		BAN::HashMap<Scope, uint32_t> m_called_reg_bitmaps;
+		BAN::HashSet<Scope> m_aliases;
 	};
 
 }

kernel/include/kernel/ACPI/AML/Node.h

@@ -1,95 +1,449 @@
 #pragma once
 
+#include <BAN/Array.h>
 #include <BAN/ByteSpan.h>
+#include <BAN/LinkedList.h>
+#include <BAN/NoCopyMove.h>
 #include <BAN/Optional.h>
-#include <BAN/RefPtr.h>
+#include <BAN/StringView.h>
 #include <BAN/Vector.h>
-#include <kernel/ACPI/AML/Utils.h>
+
+#include <kernel/ACPI/AML/Scope.h>
+#include <kernel/ACPI/Headers.h>
+#include <kernel/Lock/Mutex.h>
+
+#define AML_DUMP_FUNCTION_CALLS 0
+#define AML_ENABLE_DEBUG 1
 
 namespace Kernel::ACPI::AML
 {
 
-	struct Node : public BAN::RefCounted<Node>
+	struct NameString
 	{
-		static uint64_t total_node_count;
+		BAN_NON_COPYABLE(NameString);
+	public:
+		NameString() = default;
+		NameString(NameString&& other)
+			: base(other.base)
+			, parts(BAN::move(other.parts))
+		{}
+		NameString& operator=(NameString&& other)
+		{
+			base = other.base;
+			parts = BAN::move(other.parts);
+			return *this;
+		}
+
+		static BAN::ErrorOr<NameString> from_string(BAN::StringView name);
+
+		BAN::ErrorOr<NameString> copy() const
+		{
+			NameString result;
+			result.base = this->base;
+
+			TRY(result.parts.resize(parts.size()));
+			for (size_t i = 0; i < parts.size(); i++)
+				result.parts[i] = parts[i];
+
+			return result;
+		}
+
+		static constexpr uint32_t base_root = -1;
+		uint32_t base { 0 };
+		BAN::Vector<uint32_t> parts;
+	};
+
+	template<typename T1, typename T2>
+	struct Pair
+	{
+		T1 elem1;
+		T2 elem2;
+	};
+
+	struct Node;
+	struct ParseContext;
+	struct Reference;
+
+	struct Mutex
+	{
+		Kernel::Mutex mutex;
+		uint8_t sync_level;
+		bool global_lock;
+		uint32_t ref_count;
+	};
+
+	struct Buffer
+	{
+		BAN::StringView as_sv() const
+		{
+			return BAN::StringView(reinterpret_cast<const char*>(bytes), size);
+		}
+
+		uint64_t size;
+		uint32_t ref_count;
+		uint8_t bytes[];
+	};
+
+	struct OpRegion
+	{
+		GAS::AddressSpaceID address_space;
+		uint64_t offset;
+		uint64_t length;
+		alignas(Scope) uint8_t scope_storage[sizeof(Scope)];
+		Scope& scope() { return *reinterpret_cast<Scope*>(scope_storage); }
+		const Scope& scope() const { return *reinterpret_cast<const Scope*>(scope_storage); }
+	};
+
+	struct FieldUnit
+	{
+		enum class Type {
+			Field,
+			IndexField,
+			BankField,
+		};
+		uint64_t offset;
+		uint64_t length;
+		uint8_t flags;
+		Type type;
+
+		union {
+			struct {
+				OpRegion opregion;
+			} field;
+			struct {
+				Reference* index;
+				Reference* data;
+			} index_field;
+			struct {
+				OpRegion opregion;
+				Reference* bank_selector;
+				uint64_t bank_value;
+			} bank_field;
+		} as;
+	};
+
+	struct Package
+	{
+		struct Element
+		{
+			struct Location {
+				NameString name;
+				Scope scope;
+			};
+
+			bool resolved { true };
+			union {
+				Node* node { nullptr };
+				Location* location;
+			} value;
+		};
+
+		uint64_t num_elements;
+		uint32_t ref_count;
+		Element elements[];
+	};
+
+	struct Node
+	{
+		BAN_NON_COPYABLE(Node);
+	public:
+		Node() = default;
+		~Node() { clear(); }
+
+		Node(Node&& other) { *this = BAN::move(other); }
+		Node& operator=(Node&&);
+
+		static BAN::ErrorOr<Node> create_string(BAN::StringView string)
+		{
+			const auto* u8_data = reinterpret_cast<const uint8_t*>(string.data());
+			auto result = TRY(create_buffer({ u8_data, string.size() }));
+			result.type = Node::Type::String;
+			return result;
+		}
+
+		static BAN::ErrorOr<Node> create_buffer(BAN::ConstByteSpan buffer)
+		{
+			Node node;
+			node.type = Node::Type::Buffer;
+			node.as.str_buf = static_cast<Buffer*>(kmalloc(sizeof(Buffer) + buffer.size()));
+			if (node.as.str_buf == nullptr)
+				return BAN::Error::from_errno(ENOMEM);
+			node.as.str_buf->ref_count = 1;
+			node.as.str_buf->size = buffer.size();
+			memcpy(node.as.str_buf->bytes, buffer.data(), buffer.size());
+			return node;
+		}
 
 		enum class Type
 		{
-			BankFieldElement,
+			Uninitialized,
-			Buffer,
+			Debug,
-			BufferField,
-			Device,
-			FieldElement,
-			IndexFieldElement,
 			Integer,
+			String,
+			Buffer,
+			Package,
+			BufferField,
+			OpRegion,
+			FieldUnit,
+			Event,
+			Device,
+			Processor,
+			PowerResource,
+			ThermalZone,
 			Method,
 			Mutex,
-			Name,
+			// FIXME: Index should not be its own type
-			Namespace,
+			//        parsing index should return references
-			OpRegion,
+			Index,
-			Package,
-			PackageElement,
-			PowerResource,
-			Processor,
 			Reference,
-			Register,
+			PredefinedScope,
-			String,
+			Count
-			ThermalZone,
+		} type { Type::Uninitialized };
-		};
-		const Type type;
 
-		Node(Type type) : type(type) { total_node_count++; }
+		inline bool is_scope() const
-		virtual ~Node() { total_node_count--; }
-
-		virtual bool is_scope() const { return false; }
-
-		[[nodiscard]] BAN::Optional<uint64_t> as_integer();
-		[[nodiscard]] virtual BAN::RefPtr<AML::Node> evaluate() { AML_TODO("evaluate, type {}", static_cast<uint8_t>(type)); return nullptr; }
-		[[nodiscard]] virtual bool store(BAN::RefPtr<AML::Node>) { AML_TODO("store, type {}", static_cast<uint8_t>(type)); return false; }
-
-		virtual void debug_print(int indent) const = 0;
-	};
-
-	struct ParseContext;
-	struct ParseResult
 		{
-		static ParseResult Failure;
+			switch (type)
-		static ParseResult Success;
-
-		enum class Result
 			{
-			Success,
+				case Type::Device:
-			Failure,
+				case Type::Processor:
-			Returned,
+				case Type::PowerResource:
-		};
+				case Type::ThermalZone:
-
+				case Type::PredefinedScope:
-		ParseResult(Result success)
+					return true;
-			: m_result(success)
+				default:
-		{}
+					return false;
-		ParseResult(Result success, BAN::RefPtr<Node> node)
+			}
-			: m_result(success)
+			ASSERT_NOT_REACHED();
-			, m_node(BAN::move(node))
-		{}
-		ParseResult(BAN::RefPtr<Node> node)
-			: m_result(Result::Success)
-			, m_node(BAN::move(node))
-		{
-			ASSERT(m_node);
 		}
 
-		bool success() const { return m_result == Result::Success; }
+		union
-		bool returned() const { return m_result == Result::Returned; }
-
-		BAN::RefPtr<Node> node()
 		{
-			ASSERT(m_node);
+			struct {
-			return m_node;
+				uint64_t value;
-		}
+			} integer;
+			Package* package;
+			Buffer* str_buf;
+			struct {
+				Buffer* buffer;
+				uint64_t bit_offset;
+				uint64_t bit_count;
+			} buffer_field;
+			OpRegion opregion;
+			FieldUnit field_unit;
+			struct {
+				uint32_t signal_count;
+			} event;
+			struct {
+				uint8_t storage[sizeof(Kernel::Mutex)];
+				const uint8_t* start;
+				size_t length;
+				uint8_t arg_count;
+				BAN::ErrorOr<Node> (*override_func)(const BAN::Array<Reference*, 7>&);
+				bool serialized;
+				Mutex* mutex;
+			} method;
+			Mutex* mutex;
+			struct {
+				Node::Type type;
+				union {
+					Buffer* str_buf;
+					Package* package;
+				} as;
+				uint64_t index;
+			} index;
+			Reference* reference;
+		} as;
 
-	private:
+		BAN::ErrorOr<Node> copy() const;
-		Result m_result = Result::Failure;
+
-		BAN::RefPtr<Node> m_node;
+		void clear();
 	};
-	ParseResult parse_object(ParseContext& context);
+
+	struct Reference
+	{
+		Node node {};
+		uint32_t ref_count { 1 };
+	};
+
+	struct ParseContext
+	{
+		Scope scope;
+		BAN::ConstByteSpan aml_data;
+
+		uint32_t call_depth { 0 };
+		BAN::Array<Reference*, 8> locals;
+		BAN::Array<Reference*, 7> args;
+
+		BAN::LinkedList<Scope> created_nodes;
+
+		~ParseContext();
+		BAN::ErrorOr<void> allocate_locals();
+	};
+
+	enum class ExecutionFlow
+	{
+		Normal,
+		Break,
+		Continue,
+		Return,
+	};
+	using ExecutionFlowResult = Pair<ExecutionFlow, BAN::Optional<Node>>;
+
+	enum Conversion : uint8_t
+	{
+		ConvInteger = 1,
+		ConvBuffer  = 2,
+		ConvString  = 4,
+	};
+
+	BAN::ErrorOr<Node> parse_node(ParseContext& context, bool return_ref = false);
+	BAN::ErrorOr<ExecutionFlowResult> parse_node_or_execution_flow(ParseContext& context);
+
+	BAN::ErrorOr<NameString> parse_name_string(BAN::ConstByteSpan& aml_data);
+	BAN::ErrorOr<BAN::ConstByteSpan> parse_pkg(BAN::ConstByteSpan& aml_data);
+
+	BAN::ErrorOr<Node> convert_node(Node&& source, uint8_t conversion, uint64_t max_length);
+	BAN::ErrorOr<Node> convert_node(Node&& source, const Node& target);
+
+	BAN::ErrorOr<Node> evaluate_node(const Scope& node_path, const Node& node);
+
+	// If method has no return, it will return <integer 0>
+	BAN::ErrorOr<Node> method_call(const Scope& scope, const Node& method, BAN::Array<Reference*, 7>&& args, uint32_t call_depth = 0);
+	BAN::ErrorOr<Node> method_call(const Scope& scope, const Node& method,
+		Node&& arg0 = {}, Node&& arg1 = {}, Node&& arg2 = {}, Node&& arg3 = {}, Node&& arg4 = {}, Node&& arg5 = {}, Node&& arg6 = {});
+
+	BAN::ErrorOr<void> resolve_package_element(Package::Element& element, bool error_if_not_exists);
+
+}
+
+namespace BAN::Formatter
+{
+
+	template<typename F>
+	void print_argument(F putc, const Kernel::ACPI::AML::NameString& name_string, const ValueFormat&)
+	{
+		if (name_string.base == Kernel::ACPI::AML::NameString::base_root)
+			putc('\\');
+		else for (uint32_t i = 0; i < name_string.base; i++)
+			putc('^');
+		for (size_t i = 0; i < name_string.parts.size(); i++) {
+			if (i != 0)
+				putc('.');
+			const char* name_seg = reinterpret_cast<const char*>(&name_string.parts[i]);
+			putc(name_seg[0]); putc(name_seg[1]); putc(name_seg[2]); putc(name_seg[3]);
+		}
+	}
+
+	template<typename F>
+	void print_argument(F putc, const Kernel::ACPI::AML::Buffer& buffer, const ValueFormat&)
+	{
+		static constexpr size_t max_elements { 16 };
+
+		print(putc, "<buffer '");
+		if (buffer.size)
+			print(putc, "{2H}", buffer.bytes[0]);
+		for (size_t i = 1; i < buffer.size && i < max_elements; i++)
+			print(putc, " {2H}", buffer.bytes[i]);
+		if (buffer.size > max_elements)
+			print(putc, "...");
+		print(putc, "'>");
+	}
+
+	template<typename F>
+	void print_argument(F putc, const Kernel::ACPI::AML::Package& package, const ValueFormat&)
+	{
+		print(putc, "<package '{} elements'>", package.num_elements);
+	}
+
+	template<typename F>
+	void print_argument(F putc, const Kernel::ACPI::AML::Node& node, const ValueFormat&)
+	{
+		switch (node.type)
+		{
+			case Kernel::ACPI::AML::Node::Type::Uninitialized:
+				print(putc, "<uninitialized>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::Debug:
+				print(putc, "<debug>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::Integer:
+				print(putc, "<integer 0x{H}>", node.as.integer.value);
+				break;
+			case Kernel::ACPI::AML::Node::Type::String:
+				print(putc, "<string '{}'>", node.as.str_buf->as_sv());
+				break;
+			case Kernel::ACPI::AML::Node::Type::Package:
+				print(putc, "{}", *node.as.package);
+				break;
+			case Kernel::ACPI::AML::Node::Type::Buffer:
+				print(putc, "{}", *node.as.str_buf);
+				break;
+			case Kernel::ACPI::AML::Node::Type::BufferField:
+				print(putc, "<buffer field '{} bytes, offset 0x{H}, bit count {}'>",
+					node.as.buffer_field.buffer->size,
+					node.as.buffer_field.bit_offset,
+					node.as.buffer_field.bit_count
+				);
+				break;
+			case Kernel::ACPI::AML::Node::Type::OpRegion:
+				print(putc, "<opregion 'type {2H}, offset 0x{H}, length 0x{H}'>",
+					static_cast<uint8_t>(node.as.opregion.address_space),
+					node.as.opregion.offset,
+					node.as.opregion.length
+				);
+				break;
+			case Kernel::ACPI::AML::Node::Type::FieldUnit:
+				print(putc, "<field unit ({}), 'offset 0x{H}, length 0x{H}'>",
+					static_cast<uint8_t>(node.as.field_unit.type),
+					node.as.field_unit.offset,
+					node.as.field_unit.length
+				);
+				break;
+			case Kernel::ACPI::AML::Node::Type::Event:
+				print(putc, "<event '{} signals'>", node.as.event.signal_count);
+				break;
+			case Kernel::ACPI::AML::Node::Type::Device:
+				print(putc, "<device>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::Processor:
+				print(putc, "<processor>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::PowerResource:
+				print(putc, "<power resouce>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::ThermalZone:
+				print(putc, "<thermal zone>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::Method:
+				print(putc, "<method '{} bytes'>", node.as.method.length);
+				break;
+			case Kernel::ACPI::AML::Node::Type::Mutex:
+				print(putc, "<mutex>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::Index:
+				switch (node.as.index.type)
+				{
+					case Kernel::ACPI::AML::Node::Type::String:
+					case Kernel::ACPI::AML::Node::Type::Buffer:
+						print(putc, "<index {}, {}>", *node.as.index.as.str_buf, node.as.index.index);
+						break;
+					case Kernel::ACPI::AML::Node::Type::Package:
+						print(putc, "<index {}, {}>", *node.as.index.as.package, node.as.index.index);
+						break;
+					default:
+						print(putc, "<index {}??, {}>", (uint32_t)node.as.index.type, node.as.index.index);
+						break;
+				}
+				break;
+			case Kernel::ACPI::AML::Node::Type::Reference:
+				print(putc, "<reference {}, {} refs>", node.as.reference->node, node.as.reference->ref_count);
+				break;
+			case Kernel::ACPI::AML::Node::Type::PredefinedScope:
+				print(putc, "<scope>");
+				break;
+			case Kernel::ACPI::AML::Node::Type::Count:
+				ASSERT_NOT_REACHED();
+		}
+	}
 
 }

kernel/include/kernel/ACPI/AML/Notify.h

@@ -1,66 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Device.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Processor.h>
-#include <kernel/ACPI/AML/ThermalZone.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Notify
-	{
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::NotifyOp);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto object_result = AML::parse_object(context);
-			if (!object_result.success())
-				return ParseResult::Failure;
-			auto object = object_result.node();
-			if (!object)
-			{
-				AML_ERROR("Notify object is null");
-				return ParseResult::Failure;
-			}
-
-			auto value_result = AML::parse_object(context);
-			if (!value_result.success())
-				return ParseResult::Failure;
-			auto value = value_result.node() ? value_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!value.has_value())
-			{
-				AML_ERROR("Notify value is not an integer");
-				return ParseResult::Failure;
-			}
-
-			BAN::StringView object_type_sv;
-			BAN::StringView object_name_sv;
-			switch (object->type)
-			{
-				case AML::Node::Type::Device:
-					object_type_sv = "Device"_sv;
-					object_name_sv = static_cast<AML::Device*>(object.ptr())->name.sv();
-					break;
-				case AML::Node::Type::Processor:
-					object_type_sv = "Processor"_sv;
-					object_name_sv = static_cast<AML::Processor*>(object.ptr())->name.sv();
-					break;
-				case AML::Node::Type::ThermalZone:
-					object_type_sv = "ThermalZone"_sv;
-					object_name_sv = static_cast<AML::ThermalZone*>(object.ptr())->name.sv();
-					break;
-				default:
-					object_type_sv = "Unknown"_sv;
-					object_name_sv = "????"_sv;
-					break;
-			}
-
-			AML_TODO("Notify: {} {}: {2H}", object_type_sv, object_name_sv, value.value());
-			return ParseResult::Success;
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/OpRegion.h

@@ -0,0 +1,16 @@
+#pragma once
+
+#include <kernel/ACPI/AML/Node.h>
+
+namespace Kernel::ACPI::AML
+{
+
+	BAN::ErrorOr<void> parse_opregion_op(ParseContext& context);
+	BAN::ErrorOr<void> parse_field_op(ParseContext& context);
+	BAN::ErrorOr<void> parse_index_field_op(ParseContext& context);
+	BAN::ErrorOr<void> parse_bank_field_op(ParseContext& context);
+
+	BAN::ErrorOr<Node> convert_from_field_unit(const Node& node, uint8_t conversion, uint64_t max_length);
+	BAN::ErrorOr<void> store_to_field_unit(const Node& source, const Node& target);
+
+}

kernel/include/kernel/ACPI/AML/Package.h

@@ -1,133 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct PackageElement;
-
-	struct Package : public AML::Node
-	{
-		BAN::Vector<BAN::RefPtr<PackageElement>> elements;
-		AML::NameString scope;
-
-		Package(AML::NameString scope)
-			: Node(Node::Type::Package)
-			, elements(BAN::move(elements))
-			, scope(scope)
-		{}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			return this;
-		}
-
-		static ParseResult parse(AML::ParseContext& context);
-		virtual void debug_print(int indent) const override;
-	};
-
-	struct PackageElement : public AML::Node
-	{
-		BAN::RefPtr<AML::Package> parent;
-		BAN::RefPtr<AML::Node> element;
-		AML::NameString unresolved_name;
-		bool resolved = false;
-		bool initialized = false;
-
-		PackageElement(BAN::RefPtr<AML::Package> parent, BAN::RefPtr<AML::Node> element)
-			: Node(Node::Type::PackageElement)
-			, parent(parent)
-			, element(element)
-		{
-			ASSERT(element);
-			resolved = true;
-			initialized = true;
-		}
-
-		PackageElement(BAN::RefPtr<AML::Package> parent, AML::NameString unresolved_name)
-			: Node(Node::Type::PackageElement)
-			, parent(parent)
-			, unresolved_name(unresolved_name)
-		{
-			resolved = false;
-			initialized = true;
-		}
-
-		PackageElement(BAN::RefPtr<AML::Package> parent)
-			: Node(Node::Type::PackageElement)
-			, parent(parent)
-		{
-			resolved = false;
-			initialized = false;
-		}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			if (!initialized)
-			{
-				AML_ERROR("Trying to evaluate uninitialized PackageElement");
-				return {};
-			}
-			if (!resolved)
-			{
-				auto object = Namespace::root_namespace()->find_object(parent->scope, unresolved_name, Namespace::FindMode::Normal);
-				if (!object)
-				{
-					AML_ERROR("Failed to resolve reference {} in package {}", unresolved_name, parent->scope);
-					return {};
-				}
-				element = object;
-				resolved = true;
-			}
-			return element->evaluate();
-		}
-
-		static ParseResult parse(AML::ParseContext& context, BAN::RefPtr<AML::Package> package)
-		{
-			BAN::RefPtr<AML::PackageElement> element;
-			if (context.aml_data[0] != 0x00 && AML::NameString::can_parse(context.aml_data))
-			{
-				auto name = AML::NameString::parse(context.aml_data);
-				if (!name.has_value())
-					return ParseResult::Failure;
-				element = MUST(BAN::RefPtr<PackageElement>::create(package, name.value()));
-			}
-			else
-			{
-				auto element_result = AML::parse_object(context);
-				if (!element_result.success())
-					return ParseResult::Failure;
-				element = MUST(BAN::RefPtr<PackageElement>::create(package, element_result.node()));
-			}
-			return ParseResult(element);
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINTLN("PackageElement {");
-			if (!initialized)
-			{
-				AML_DEBUG_PRINT_INDENT(indent + 1);
-				AML_DEBUG_PRINT("Uninitialized");
-			}
-			else if (!resolved)
-			{
-				AML_DEBUG_PRINT_INDENT(indent + 1);
-				AML_DEBUG_PRINT("Unresolved {}", unresolved_name);
-			}
-			else
-			{
-				element->debug_print(indent + 1);
-			}
-			AML_DEBUG_PRINTLN("");
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("}");
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/ParseContext.h

@@ -1,30 +0,0 @@
-#pragma once
-
-#include <BAN/Array.h>
-#include <BAN/ByteSpan.h>
-#include <BAN/LinkedList.h>
-#include <kernel/ACPI/AML/NamedObject.h>
-#include <kernel/ACPI/AML/Namespace.h>
-#include <kernel/ACPI/AML/Register.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct ParseContext
-	{
-		BAN::ConstByteSpan	aml_data;
-		AML::NameString		scope;
-
-		// Used for cleaning up on method exit
-		// NOTE: This uses linked list instead of vector because
-		//       we don't really need large contiguous memory
-		BAN::LinkedList<AML::NameString> created_objects;
-
-		uint8_t sync_level() const {  return !sync_stack.empty() ? sync_stack.back() : 0; }
-		BAN::Vector<uint8_t> sync_stack;
-
-		BAN::Array<BAN::RefPtr<Register>, 7> method_args;
-		BAN::Array<BAN::RefPtr<Register>, 8> method_locals;
-	};
-
-}

kernel/include/kernel/ACPI/AML/Pkg.h

@@ -1,51 +0,0 @@
-#pragma once
-
-#include <BAN/ByteSpan.h>
-#include <BAN/Optional.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	static BAN::Optional<uint32_t> parse_pkg_length(BAN::ConstByteSpan aml_data)
-	{
-		if (aml_data.size() < 1)
-			return {};
-
-		uint8_t lead_byte = aml_data[0];
-		if ((lead_byte & 0xC0) && (lead_byte & 0x30))
-			return {};
-
-		uint32_t pkg_length = lead_byte & 0x3F;
-		uint8_t byte_count = (lead_byte >> 6) + 1;
-
-		if (aml_data.size() < byte_count)
-			return {};
-
-		for (uint8_t i = 1; i < byte_count; i++)
-			pkg_length |= aml_data[i] << (i * 8 - 4);
-
-		return pkg_length;
-	}
-
-	static void trim_pkg_length(BAN::ConstByteSpan& aml_data)
-	{
-		ASSERT(aml_data.size() >= 1);
-		uint8_t byte_count = (aml_data[0] >> 6) + 1;
-		aml_data = aml_data.slice(byte_count);
-	}
-
-	static BAN::Optional<BAN::ConstByteSpan> parse_pkg(BAN::ConstByteSpan& aml_data)
-	{
-		auto pkg_length = parse_pkg_length(aml_data);
-		if (!pkg_length.has_value())
-			return {};
-
-		auto result = aml_data.slice(0, pkg_length.value());
-		trim_pkg_length(result);
-
-		aml_data = aml_data.slice(pkg_length.value());
-
-		return result;
-	}
-
-}

kernel/include/kernel/ACPI/AML/PowerResource.h

@@ -1,68 +0,0 @@
-#pragma once
-
-#include <BAN/Endianness.h>
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-#include <kernel/ACPI/AML/Scope.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct PowerResource : public AML::Scope
-	{
-		uint8_t system_level;
-		uint16_t resource_order;
-
-		PowerResource(NameSeg name, uint8_t system_level, uint16_t resource_order)
-			: Scope(Node::Type::PowerResource, name)
-			, system_level(system_level)
-			, resource_order(resource_order)
-		{}
-
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::PowerResOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto opt_power_res_pkg = AML::parse_pkg(context.aml_data);
-			if (!opt_power_res_pkg.has_value())
-				return ParseResult::Failure;
-			auto power_res_pkg = opt_power_res_pkg.value();
-
-			auto name = NameString::parse(power_res_pkg);
-			if (!name.has_value())
-				return ParseResult::Failure;
-
-			if (power_res_pkg.size() < 1)
-				return ParseResult::Failure;
-			uint8_t system_level = power_res_pkg[0];
-			power_res_pkg = power_res_pkg.slice(1);
-
-			if (power_res_pkg.size() < 2)
-				return ParseResult::Failure;
-			uint16_t resource_order = BAN::little_endian_to_host<uint16_t>(*reinterpret_cast<const uint16_t*>(power_res_pkg.data()));
-			power_res_pkg = power_res_pkg.slice(2);
-
-			auto power_res = MUST(BAN::RefPtr<PowerResource>::create(name->path.back(), system_level, resource_order));
-			if (!Namespace::root_namespace()->add_named_object(context, name.value(), power_res))
-				return ParseResult::Failure;
-
-#if AML_DEBUG_LEVEL >= 2
-			power_res->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return power_res->enter_context_and_parse_term_list(context, name.value(), power_res_pkg);
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("PowerResource {} (SystemLevel {}, ResourceOrder {})", name, system_level, resource_order);
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Processor.h

@@ -1,84 +0,0 @@
-#pragma once
-
-#include <BAN/Endianness.h>
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-#include <kernel/ACPI/AML/Scope.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Processor : public AML::Scope
-	{
-		uint8_t id;
-		uint32_t pblk_addr;
-		uint8_t pblk_len;
-
-		Processor(NameSeg name, uint8_t id, uint32_t pblk_addr, uint8_t pblk_len)
-			: Scope(Node::Type::Processor, name)
-			, id(id)
-			, pblk_addr(pblk_addr)
-			, pblk_len(pblk_len)
-		{}
-
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::ProcessorOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto opt_processor_pkg = AML::parse_pkg(context.aml_data);
-			if (!opt_processor_pkg.has_value())
-				return ParseResult::Failure;
-			auto processor_pkg = opt_processor_pkg.value();
-
-			auto name = NameString::parse(processor_pkg);
-			if (!name.has_value())
-				return ParseResult::Failure;
-
-			if (processor_pkg.size() < 1)
-				return ParseResult::Failure;
-			uint8_t id = processor_pkg[0];
-			processor_pkg = processor_pkg.slice(1);
-
-			if (processor_pkg.size() < 4)
-				return ParseResult::Failure;
-			uint32_t pblk_addr = BAN::little_endian_to_host<uint32_t>(*reinterpret_cast<const uint32_t*>(processor_pkg.data()));
-			processor_pkg = processor_pkg.slice(4);
-
-			if (processor_pkg.size() < 1)
-				return ParseResult::Failure;
-			uint8_t pblk_len = processor_pkg[0];
-			processor_pkg = processor_pkg.slice(1);
-
-			auto processor = MUST(BAN::RefPtr<Processor>::create(name->path.back(), id, pblk_addr, pblk_len));
-			if (!Namespace::root_namespace()->add_named_object(context, name.value(), processor))
-				return ParseResult::Failure;
-
-#if AML_DEBUG_LEVEL >= 2
-			processor->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return processor->enter_context_and_parse_term_list(context, name.value(), processor_pkg);
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINTLN("Processor {} (ID: {}, PBlkAddr: 0x{H}, PBlkLen: {}) {", name, id, pblk_addr, pblk_len);
-			Namespace::root_namespace()->for_each_child(scope,
-				[&](const auto&, const auto& child)
-				{
-					child->debug_print(indent + 1);
-					AML_DEBUG_PRINTLN("");
-				}
-			);
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("}");
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Reference.h

@@ -1,155 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Integer.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/Names.h>
-#include <kernel/ACPI/AML/String.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Reference : public AML::Node
-	{
-		BAN::RefPtr<AML::Node> node;
-
-		Reference(BAN::RefPtr<AML::Node> node)
-			: Node(AML::Node::Type::Reference)
-			, node(node)
-		{
-			ASSERT(node);
-		}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			return this;
-		}
-
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-
-			bool conditional = false;
-			switch (static_cast<AML::Byte>(context.aml_data[0]))
-			{
-				case AML::Byte::DerefOfOp:
-					return parse_dereference(context);
-				case AML::Byte::RefOfOp:
-					context.aml_data = context.aml_data.slice(1);
-					conditional = false;
-					break;
-				case AML::Byte::ExtOpPrefix:
-					ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::CondRefOfOp);
-					context.aml_data = context.aml_data.slice(2);
-					conditional = true;
-					break;
-				default:
-					ASSERT_NOT_REACHED();
-			}
-
-			BAN::RefPtr<AML::Node> object;
-			if (NameString::can_parse(context.aml_data))
-			{
-				auto name = NameString::parse(context.aml_data);
-				if (!name.has_value())
-					return ParseResult::Failure;
-				object = Namespace::root_namespace()->find_object(context.scope, name.value(), Namespace::FindMode::Normal);
-			}
-			else
-			{
-				auto parse_result = AML::parse_object(context);
-				if (!parse_result.success())
-					return ParseResult::Failure;
-				object = parse_result.node();
-			}
-
-			if (!conditional)
-			{
-				if (!object)
-				{
-					AML_ERROR("RefOf failed to resolve reference");
-					return ParseResult::Failure;
-				}
-				auto reference = MUST(BAN::RefPtr<Reference>::create(object));
-#if AML_DEBUG_LEVEL >= 2
-				reference->debug_print(0);
-				AML_DEBUG_PRINTLN("");
-#endif
-				return ParseResult(reference);
-			}
-
-			if (context.aml_data.size() >= 1 && context.aml_data[0] != 0x00)
-			{
-				auto target_result = AML::parse_object(context);
-				if (!target_result.success())
-					return ParseResult::Failure;
-				auto target_node = target_result.node();
-				if (!target_node)
-				{
-					AML_ERROR("CondRefOf failed to resolve target");
-					return ParseResult::Failure;
-				}
-				target_node->store(MUST(BAN::RefPtr<Reference>::create(object)));
-			}
-
-#if AML_DEBUG_LEVEL >= 2
-			AML_DEBUG_PRINT("CondRefOf ");
-			if (object)
-				object->debug_print(0);
-			else
-				AML_DEBUG_PRINT("null");
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			auto return_value = object ? Integer::Constants::Ones : Integer::Constants::Zero;
-			return AML::ParseResult(return_value);
-		}
-
-		static ParseResult parse_dereference(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::DerefOfOp);
-			context.aml_data = context.aml_data.slice(1);
-
-			if (context.aml_data.size() >= 1 && static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::StringPrefix)
-			{
-				auto string_result = AML::String::parse(context);
-				if (!string_result.success())
-					return ParseResult::Failure;
-				ASSERT(string_result.node());
-				auto string = static_cast<AML::String*>(string_result.node().ptr());
-				AML_TODO("DerefOf String ({})", string->string);
-				return ParseResult::Failure;
-			}
-			else
-			{
-				auto parse_result = AML::parse_object(context);
-				if (!parse_result.success())
-					return ParseResult::Failure;
-				auto object = parse_result.node();
-				if (!object || object->type != AML::Node::Type::Reference)
-				{
-					AML_TODO("DerefOf source is not a Reference, but a {}", object ? static_cast<uint8_t>(object->type) : 999);
-					return ParseResult::Failure;
-				}
-#if AML_DEBUG_LEVEL >= 2
-				AML_DEBUG_PRINT("DerefOf ");
-				object->debug_print(0);
-				AML_DEBUG_PRINTLN("");
-#endif
-				return ParseResult(static_cast<Reference*>(object.ptr())->node);
-			}
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINTLN("Reference {");
-			node->debug_print(indent + 1);
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("}");
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Region.h

@@ -1,106 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/NamedObject.h>
-#include <kernel/ACPI/AML/Namespace.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct OpRegion : public NamedObject
-	{
-		using RegionSpace = GAS::AddressSpaceID;
-		RegionSpace region_space;
-		uint64_t region_offset;
-		uint64_t region_length;
-
-		Kernel::Mutex mutex;
-
-		OpRegion(NameSeg name, RegionSpace region_space, uint64_t region_offset, uint64_t region_length)
-			: NamedObject(Node::Type::OpRegion, name)
-			, region_space(region_space)
-			, region_offset(region_offset)
-			, region_length(region_length)
-		{}
-
-		static ParseResult parse(AML::ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() > 2);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::ExtOpPrefix);
-			ASSERT(static_cast<ExtOp>(context.aml_data[1]) == ExtOp::OpRegionOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto name = NameString::parse(context.aml_data);
-			if (!name.has_value())
-				return ParseResult::Failure;
-
-			if (context.aml_data.size() < 1)
-				return ParseResult::Failure;
-			auto region_space = static_cast<RegionSpace>(context.aml_data[0]);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto offset_result = AML::parse_object(context);
-			if (!offset_result.success())
-				return ParseResult::Failure;
-			auto offset = offset_result.node()->as_integer();
-			if (!offset.has_value())
-			{
-				AML_ERROR("OpRegion offset must be an integer");
-				return ParseResult::Failure;
-			}
-
-			auto length_result = AML::parse_object(context);
-			if (!length_result.success())
-				return ParseResult::Failure;
-			auto length = length_result.node()->as_integer();
-			if (!length.has_value())
-			{
-				AML_ERROR("OpRegion length must be an integer");
-				return ParseResult::Failure;
-			}
-
-			auto op_region = MUST(BAN::RefPtr<OpRegion>::create(
-				name->path.back(),
-				region_space,
-				offset.value(),
-				length.value()
-			));
-
-			if (!Namespace::root_namespace()->add_named_object(context, name.value(), op_region))
-				return ParseResult::Failure;
-
-#if AML_DEBUG_LEVEL >= 2
-			op_region->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return ParseResult::Success;
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			BAN::StringView region_space_name;
-			switch (region_space)
-			{
-				case RegionSpace::SystemMemory:					region_space_name = "SystemMemory"_sv; break;
-				case RegionSpace::SystemIO:						region_space_name = "SystemIO"_sv; break;
-				case RegionSpace::PCIConfig:					region_space_name = "PCIConfig"_sv; break;
-				case RegionSpace::EmbeddedController:			region_space_name = "EmbeddedController"_sv; break;
-				case RegionSpace::SMBus:						region_space_name = "SMBus"_sv; break;
-				case RegionSpace::SystemCMOS:					region_space_name = "SystemCMOS"_sv; break;
-				case RegionSpace::PCIBarTarget:					region_space_name = "PCIBarTarget"_sv; break;
-				case RegionSpace::IPMI:							region_space_name = "IPMI"_sv; break;
-				case RegionSpace::GeneralPurposeIO:				region_space_name = "GeneralPurposeIO"_sv; break;
-				case RegionSpace::GenericSerialBus:				region_space_name = "GenericSerialBus"_sv; break;
-				case RegionSpace::PlatformCommunicationChannel:	region_space_name = "PlatformCommunicationChannel"_sv; break;
-				default: region_space_name = "Unknown"_sv; break;
-			}
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("OperationRegion(");
-			name.debug_print();
-			AML_DEBUG_PRINT(", {}, 0x{H}, 0x{H})", region_space_name, region_offset, region_length);
-		}
-
-	};
-
-}

kernel/include/kernel/ACPI/AML/Register.h

@@ -1,55 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Node.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Register : public AML::Node
-	{
-		BAN::RefPtr<AML::Node> value;
-
-		Register()
-			: Node(Node::Type::Register)
-		{}
-		Register(BAN::RefPtr<AML::Node> value)
-			: Node(Node::Type::Register)
-			, value(value)
-		{}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			if (value)
-				return value->evaluate();
-			return {};
-		}
-
-		bool store(BAN::RefPtr<AML::Node> source) override
-		{
-			auto evaluated = source->evaluate();
-			if (!evaluated)
-			{
-				AML_ERROR("Failed to evaluate source for store");
-				return false;
-			}
-			value = evaluated;
-			return true;
-		}
-
-		void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			if (!value)
-				AML_DEBUG_PRINT("Register { No value }");
-			else
-			{
-				AML_DEBUG_PRINTLN("Register { ");
-				value->debug_print(indent + 1);
-				AML_DEBUG_PRINTLN("");
-				AML_DEBUG_PRINT_INDENT(indent);
-				AML_DEBUG_PRINT(" }");
-			}
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Scope.h

@@ -1,27 +1,74 @@
 #pragma once
 
-#include <kernel/ACPI/AML/NamedObject.h>
+#include <BAN/Hash.h>
-#include <kernel/ACPI/AML/Names.h>
+#include <BAN/NoCopyMove.h>
+#include <BAN/Vector.h>
 
 namespace Kernel::ACPI::AML
 {
 
-	struct Scope : public AML::NamedObject
+	struct Scope
 	{
-		AML::NameString scope;
+		BAN_NON_COPYABLE(Scope);
+	public:
+		Scope() = default;
+		Scope(Scope&& other) { *this = BAN::move(other); }
+		Scope& operator=(Scope&& other) { parts = BAN::move(other.parts); return *this; }
 
-		Scope(Node::Type type, NameSeg name)
+		BAN::Vector<uint32_t> parts;
-			: NamedObject(type, name)
-		{}
 
-		virtual bool is_scope() const override { return true; }
+		BAN::ErrorOr<Scope> copy() const
+		{
+			Scope result;
+			TRY(result.parts.reserve(parts.size()));
+			for (uint32_t part : parts)
+				TRY(result.parts.push_back(part));
+			return result;
+		}
 
-		static ParseResult parse(ParseContext& context);
+		bool operator==(const Scope& other) const
-
+		{
-	protected:
+			if (parts.size() != other.parts.size())
-		ParseResult enter_context_and_parse_term_list(ParseContext& outer_context, const AML::NameString& name, BAN::ConstByteSpan aml_data);
+				return false;
+			for (size_t i = 0; i < parts.size(); i++)
+				if (parts[i] != other.parts[i])
+					return false;
+			return true;
+		}
 	};
 
-	bool initialize_scope(BAN::RefPtr<Scope> scope);
+}
+
+namespace BAN
+{
+
+	template<>
+	struct hash<Kernel::ACPI::AML::Scope>
+	{
+		hash_t operator()(const Kernel::ACPI::AML::Scope& scope) const
+		{
+			hash_t hash { 0 };
+			for (uint32_t part : scope.parts)
+				hash ^= u32_hash(part);
+			return hash;
+		}
+	};
+
+}
+
+namespace BAN::Formatter
+{
+
+	template<typename F>
+	void print_argument(F putc, const Kernel::ACPI::AML::Scope& scope, const ValueFormat&)
+	{
+		putc('\\');
+		for (size_t i = 0; i < scope.parts.size(); i++) {
+			if (i != 0)
+				putc('.');
+			const char* name_seg = reinterpret_cast<const char*>(&scope.parts[i]);
+			putc(name_seg[0]); putc(name_seg[1]); putc(name_seg[2]); putc(name_seg[3]);
+		}
+	}
 
 }

kernel/include/kernel/ACPI/AML/Sleep.h

@@ -1,38 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/Timer/Timer.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Sleep
-	{
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::SleepOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto sleep_time_result = AML::parse_object(context);
-			if (!sleep_time_result.success())
-				return ParseResult::Failure;
-			auto sleep_time = sleep_time_result.node() ? sleep_time_result.node()->as_integer() : BAN::Optional<uint64_t>();
-			if (!sleep_time.has_value())
-			{
-				AML_ERROR("Sleep time cannot be evaluated to an integer");
-				return ParseResult::Failure;
-			}
-
-#if AML_DEBUG_LEVEL >= 2
-			AML_DEBUG_PRINTLN("Sleeping for {} ms", sleep_time.value());
-#endif
-
-			SystemTimer::get().sleep(sleep_time.value());
-			return ParseResult::Success;
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Store.h

@@ -1,53 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct Store
-	{
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<Byte>(context.aml_data[0]) == Byte::StoreOp);
-			context.aml_data = context.aml_data.slice(1);
-
-			auto source_result = AML::parse_object(context);
-			if (!source_result.success())
-				return ParseResult::Failure;
-			auto source = source_result.node() ? source_result.node()->evaluate() : BAN::RefPtr<AML::Node>();
-			if (!source)
-			{
-				AML_ERROR("Store source cannot be evaluated");
-				return ParseResult::Failure;
-			}
-
-			auto destination_result = AML::parse_object(context);
-			if (!destination_result.success())
-				return ParseResult::Failure;
-			auto destination = destination_result.node();
-			if (!destination)
-			{
-				AML_ERROR("Store destination is null");
-				return ParseResult::Failure;
-			}
-
-#if AML_DEBUG_LEVEL >= 2
-			AML_DEBUG_PRINTLN("Storing {");
-			source->debug_print(1);
-			AML_DEBUG_PRINTLN("");
-			AML_DEBUG_PRINTLN("} to {");
-			destination->debug_print(1);
-			AML_DEBUG_PRINTLN("");
-			AML_DEBUG_PRINTLN("}");
-#endif
-
-			if (!destination->store(source))
-				return ParseResult::Failure;
-			return ParseResult::Success;
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/String.h

@@ -1,56 +0,0 @@
-#pragma once
-
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/Node.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct String : public AML::Node
-	{
-		BAN::String string;
-
-		String() : Node(Node::Type::String) {}
-
-		BAN::RefPtr<AML::Node> evaluate() override
-		{
-			return this;
-		}
-
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 1);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::StringPrefix);
-			context.aml_data = context.aml_data.slice(1);
-
-			BAN::String string;
-
-			while (context.aml_data.size() > 0)
-			{
-				if (context.aml_data[0] == 0x00)
-					break;
-				MUST(string.push_back(static_cast<char>(context.aml_data[0])));
-				context.aml_data = context.aml_data.slice(1);
-			}
-
-			if (context.aml_data.size() == 0)
-				return ParseResult::Failure;
-			if (context.aml_data[0] != 0x00)
-				return ParseResult::Failure;
-			context.aml_data = context.aml_data.slice(1);
-
-			auto string_node = MUST(BAN::RefPtr<String>::create());
-			string_node->string = BAN::move(string);
-
-			return ParseResult(string_node);
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("String \"{}\"", string);
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/ThermalZone.h

@@ -1,62 +0,0 @@
-#pragma once
-
-#include <BAN/Endianness.h>
-#include <kernel/ACPI/AML/Bytes.h>
-#include <kernel/ACPI/AML/ParseContext.h>
-#include <kernel/ACPI/AML/Pkg.h>
-#include <kernel/ACPI/AML/Scope.h>
-
-namespace Kernel::ACPI::AML
-{
-
-	struct ThermalZone : public AML::Scope
-	{
-		ThermalZone(NameSeg name)
-			: Scope(Node::Type::ThermalZone, name)
-		{}
-
-		static ParseResult parse(ParseContext& context)
-		{
-			ASSERT(context.aml_data.size() >= 2);
-			ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::ExtOpPrefix);
-			ASSERT(static_cast<AML::ExtOp>(context.aml_data[1]) == AML::ExtOp::PowerResOp);
-			context.aml_data = context.aml_data.slice(2);
-
-			auto opt_thermal_zone_pkg = AML::parse_pkg(context.aml_data);
-			if (!opt_thermal_zone_pkg.has_value())
-				return ParseResult::Failure;
-			auto thermal_zone_pkg = opt_thermal_zone_pkg.value();
-
-			auto name = NameString::parse(thermal_zone_pkg);
-			if (!name.has_value())
-				return ParseResult::Failure;
-
-			auto thermal_zone = MUST(BAN::RefPtr<ThermalZone>::create(name->path.back()));
-			if (!Namespace::root_namespace()->add_named_object(context, name.value(), thermal_zone))
-				return ParseResult::Failure;
-
-#if AML_DEBUG_LEVEL >= 2
-			thermal_zone->debug_print(0);
-			AML_DEBUG_PRINTLN("");
-#endif
-
-			return thermal_zone->enter_context_and_parse_term_list(context, name.value(), thermal_zone_pkg);
-		}
-
-		virtual void debug_print(int indent) const override
-		{
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("ThermalZone {} {", name);
-			Namespace::root_namespace()->for_each_child(scope,
-				[&](const auto&, const auto& child)
-				{
-					child->debug_print(indent + 1);
-					AML_DEBUG_PRINTLN("");
-				}
-			);
-			AML_DEBUG_PRINT_INDENT(indent);
-			AML_DEBUG_PRINT("}");
-		}
-	};
-
-}

kernel/include/kernel/ACPI/AML/Utils.h

@@ -1,36 +0,0 @@
-#pragma once
-
-#include <BAN/Formatter.h>
-#include <kernel/Debug.h>
-
-// AML_DEBUG_LEVEL:
-//   0: No debug output
-//   1: Dump AML after parsing
-//   2: Dump AML while parsing
-#define AML_DEBUG_LEVEL 0
-
-#define AML_TODO(...) 											\
-	do {														\
-		BAN::Formatter::print(Debug::putchar, "\e[33mTODO: ");	\
-		BAN::Formatter::print(Debug::putchar, __VA_ARGS__);		\
-		BAN::Formatter::println(Debug::putchar, "\e[m");		\
-	} while (0)
-
-#define AML_ERROR(...) 											\
-	do {														\
-		BAN::Formatter::print(Debug::putchar, "\e[31mERROR: ");	\
-		BAN::Formatter::print(Debug::putchar, __VA_ARGS__);		\
-		BAN::Formatter::println(Debug::putchar, "\e[m");		\
-	} while (0)
-
-#define AML_PRINT(...) BAN::Formatter::println(Debug::putchar, __VA_ARGS__)
-
-#define AML_DEBUG_PRINT_INDENT(indent)			\
-	do {										\
-		for (int i = 0; i < (indent) * 2; i++)	\
-			AML_DEBUG_PUTC(' ');				\
-	} while (0)
-
-#define AML_DEBUG_PUTC(c) Debug::putchar(c)
-#define AML_DEBUG_PRINT(...) BAN::Formatter::print(Debug::putchar, __VA_ARGS__)
-#define AML_DEBUG_PRINTLN(...) BAN::Formatter::println(Debug::putchar, __VA_ARGS__)