Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BuildSystem: custom mount directory for bananos image to avoid conflicts #4

Merged
Bananymous merged 6 commits from Sinipelto/banan-os:main into main 2023-11-20 12:16:58 +00:00
Conversation 3 Commits 6 Files Changed 2 +30 -7
Sinipelto commented 2023-11-20 11:30:51 +00:00
Contributor
Copy Link

Fix for #2

Fix for #2
Sinipelto added 4 commits 2023-11-20 11:30:51 +00:00
Merge pull request 'update main' (#1) from Bananymous/banan-os:main into main a6a5c00763 
Reviewed-on: Sinipelto/banan-os#1
Update script/image.sh a7b1810aa2 
handle custom mount dir

Signed-off-by: Sinipelto <sinipelto@noreply.bananymous.com>
Update script/image-create.sh 566724d986 
custom mount dir

Signed-off-by: Sinipelto <sinipelto@noreply.bananymous.com>
Update script/image.sh f97922a2b5 
mount dir default value

Signed-off-by: Sinipelto <sinipelto@noreply.bananymous.com>
Sinipelto changed title from Custom mount directory for bananos image to Custom mount directory for bananos image 2023-11-20 11:35:53 +00:00
Bananymous commented 2023-11-20 11:43:21 +00:00
Owner
Copy Link

If we change to custom mount point I think it should be within this repo. Maybe $BANAN_BUILD_DIR/mnt? That way there is no way to leave random directory in root.

If we change to custom mount point I think it should be within this repo. Maybe $BANAN_BUILD_DIR/mnt? That way there is no way to leave random directory in root.
👍 1
Bananymous commented 2023-11-20 11:58:54 +00:00
Owner
Copy Link

Also for future reference the commit messages should be in the form <target>: <brief description>. Where <target> is BuildSystem in this case.

Also for future reference the commit messages should be in the form `<target>: <brief description>`. Where `<target>` is BuildSystem in this case.
👍 1
Sinipelto changed title from Custom mount directory for bananos image to BuildSystem: custom mount directory for bananos image to avoid conflicts 2023-11-20 12:08:17 +00:00
Sinipelto requested review from Bananymous 2023-11-20 12:09:36 +00:00
Sinipelto added 1 commit 2023-11-20 12:11:31 +00:00
BuildSystem: image create sh 6cfa56dcec 
use banan build dir

Signed-off-by: Sinipelto <sinipelto@noreply.bananymous.com>
Sinipelto added 1 commit 2023-11-20 12:12:36 +00:00
BuildSystem: image sh d72db1f81c 
mount in build dir

Signed-off-by: Sinipelto <sinipelto@noreply.bananymous.com>
Sinipelto commented 2023-11-20 12:13:12 +00:00
Author
Contributor
Copy Link

If we change to custom mount point I think it should be within this repo. Maybe $BANAN_BUILD_DIR/mnt? That way there is no way to leave random directory in root.

this is now done.

> If we change to custom mount point I think it should be within this repo. Maybe $BANAN_BUILD_DIR/mnt? That way there is no way to leave random directory in root. this is now done.
Bananymous merged commit 0563643e1c into main 2023-11-20 12:16:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Bananymous
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Bananymous
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bananymous/banan-os#4
Delete Branch "Sinipelto/banan-os:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?