Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BuildSystem: prefer unambiguous mount point to avoid conflicts #2

New Issue
Closed
opened 2023-11-20 11:15:11 +00:00 by Sinipelto · 1 comment
Sinipelto commented 2023-11-20 11:15:11 +00:00
Contributor
Copy Link

banan-os/script/image-create.sh Line 29 in f2397b775c
MOUNT_DIR=/mnt

Would it be better to create some certainly unused path eg /bananmnt instead to avoid collision with possible existing mounts? E,g, I have stuff mounted under /mnt subfolders in constant use so this script would break them.

https://git.bananymous.com/Bananymous/banan-os/src/commit/f2397b775c7d485f6eb6a076523cc9e05d5b3a98/script/image-create.sh#L29 Would it be better to create some certainly unused path eg /bananmnt instead to avoid collision with possible existing mounts? E,g, I have stuff mounted under /mnt subfolders in constant use so this script would break them.
Sinipelto changed title from Prefer unambiguous mount point to BuildSystem: prefer unambiguous mount point to avoid conflicts 2023-11-20 12:08:32 +00:00
Bananymous commented 2023-11-20 12:18:31 +00:00
Owner
Copy Link

Resolved in #4

Resolved in #4
🚀 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Bananymous
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bananymous/banan-os#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?