Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check env var is set explicitly in the beginning? #3

New Issue
Closed
opened 2023-11-20 11:16:34 +00:00 by Sinipelto · 2 comments
Sinipelto commented 2023-11-20 11:16:34 +00:00
Contributor
Copy Link

banan-os/script/image-create.sh Line 34 in f2397b775c
if [ "$BANAN_UEFI_BOOT" == "1" ]; then

https://git.bananymous.com/Bananymous/banan-os/src/commit/f2397b775c7d485f6eb6a076523cc9e05d5b3a98/script/image-create.sh#L34
Bananymous commented 2023-11-20 11:50:23 +00:00
Owner
Copy Link

Yeah that can be checked. Also the if statement could probably just be if (($BANAN_UEFI_BOOT)); then and let the shell check if it is zero or non-zero.

Yeah that can be checked. Also the if statement could probably just be `if (($BANAN_UEFI_BOOT)); then` and let the shell check if it is zero or non-zero.
🚀 1
Bananymous commented 2023-11-21 10:33:10 +00:00
Owner
Copy Link

Resolved in #4 and 5e9b21bdce3a96efc797f698757d94830c0f03e7

Resolved in #4 and 5e9b21bdce3a96efc797f698757d94830c0f03e7
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Bananymous
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Bananymous/banan-os#3
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?