Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kernel: HDAudio only probe codecs in STATESTS 

This removes unnecessary probing that lead to timeouts. Also cap codec
address at 14 instead of 15. My test laptop was duplicating codec 0 at
address 15 leading to duplicate devices.
This commit is contained in:
Bananymous 2026-03-24 00:49:47 +02:00
parent c563efcd1c
commit f89d690716
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
kernel/include/kernel/Audio/HDAudio/Registers.h
View File

@ -11,6 +11,7 @@ namespace Kernel::HDAudio
VMIN = 0x02, VMIN = 0x02,
VMAJ = 0x03, VMAJ = 0x03,
GCTL = 0x08, GCTL = 0x08,
STATESTS = 0x0E,
INTCTL = 0x20, INTCTL = 0x20,
INTSTS = 0x24, INTSTS = 0x24,

6
kernel/kernel/Audio/HDAudio/Controller.cpp
View File

@ -65,8 +65,12 @@ namespace Kernel
m_pci_device.enable_interrupt(0, *this); m_pci_device.enable_interrupt(0, *this);
m_bar0->write32(Regs::INTCTL, UINT32_MAX); m_bar0->write32(Regs::INTCTL, UINT32_MAX);
for (uint8_t codec_id = 0; codec_id < 0x10; codec_id++) const uint16_t state_sts = m_bar0->read16(Regs::STATESTS);
for (uint8_t codec_id = 0; codec_id < 15; codec_id++)
{ {
if (!(state_sts & (1 << codec_id)))
continue;
auto codec_or_error = initialize_codec(codec_id); auto codec_or_error = initialize_codec(codec_id);
if (codec_or_error.is_error()) if (codec_or_error.is_error())
continue; continue;