Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kernel: Remove the weird StorageController base class

Browse Source 
This wasn't really used for anything and broke nvme controller as it was
now doubly ref counted :P
This commit is contained in:
Bananymous
2026-07-02 15:02:02 +03:00
parent 8be90c49bc
commit d8f136a76f
10 changed files with 29 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
kernel/include/kernel/Storage/NVMe/Controller.h
View File

@@ -10,13 +10,13 @@
namespace Kernel
{
class NVMeController final : public StorageController, public CharacterDevice
class NVMeController final : public CharacterDevice
{
BAN_NON_COPYABLE(NVMeController);
BAN_NON_MOVABLE(NVMeController);
public:
static BAN::ErrorOr<BAN::RefPtr<StorageController>> create(PCI::Device&);
static BAN::ErrorOr<BAN::RefPtr<NVMeController>> create(PCI::Device&);
NVMeQueue& io_queue() { return *m_io_queue; }
@@ -30,7 +30,7 @@ namespace Kernel
private:
NVMeController(PCI::Device& pci_device);
virtual BAN::ErrorOr<void> initialize() override;
BAN::ErrorOr<void> initialize();
BAN::ErrorOr<void> identify_controller();
BAN::ErrorOr<void> identify_namespaces();