Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Shell: Only set terminal properties if STDIN is a TTY

This commit is contained in:
Bananymous 2024-06-03 18:02:49 +03:00
parent 1066855532
commit 981c0eb8bc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
userspace/Shell/main.cpp
View File

@ -612,7 +612,7 @@ pid_t execute_command_no_wait(BAN::Vector<BAN::String>& args, int fd_in, int fd_
perror("setpgid"); perror("setpgid");
exit(1); exit(1);
} }
if (tcsetpgrp(0, getpgrp()) == -1) if (isatty(0) && tcsetpgrp(0, getpgrp()) == -1)
{ {
perror("tcsetpgrp"); perror("tcsetpgrp");
exit(1); exit(1);
@ -644,7 +644,7 @@ int execute_command(BAN::Vector<BAN::String>& args, int fd_in, int fd_out)
if (waitpid(pid, &status, 0) == -1) if (waitpid(pid, &status, 0) == -1)
ERROR_RETURN("waitpid", 1); ERROR_RETURN("waitpid", 1);
if (tcsetpgrp(0, getpgrp()) == -1) if (isatty(0) && tcsetpgrp(0, getpgrp()) == -1)
ERROR_RETURN("tcsetpgrp", 1); ERROR_RETURN("tcsetpgrp", 1);
if (WIFSIGNALED(status)) if (WIFSIGNALED(status))
@ -722,7 +722,7 @@ int execute_piped_commands(BAN::Vector<BAN::Vector<BAN::String>>& commands)
exit_codes[i] = WEXITSTATUS(status); exit_codes[i] = WEXITSTATUS(status);
} }
if (tcsetpgrp(0, getpgrp()) == -1) if (isatty(0) && tcsetpgrp(0, getpgrp()) == -1)
ERROR_RETURN("tcsetpgrp", 1); ERROR_RETURN("tcsetpgrp", 1);
return exit_codes.back(); return exit_codes.back();