Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kenrel: Cleanup locking in close

Browse Source
This commit is contained in:
Bananymous
2026-07-04 19:19:10 +03:00
parent 89d3ee7b92
commit 7a696c4d63
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kernel/kernel/OpenFileDescriptorSet.cpp
View File

@@ -400,12 +400,20 @@ namespace Kernel
} }
BAN::ErrorOr<void> OpenFileDescriptorSet::close(int fd) BAN::ErrorOr<void> OpenFileDescriptorSet::close(int fd)
{
BAN::RefPtr<OpenFileDescription> open_file;
{ {
LockGuard _(m_mutex); LockGuard _(m_mutex);
TRY(validate_fd(fd)); TRY(validate_fd(fd));
auto& open_file = m_open_files[fd]; open_file = m_open_files[fd];
m_open_files[fd]->file.inode->on_close(m_open_files[fd]->status_flags);
m_open_files[fd] = {};
remove_cloexec(fd);
}
if (auto& flock = open_file->flock; Thread::current().has_process() && flock.lockers.contains(Process::current().pid())) if (auto& flock = open_file->flock; Thread::current().has_process() && flock.lockers.contains(Process::current().pid()))
{ {
@@ -429,10 +437,6 @@ namespace Kernel
} }
} }
open_file->file.inode->on_close(open_file->status_flags);
open_file = {};
remove_cloexec(fd);
return {}; return {};
} }