Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Shell: Verify that command exists before executing it 

This prevents page fault somewhere when executing non-existing
commands.
This commit is contained in:
Bananymous 2023-12-04 22:57:27 +02:00
parent cf76d2e7d9
commit 622007f2ee
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
userspace/Shell/main.cpp
View File

@ -501,6 +501,21 @@ pid_t execute_command_no_wait(BAN::Vector<BAN::String>& args, int fd_in, int fd_
executable_file = args.front();
}
// Verify that the file exists is executable
{
struct stat st;
if (stat(executable_file.data(), &st) == -1)
{
fprintf(stderr, "command not found: %s\n", args.front().data());
return -1;
}
if ((st.st_mode & 0111) == 0)
{
fprintf(stderr, "permission denied: %s\n", executable_file.data());
return -1;
}
}
pid_t pid = fork();
if (pid == 0)
{