Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BAN: Add [[nodiscard]] to BAN functions returning ErrorOr

Browse Source
This commit is contained in:
Bananymous
2023-01-12 23:57:07 +02:00
parent 78da037dda
commit 61bd9da8e0
7 changed files with 80 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
BAN/include/BAN/Queue.h
View File

@@ -21,7 +21,7 @@ namespace BAN
Queue() = default;
~Queue();
ErrorOr<void> Push(const T& value);
[[nodiscard]] ErrorOr<void> Push(const T& value);
void Pop();
bool Empty() const;
@@ -31,7 +31,7 @@ namespace BAN
T& Front();
private:
ErrorOr<void> VerifyCapacity(size_type size);
[[nodiscard]] ErrorOr<void> VerifyCapacity(size_type size);
private:
T* m_data = nullptr;

21
BAN/include/BAN/String.h
View File

@@ -16,8 +16,7 @@ namespace BAN
String();
String(const String&);
String(String&&);
String(const StringView&);
String(const char*, size_type = -1);
String(StringView);
~String();
template<typename... Args>
@@ -26,13 +25,15 @@ namespace BAN
String& operator=(const String&);
String& operator=(String&&);
ErrorOr<void> PushBack(char);
ErrorOr<void> Insert(char, size_type);
ErrorOr<void> Append(const char*);
ErrorOr<void> Append(const String&);
[[nodiscard]] ErrorOr<void> PushBack(char);
[[nodiscard]] ErrorOr<void> Insert(char, size_type);
[[nodiscard]] ErrorOr<void> Insert(StringView, size_type);
[[nodiscard]] ErrorOr<void> Append(StringView);
[[nodiscard]] ErrorOr<void> Append(const String&);
void PopBack();
void Remove(size_type);
void Erase(size_type, size_type);
void Clear();
@@ -43,8 +44,8 @@ namespace BAN
bool operator==(StringView) const;
bool operator==(const char*) const;
ErrorOr<void> Resize(size_type, char = '\0');
ErrorOr<void> Reserve(size_type);
[[nodiscard]] ErrorOr<void> Resize(size_type, char = '\0');
[[nodiscard]] ErrorOr<void> Reserve(size_type);
StringView SV() const;
@@ -55,9 +56,9 @@ namespace BAN
const char* Data() const;
private:
ErrorOr<void> EnsureCapasity(size_type);
[[nodiscard]] ErrorOr<void> EnsureCapasity(size_type);
ErrorOr<void> copy_impl(const char*, size_type);
[[nodiscard]] ErrorOr<void> copy_impl(StringView);
void move_impl(String&&);
private:

6
BAN/include/BAN/StringView.h
View File

@@ -24,8 +24,8 @@ namespace BAN
StringView Substring(size_type, size_type = -1) const;
ErrorOr<Vector<StringView>> Split(char, bool = false);
ErrorOr<Vector<StringView>> Split(bool(*comp)(char), bool = false);
[[nodiscard]] ErrorOr<Vector<StringView>> Split(char, bool = false);
[[nodiscard]] ErrorOr<Vector<StringView>> Split(bool(*comp)(char), bool = false);
size_type Count(char) const;
@@ -41,6 +41,8 @@ namespace BAN
}
inline BAN::StringView operator""_sv(const char* str, BAN::StringView::size_type len) { return BAN::StringView(str, len); }
namespace BAN::Formatter
{

10
BAN/include/BAN/Vector.h
View File

@@ -21,8 +21,8 @@ namespace BAN
Vector(const Vector<T>&);
~Vector();
ErrorOr<void> PushBack(const T&);
ErrorOr<void> Insert(const T&, size_type);
[[nodiscard]] ErrorOr<void> PushBack(const T&);
[[nodiscard]] ErrorOr<void> Insert(const T&, size_type);
void PopBack();
void Remove(size_type);
@@ -37,15 +37,15 @@ namespace BAN
const T& Front() const;
T& Front();
ErrorOr<void> Resize(size_type);
ErrorOr<void> Reserve(size_type);
[[nodiscard]] ErrorOr<void> Resize(size_type);
[[nodiscard]] ErrorOr<void> Reserve(size_type);
bool Empty() const;
size_type Size() const;
size_type Capasity() const;
private:
ErrorOr<void> EnsureCapasity(size_type);
[[nodiscard]] ErrorOr<void> EnsureCapasity(size_type);
private:
T* m_data = nullptr;