Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kernel: Fix bug in disk writing 

I have used two weeks in locating a bug in my ext2 implementation
while the bug was actually in disk write. If you called write_sectors
on disk it would write the first sector_size bytes repeatedly to all
asked sectors and this corrupted the disk...
This commit is contained in:
Bananymous 2023-09-08 02:43:08 +03:00
parent e631eb7a7a
commit 5d67559e33
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/kernel/Storage/StorageDevice.cpp
View File

@ -279,12 +279,13 @@ namespace Kernel
BAN::ErrorOr<void> StorageDevice::write_sectors(uint64_t lba, uint8_t sector_count, const uint8_t* buffer) BAN::ErrorOr<void> StorageDevice::write_sectors(uint64_t lba, uint8_t sector_count, const uint8_t* buffer)
{ {
// TODO: use disk cache for dirty pages. I don't wanna think about how to do it safely now // TODO: use disk cache for dirty pages. I don't wanna think about how to do it safely now
for (uint8_t sector = 0; sector < sector_count; sector++) for (uint8_t offset = 0; offset < sector_count; offset++)
{ {
Thread::TerminateBlocker _(Thread::current()); Thread::TerminateBlocker _(Thread::current());
TRY(write_sectors_impl(lba + sector, 1, buffer)); const uint8_t* buffer_ptr = buffer + offset * sector_size();
TRY(write_sectors_impl(lba + offset, 1, buffer_ptr));
if (m_disk_cache.has_value()) if (m_disk_cache.has_value())
(void)m_disk_cache->write_to_cache(lba + sector, buffer + sector * sector_size(), false); (void)m_disk_cache->write_to_cache(lba + offset, buffer_ptr, false);
} }
return {}; return {};