Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BAN: StringView::split(char, bool) is now thread safe 

I had to duplicate some code, but this is better since I would like
to not use BAN::Function for something like this
This commit is contained in:
Bananymous 2023-03-30 16:35:38 +03:00
parent 8e68d2e3ea
commit 5d459130a7
1 changed files with 32 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
BAN/BAN/StringView.cpp
View File

@ -63,9 +63,38 @@ namespace BAN
ErrorOr<Vector<StringView>> StringView::split(char delim, bool allow_empties) ErrorOr<Vector<StringView>> StringView::split(char delim, bool allow_empties)
{ {
// FIXME: Won't work while multithreading size_type count = 0;
static char s_delim = delim; {
return split([](char c){ return c == s_delim; }, allow_empties); size_type start = 0;
for (size_type i = 0; i < m_size; i++)
{
if (m_data[i] == delim)
{
if (allow_empties || start != i)
count++;
start = i + 1;
}
}
if (start != m_size)
count++;
}
Vector<StringView> result;
TRY(result.reserve(count));
size_type start = 0;
for (size_type i = 0; i < m_size; i++)
{
if (m_data[i] == delim)
{
if (allow_empties || start != i)
TRY(result.push_back(this->substring(start, i - start)));
start = i + 1;
}
}
if (start != m_size)
TRY(result.push_back(this->substring(start)));
return result;
} }
ErrorOr<Vector<StringView>> StringView::split(bool(*comp)(char), bool allow_empties) ErrorOr<Vector<StringView>> StringView::split(bool(*comp)(char), bool allow_empties)