Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kernel: Add error reporting for readonly mounted filesystems

This commit is contained in:
Bananymous 2025-06-30 01:51:52 +03:00
parent 13d33995cb
commit 5912abd541
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kernel/kernel/FS/FAT/FileSystem.cpp
View File

@ -2,6 +2,7 @@
#include <kernel/Lock/LockGuard.h> #include <kernel/Lock/LockGuard.h>
#include <ctype.h> #include <ctype.h>
#include <sys/statvfs.h>
namespace Kernel namespace Kernel
{ {
@ -73,7 +74,7 @@ namespace Kernel
fsfilcnt_t FATFS::ffree() const { return 0; } // FIXME fsfilcnt_t FATFS::ffree() const { return 0; } // FIXME
fsfilcnt_t FATFS::favail() const { return 0; } // FIXME fsfilcnt_t FATFS::favail() const { return 0; } // FIXME
unsigned long FATFS::fsid() const { return m_type == Type::FAT32 ? m_bpb.ext_32.volume_id : m_bpb.ext_12_16.volume_id; } unsigned long FATFS::fsid() const { return m_type == Type::FAT32 ? m_bpb.ext_32.volume_id : m_bpb.ext_12_16.volume_id; }
unsigned long FATFS::flag() const { return 0; } unsigned long FATFS::flag() const { return ST_RDONLY; }
unsigned long FATFS::namemax() const { return 255; } unsigned long FATFS::namemax() const { return 255; }
BAN::ErrorOr<BAN::RefPtr<FATFS>> FATFS::create(BAN::RefPtr<BlockDevice> block_device) BAN::ErrorOr<BAN::RefPtr<FATFS>> FATFS::create(BAN::RefPtr<BlockDevice> block_device)

22
kernel/kernel/FS/Inode.cpp
View File

@ -1,9 +1,11 @@
#include <kernel/Epoll.h> #include <kernel/Epoll.h>
#include <kernel/FS/FileSystem.h>
#include <kernel/FS/Inode.h> #include <kernel/FS/Inode.h>
#include <kernel/Lock/LockGuard.h> #include <kernel/Lock/LockGuard.h>
#include <kernel/Memory/FileBackedRegion.h> #include <kernel/Memory/FileBackedRegion.h>
#include <fcntl.h> #include <fcntl.h>
#include <sys/statvfs.h>
namespace Kernel namespace Kernel
{ {
@ -81,6 +83,8 @@ namespace Kernel
return BAN::Error::from_errno(ENOTDIR); return BAN::Error::from_errno(ENOTDIR);
if (Mode(mode).ifdir()) if (Mode(mode).ifdir())
return BAN::Error::from_errno(EINVAL); return BAN::Error::from_errno(EINVAL);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return create_file_impl(name, mode, uid, gid); return create_file_impl(name, mode, uid, gid);
} }
@ -91,6 +95,8 @@ namespace Kernel
return BAN::Error::from_errno(ENOTDIR); return BAN::Error::from_errno(ENOTDIR);
if (!Mode(mode).ifdir()) if (!Mode(mode).ifdir())
return BAN::Error::from_errno(EINVAL); return BAN::Error::from_errno(EINVAL);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return create_directory_impl(name, mode, uid, gid); return create_directory_impl(name, mode, uid, gid);
} }
@ -101,6 +107,8 @@ namespace Kernel
return BAN::Error::from_errno(ENOTDIR); return BAN::Error::from_errno(ENOTDIR);
if (inode->mode().ifdir()) if (inode->mode().ifdir())
return BAN::Error::from_errno(EINVAL); return BAN::Error::from_errno(EINVAL);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return link_inode_impl(name, inode); return link_inode_impl(name, inode);
} }
@ -111,6 +119,8 @@ namespace Kernel
return BAN::Error::from_errno(ENOTDIR); return BAN::Error::from_errno(ENOTDIR);
if (name == "."_sv || name == ".."_sv) if (name == "."_sv || name == ".."_sv)
return BAN::Error::from_errno(EINVAL); return BAN::Error::from_errno(EINVAL);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return unlink_impl(name); return unlink_impl(name);
} }
@ -127,6 +137,8 @@ namespace Kernel
LockGuard _(m_mutex); LockGuard _(m_mutex);
if (!mode().iflnk()) if (!mode().iflnk())
return BAN::Error::from_errno(EINVAL); return BAN::Error::from_errno(EINVAL);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return set_link_target_impl(target); return set_link_target_impl(target);
} }
@ -207,6 +219,8 @@ namespace Kernel
LockGuard _(m_mutex); LockGuard _(m_mutex);
if (mode().ifdir()) if (mode().ifdir())
return BAN::Error::from_errno(EISDIR); return BAN::Error::from_errno(EISDIR);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return write_impl(offset, buffer); return write_impl(offset, buffer);
} }
@ -215,6 +229,8 @@ namespace Kernel
LockGuard _(m_mutex); LockGuard _(m_mutex);
if (mode().ifdir()) if (mode().ifdir())
return BAN::Error::from_errno(EISDIR); return BAN::Error::from_errno(EISDIR);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return truncate_impl(size); return truncate_impl(size);
} }
@ -222,18 +238,24 @@ namespace Kernel
{ {
ASSERT((mode & Inode::Mode::TYPE_MASK) == 0); ASSERT((mode & Inode::Mode::TYPE_MASK) == 0);
LockGuard _(m_mutex); LockGuard _(m_mutex);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return chmod_impl(mode); return chmod_impl(mode);
} }
BAN::ErrorOr<void> Inode::chown(uid_t uid, gid_t gid) BAN::ErrorOr<void> Inode::chown(uid_t uid, gid_t gid)
{ {
LockGuard _(m_mutex); LockGuard _(m_mutex);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return chown_impl(uid, gid); return chown_impl(uid, gid);
} }
BAN::ErrorOr<void> Inode::utimens(const timespec times[2]) BAN::ErrorOr<void> Inode::utimens(const timespec times[2])
{ {
LockGuard _(m_mutex); LockGuard _(m_mutex);
if (auto* fs = filesystem(); fs && (fs->flag() & ST_RDONLY))
return BAN::Error::from_errno(EROFS);
return utimens_impl(times); return utimens_impl(times);
} }