Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BAN: StringView::Split() now precomputes number of elements

Browse Source 
We dont have to resize vector on PushBack()'s if we reserve required size
This commit is contained in:
Bananymous
2022-12-20 11:37:28 +02:00
parent d5a068f90c
commit 4c559f50a4
4 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
BAN/BAN/StringView.cpp
View File

@@ -62,9 +62,27 @@ namespace BAN
return result;
}
Vector<StringView> StringView::Split(char delim, bool allow_empties)
ErrorOr<Vector<StringView>> StringView::Split(char delim, bool allow_empties)
{
size_type count = 0;
{
size_type start = 0;
for (size_type i = 0; i < m_size; i++)
{
if (m_data[i] == delim)
{
if (allow_empties || start != i)
count++;
start = i + 1;
}
}
if (start != m_size)
count++;
}
Vector<StringView> result;
TRY(result.Reserve(count));
size_type start = 0;
for (size_type i = 0; i < m_size; i++)
{