Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kernel: Fix remote TLB shootdown for <= 32 pages

Browse Source 
I was modifying the `vaddr` argument while invalidating which lead to
the smp message containing wrong virtual address. This showed up in
really weird bugs from invalid TLB
This commit is contained in:
Bananymous
2026-05-06 15:02:38 +03:00
parent 3ac955714b
commit 443be800b7
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/arch/i686/PageTable.cpp
View File

@@ -343,8 +343,8 @@ namespace Kernel
; ;
else if (pages <= 32 || !s_is_initialized) else if (pages <= 32 || !s_is_initialized)
{ {
for (size_t i = 0; i < pages; i++, vaddr += PAGE_SIZE) for (size_t i = 0; i < pages; i++)
asm volatile("invlpg (%0)" :: "r"(vaddr)); asm volatile("invlpg (%0)" :: "r"(vaddr + i * PAGE_SIZE));
} }
else if (is_userspace || !s_has_pge) else if (is_userspace || !s_has_pge)
{ {

4
kernel/arch/x86_64/PageTable.cpp
View File

@@ -472,8 +472,8 @@ namespace Kernel
; ;
else if (pages <= 32 || !s_is_initialized) else if (pages <= 32 || !s_is_initialized)
{ {
for (size_t i = 0; i < pages; i++, vaddr += PAGE_SIZE) for (size_t i = 0; i < pages; i++)
asm volatile("invlpg (%0)" :: "r"(vaddr)); asm volatile("invlpg (%0)" :: "r"(vaddr + i * PAGE_SIZE));
} }
else if (is_userspace || !s_has_pge) else if (is_userspace || !s_has_pge)
{ {