Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kernel: Collect created AML nodes in add_{named,alias}... 

This makes it harder to miss adding scoped objects. Before I was not
deleting all types of nodes on method return
This commit is contained in:
Bananymous 2025-04-01 22:48:22 +03:00
parent b145c1ab64
commit 3800d5420e
4 changed files with 59 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/include/kernel/ACPI/AML/Namespace.h
View File

@ -31,8 +31,8 @@ namespace Kernel::ACPI::AML
BAN::ErrorOr<Node> evaluate(const Scope& scope, BAN::StringView); BAN::ErrorOr<Node> evaluate(const Scope& scope, BAN::StringView);
// returns empty scope if object already exited // returns empty scope if object already exited
BAN::ErrorOr<Scope> add_named_object(const Scope& scope, const NameString& name_string, Node&& node); BAN::ErrorOr<Scope> add_named_object(ParseContext& context, const NameString& name_string, Node&& node);
BAN::ErrorOr<Scope> add_alias(const Scope& scope, const NameString& name_string, Reference* reference); BAN::ErrorOr<Scope> add_alias(ParseContext& scope, const NameString& name_string, Reference* reference);
BAN::ErrorOr<void> remove_named_object(const Scope& absolute_path); BAN::ErrorOr<void> remove_named_object(const Scope& absolute_path);

28
kernel/kernel/ACPI/AML/Namespace.cpp
View File

@ -53,9 +53,11 @@ namespace Kernel::ACPI::AML
const auto add_predefined_root_namespace = const auto add_predefined_root_namespace =
[](const char* name) -> BAN::ErrorOr<void> [](const char* name) -> BAN::ErrorOr<void>
{ {
ParseContext dummy_context {};
Node predefined {}; Node predefined {};
predefined.type = Node::Type::PredefinedScope; predefined.type = Node::Type::PredefinedScope;
TRY(s_root_namespace.add_named_object({}, TRY(NameString::from_string(name)), BAN::move(predefined))); TRY(s_root_namespace.add_named_object(dummy_context, TRY(NameString::from_string(name)), BAN::move(predefined)));
return {}; return {};
}; };
@ -66,11 +68,13 @@ namespace Kernel::ACPI::AML
TRY(add_predefined_root_namespace("\\_SI_")); TRY(add_predefined_root_namespace("\\_SI_"));
TRY(add_predefined_root_namespace("\\_TZ_")); TRY(add_predefined_root_namespace("\\_TZ_"));
ParseContext dummy_context {};
{ {
Node revision; Node revision;
revision.type = Node::Type::Integer; revision.type = Node::Type::Integer;
revision.as.integer.value = 2; revision.as.integer.value = 2;
TRY(s_root_namespace.add_named_object({}, TRY(NameString::from_string("_REV")), BAN::move(revision))); TRY(s_root_namespace.add_named_object(dummy_context, TRY(NameString::from_string("_REV")), BAN::move(revision)));
} }
{ {
@ -107,7 +111,7 @@ namespace Kernel::ACPI::AML
return result; return result;
}; };
TRY(s_root_namespace.add_named_object({}, osi_string, BAN::move(method))); TRY(s_root_namespace.add_named_object(dummy_context, osi_string, BAN::move(method)));
} }
{ {
@ -120,7 +124,7 @@ namespace Kernel::ACPI::AML
mutex.as.mutex->sync_level = 0; mutex.as.mutex->sync_level = 0;
mutex.as.mutex->global_lock = true; mutex.as.mutex->global_lock = true;
TRY(s_root_namespace.add_named_object({}, gl_string, BAN::move(mutex))); TRY(s_root_namespace.add_named_object(dummy_context, gl_string, BAN::move(mutex)));
} }
return {}; return {};
@ -318,11 +322,11 @@ namespace Kernel::ACPI::AML
return resolved_path; return resolved_path;
} }
BAN::ErrorOr<Scope> Namespace::add_named_object(const Scope& scope, const NameString& name_string, Node&& node) BAN::ErrorOr<Scope> Namespace::add_named_object(ParseContext& context, const NameString& name_string, Node&& node)
{ {
dprintln_if(AML_DUMP_FUNCTION_CALLS, "add_named_object('{}', '{}', {})", scope, name_string, node); dprintln_if(AML_DUMP_FUNCTION_CALLS, "add_named_object('{}', '{}', {})", context.scope, name_string, node);
auto resolved_path = TRY(resolve_path(scope, name_string)); auto resolved_path = TRY(resolve_path(context.scope, name_string));
if (m_named_objects.contains(resolved_path)) if (m_named_objects.contains(resolved_path))
return Scope(); return Scope();
@ -337,14 +341,16 @@ namespace Kernel::ACPI::AML
if (m_has_initialized_namespace && reference->node.type == Node::Type::OpRegion) if (m_has_initialized_namespace && reference->node.type == Node::Type::OpRegion)
(void)opregion_call_reg(resolved_path, reference->node); (void)opregion_call_reg(resolved_path, reference->node);
TRY(context.created_nodes.push_back(TRY(resolved_path.copy())));
return resolved_path; return resolved_path;
} }
BAN::ErrorOr<Scope> Namespace::add_alias(const Scope& scope, const NameString& name_string, Reference* reference) BAN::ErrorOr<Scope> Namespace::add_alias(ParseContext& context, const NameString& name_string, Reference* reference)
{ {
dprintln_if(AML_DUMP_FUNCTION_CALLS, "add_alias('{}', '{}', {})", scope, name_string, reference->node); dprintln_if(AML_DUMP_FUNCTION_CALLS, "add_alias('{}', '{}', {})", context.scope, name_string, reference->node);
auto resolved_path = TRY(resolve_path(scope, name_string)); auto resolved_path = TRY(resolve_path(context.scope, name_string));
if (m_named_objects.contains(resolved_path)) if (m_named_objects.contains(resolved_path))
return Scope(); return Scope();
@ -354,6 +360,8 @@ namespace Kernel::ACPI::AML
TRY(m_named_objects.insert(TRY(resolved_path.copy()), reference)); TRY(m_named_objects.insert(TRY(resolved_path.copy()), reference));
TRY(m_aliases.insert(TRY(resolved_path.copy()))); TRY(m_aliases.insert(TRY(resolved_path.copy())));
TRY(context.created_nodes.push_back(TRY(resolved_path.copy())));
return resolved_path; return resolved_path;
} }

49
kernel/kernel/ACPI/AML/Node.cpp
View File

@ -1201,7 +1201,12 @@ namespace Kernel::ACPI::AML
buffer_field.as.buffer_field.bit_count = bit_count; buffer_field.as.buffer_field.bit_count = bit_count;
buffer_field.as.buffer_field.bit_offset = index_in_bits ? index_node.as.integer.value : index_node.as.integer.value * 8; buffer_field.as.buffer_field.bit_offset = index_in_bits ? index_node.as.integer.value : index_node.as.integer.value * 8;
TRY(Namespace::root_namespace().add_named_object(context.scope, field_name_string, BAN::move(buffer_field))); auto absolte_path = TRY(Namespace::root_namespace().add_named_object(context, field_name_string, BAN::move(buffer_field)));
if (absolte_path.parts.empty())
{
dwarnln("Could not add Buffer Field '{}'.'{}' to namespace", context.scope, field_name_string);
return {};
}
return {}; return {};
} }
@ -1695,7 +1700,7 @@ namespace Kernel::ACPI::AML
return {}; return {};
} }
TRY(Namespace::root_namespace().add_alias(context.scope, object_name_string, source_ref)); TRY(Namespace::root_namespace().add_alias(context, object_name_string, source_ref));
return {}; return {};
} }
@ -1711,9 +1716,12 @@ namespace Kernel::ACPI::AML
auto name_string = TRY(parse_name_string(context.aml_data)); auto name_string = TRY(parse_name_string(context.aml_data));
auto object = TRY(parse_node(context)); auto object = TRY(parse_node(context));
auto path = TRY(Namespace::root_namespace().add_named_object(context.scope, name_string, BAN::move(object))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, name_string, BAN::move(object)));
if (!path.parts.empty()) if (absolute_path.parts.empty())
TRY(context.created_nodes.push_back(BAN::move(path))); {
dwarnln("Could not add Name '{}'.'{}' to namespace", context.scope, name_string);
return {};
}
return {}; return {};
} }
@ -1892,10 +1900,10 @@ namespace Kernel::ACPI::AML
event_node.type = Node::Type::Event; event_node.type = Node::Type::Event;
event_node.as.event.signal_count = 0; event_node.as.event.signal_count = 0;
auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context.scope, event_name, BAN::move(event_node))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, event_name, BAN::move(event_node)));
if (absolute_path.parts.empty()) if (absolute_path.parts.empty())
{ {
dwarnln("Could not add Device '{}'.'{}' to namespace", context.scope, event_name); dwarnln("Could not add Event '{}'.'{}' to namespace", context.scope, event_name);
return {}; return {};
} }
@ -2045,7 +2053,7 @@ namespace Kernel::ACPI::AML
Node device_node {}; Node device_node {};
device_node.type = Node::Type::Device; device_node.type = Node::Type::Device;
auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context.scope, device_name, BAN::move(device_node))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, device_name, BAN::move(device_node)));
if (absolute_path.parts.empty()) if (absolute_path.parts.empty())
{ {
dwarnln("Could not add Device '{}'.'{}' to namespace", context.scope, device_name); dwarnln("Could not add Device '{}'.'{}' to namespace", context.scope, device_name);
@ -2076,7 +2084,7 @@ namespace Kernel::ACPI::AML
Node processor_node {}; Node processor_node {};
processor_node.type = Node::Type::Processor; processor_node.type = Node::Type::Processor;
auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context.scope, processor_name, BAN::move(processor_node))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, processor_name, BAN::move(processor_node)));
if (absolute_path.parts.empty()) if (absolute_path.parts.empty())
{ {
dwarnln("Could not add Processor '{}'.'{}' to namespace", context.scope, processor_name); dwarnln("Could not add Processor '{}'.'{}' to namespace", context.scope, processor_name);
@ -2107,10 +2115,10 @@ namespace Kernel::ACPI::AML
Node power_resource_node {}; Node power_resource_node {};
power_resource_node.type = Node::Type::PowerResource; power_resource_node.type = Node::Type::PowerResource;
auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context.scope, power_resource_name, BAN::move(power_resource_node))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, power_resource_name, BAN::move(power_resource_node)));
if (absolute_path.parts.empty()) if (absolute_path.parts.empty())
{ {
dwarnln("Could not add Processor '{}'.'{}' to namespace", context.scope, power_resource_name); dwarnln("Could not add Power Resource '{}'.'{}' to namespace", context.scope, power_resource_name);
return {}; return {};
} }
@ -2133,7 +2141,7 @@ namespace Kernel::ACPI::AML
Node thermal_zone_node {}; Node thermal_zone_node {};
thermal_zone_node.type = Node::Type::ThermalZone; thermal_zone_node.type = Node::Type::ThermalZone;
auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context.scope, thermal_zone_name, BAN::move(thermal_zone_node))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, thermal_zone_name, BAN::move(thermal_zone_node)));
if (absolute_path.parts.empty()) if (absolute_path.parts.empty())
{ {
dwarnln("Could not add Thermal Zone '{}'.'{}' to namespace", context.scope, thermal_zone_name); dwarnln("Could not add Thermal Zone '{}'.'{}' to namespace", context.scope, thermal_zone_name);
@ -2173,7 +2181,13 @@ namespace Kernel::ACPI::AML
mutex.as.mutex->sync_level = mutex_flags; mutex.as.mutex->sync_level = mutex_flags;
mutex.as.mutex->global_lock = false; mutex.as.mutex->global_lock = false;
TRY(Namespace::root_namespace().add_named_object(context.scope, mutex_name, BAN::move(mutex))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, mutex_name, BAN::move(mutex)));
if (absolute_path.parts.empty())
{
dwarnln("Could not add Mutex '{}'.'{}' to namespace", context.scope, mutex);
return {};
}
return {}; return {};
} }
@ -2321,9 +2335,12 @@ namespace Kernel::ACPI::AML
method_node.as.method.mutex->ref_count = 1; method_node.as.method.mutex->ref_count = 1;
} }
auto path = TRY(Namespace::root_namespace().add_named_object(context.scope, method_name, BAN::move(method_node))); auto absolute_path = TRY(Namespace::root_namespace().add_named_object(context, method_name, BAN::move(method_node)));
if (!path.parts.empty()) if (absolute_path.parts.empty())
TRY(context.created_nodes.push_back(BAN::move(path))); {
dwarnln("Could not add Method '{}'.'{}' to namespace", context.scope, method_name);
return {};
}
return {}; return {};
} }

12
kernel/kernel/ACPI/AML/OpRegion.cpp
View File

@ -92,13 +92,13 @@ namespace Kernel::ACPI::AML
opregion.as.opregion.offset = region_offset.as.integer.value; opregion.as.opregion.offset = region_offset.as.integer.value;
opregion.as.opregion.length = region_length.as.integer.value; opregion.as.opregion.length = region_length.as.integer.value;
TRY(Namespace::root_namespace().add_named_object(context.scope, region_name, BAN::move(opregion))); TRY(Namespace::root_namespace().add_named_object(context, region_name, BAN::move(opregion)));
return {}; return {};
} }
template<typename F> template<typename F>
static BAN::ErrorOr<void> parse_field_list(const Scope& scope, BAN::ConstByteSpan field_list_pkg, const F& create_element, uint8_t field_flags) static BAN::ErrorOr<void> parse_field_list(ParseContext& context, BAN::ConstByteSpan field_list_pkg, const F& create_element, uint8_t field_flags)
{ {
uint64_t offset = 0; uint64_t offset = 0;
while (!field_list_pkg.empty()) while (!field_list_pkg.empty())
@ -144,7 +144,7 @@ namespace Kernel::ACPI::AML
Node field_node = create_element(offset, field_length, field_flags); Node field_node = create_element(offset, field_length, field_flags);
TRY(Namespace::root_namespace().add_named_object(scope, field_name, BAN::move(field_node))); TRY(Namespace::root_namespace().add_named_object(context, field_name, BAN::move(field_node)));
offset += field_length; offset += field_length;
@ -197,7 +197,7 @@ namespace Kernel::ACPI::AML
return field_node; return field_node;
}; };
TRY(parse_field_list(context.scope, field_pkg, create_element, default_flags)); TRY(parse_field_list(context, field_pkg, create_element, default_flags));
return {}; return {};
} }
@ -260,7 +260,7 @@ namespace Kernel::ACPI::AML
return field_node; return field_node;
}; };
TRY(parse_field_list(context.scope, field_pkg, create_element, default_flags)); TRY(parse_field_list(context, field_pkg, create_element, default_flags));
return {}; return {};
} }
@ -331,7 +331,7 @@ namespace Kernel::ACPI::AML
return field_node; return field_node;
}; };
TRY(parse_field_list(context.scope, field_pkg, create_element, default_flags)); TRY(parse_field_list(context, field_pkg, create_element, default_flags));
return {}; return {};
} }