Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Kernel: Fix termios and enter key handling

Browse Source 
Enter key now produces expected \r which gets converted to \n by default
by the ICRNL input flag.

Also input flags are now handled always, not just when ICANON is set.
I don't know why I though ICANON should disable input handling
This commit is contained in:
Bananymous
2025-08-19 04:03:50 +03:00
parent 95b353dae5
commit 34bdcb12e5
4 changed files with 14 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
kernel/kernel/Terminal/TTY.cpp
View File

@@ -243,19 +243,14 @@ namespace Kernel
LockGuard _(m_mutex);
if (m_termios.c_lflag & ICANON)
{
if ((m_termios.c_iflag & ISTRIP))
ch &= 0x7F;
if ((m_termios.c_iflag & IGNCR) && ch == CR)
return;
uint8_t conv = ch;
if ((m_termios.c_iflag & ICRNL) && ch == CR)
conv = NL;
if ((m_termios.c_iflag & INLCR) && ch == NL)
conv = CR;
ch = conv;
}
if ((m_termios.c_iflag & ISTRIP))
ch &= 0x7F;
if ((m_termios.c_iflag & IGNCR) && ch == CR)
return;
if ((m_termios.c_iflag & ICRNL) && ch == CR)
ch = NL;
else if ((m_termios.c_iflag & INLCR) && ch == NL)
ch = CR;
if (m_termios.c_lflag & ISIG)
{
@@ -298,11 +293,10 @@ namespace Kernel
should_flush = true;
}
if (ch == NL || ch == m_termios.c_cc[VEOL])
if (ch == NL || ch == CR || ch == m_termios.c_cc[VEOL])
{
should_flush = true;
force_echo = !!(m_termios.c_lflag & ECHONL);
ch = NL;
}
}