Bananymous
/
banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BAN: Fix all emplace functions to actually do perfect forwarding

This commit is contained in:
Bananymous 2023-02-01 21:41:51 +02:00
parent 99cf1c0330
commit 0d2d6e5348
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
BAN/include/BAN/LinkedList.h
View File

@ -33,9 +33,9 @@ namespace BAN
[[nodiscard]] ErrorOr<void> insert(const_iterator, const T&); [[nodiscard]] ErrorOr<void> insert(const_iterator, const T&);
[[nodiscard]] ErrorOr<void> insert(const_iterator, T&&); [[nodiscard]] ErrorOr<void> insert(const_iterator, T&&);
template<typename... Args> template<typename... Args>
[[nodiscard]] ErrorOr<void> emplace_back(Args...); [[nodiscard]] ErrorOr<void> emplace_back(Args&&...);
template<typename... Args> template<typename... Args>
[[nodiscard]] ErrorOr<void> emplace(const_iterator, Args...); [[nodiscard]] ErrorOr<void> emplace(const_iterator, Args&&...);
void pop_back(); void pop_back();
void remove(const_iterator); void remove(const_iterator);
@ -204,14 +204,14 @@ namespace BAN
template<typename T> template<typename T>
template<typename... Args> template<typename... Args>
ErrorOr<void> LinkedList<T>::emplace_back(Args... args) ErrorOr<void> LinkedList<T>::emplace_back(Args&&... args)
{ {
return emplace(end(), forward<Args>(args)...); return emplace(end(), forward<Args>(args)...);
} }
template<typename T> template<typename T>
template<typename... Args> template<typename... Args>
ErrorOr<void> LinkedList<T>::emplace(const_iterator iter, Args... args) ErrorOr<void> LinkedList<T>::emplace(const_iterator iter, Args&&... args)
{ {
Node* next = iter.m_past_end ? nullptr : iter.m_current; Node* next = iter.m_past_end ? nullptr : iter.m_current;
Node* prev = next ? next->prev : m_last; Node* prev = next ? next->prev : m_last;

4
BAN/include/BAN/Queue.h
View File

@ -27,7 +27,7 @@ namespace BAN
[[nodiscard]] ErrorOr<void> push(T&&); [[nodiscard]] ErrorOr<void> push(T&&);
[[nodiscard]] ErrorOr<void> push(const T&); [[nodiscard]] ErrorOr<void> push(const T&);
template<typename... Args> template<typename... Args>
[[nodiscard]] ErrorOr<void> emplace(Args...); [[nodiscard]] ErrorOr<void> emplace(Args&&...);
void pop(); void pop();
void clear(); void clear();
@ -120,7 +120,7 @@ namespace BAN
template<typename T> template<typename T>
template<typename... Args> template<typename... Args>
ErrorOr<void> Queue<T>::emplace(Args... args) ErrorOr<void> Queue<T>::emplace(Args&&... args)
{ {
TRY(ensure_capacity(m_size + 1)); TRY(ensure_capacity(m_size + 1));
new (address_of(m_size)) T(forward<Args>(args)...); new (address_of(m_size)) T(forward<Args>(args)...);

8
BAN/include/BAN/Vector.h
View File

@ -73,9 +73,9 @@ namespace BAN
[[nodiscard]] ErrorOr<void> push_back(T&&); [[nodiscard]] ErrorOr<void> push_back(T&&);
[[nodiscard]] ErrorOr<void> push_back(const T&); [[nodiscard]] ErrorOr<void> push_back(const T&);
template<typename... Args> template<typename... Args>
[[nodiscard]] ErrorOr<void> emplace_back(Args...); [[nodiscard]] ErrorOr<void> emplace_back(Args&&...);
template<typename... Args> template<typename... Args>
[[nodiscard]] ErrorOr<void> emplace(size_type, Args...); [[nodiscard]] ErrorOr<void> emplace(size_type, Args&&...);
[[nodiscard]] ErrorOr<void> insert(size_type, T&&); [[nodiscard]] ErrorOr<void> insert(size_type, T&&);
[[nodiscard]] ErrorOr<void> insert(size_type, const T&); [[nodiscard]] ErrorOr<void> insert(size_type, const T&);
@ -187,7 +187,7 @@ namespace BAN
template<typename T> template<typename T>
template<typename... Args> template<typename... Args>
ErrorOr<void> Vector<T>::emplace_back(Args... args) ErrorOr<void> Vector<T>::emplace_back(Args&&... args)
{ {
TRY(ensure_capacity(m_size + 1)); TRY(ensure_capacity(m_size + 1));
new (address_of(m_size)) T(forward<Args>(args)...); new (address_of(m_size)) T(forward<Args>(args)...);
@ -197,7 +197,7 @@ namespace BAN
template<typename T> template<typename T>
template<typename... Args> template<typename... Args>
ErrorOr<void> Vector<T>::emplace(size_type index, Args... args) ErrorOr<void> Vector<T>::emplace(size_type index, Args&&... args)
{ {
ASSERT(index <= m_size); ASSERT(index <= m_size);
TRY(ensure_capacity(m_size + 1)); TRY(ensure_capacity(m_size + 1));