Bananymous/banan-os
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BAN: Fix all emplace functions to actually do perfect forwarding

Browse Source
This commit is contained in:
Bananymous
2023-02-01 21:41:51 +02:00
parent 99cf1c0330
commit 0d2d6e5348
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
BAN/include/BAN/LinkedList.h
View File

@@ -33,9 +33,9 @@ namespace BAN
[[nodiscard]] ErrorOr<void> insert(const_iterator, const T&);
[[nodiscard]] ErrorOr<void> insert(const_iterator, T&&);
template<typename... Args>
[[nodiscard]] ErrorOr<void> emplace_back(Args...);
[[nodiscard]] ErrorOr<void> emplace_back(Args&&...);
template<typename... Args>
[[nodiscard]] ErrorOr<void> emplace(const_iterator, Args...);
[[nodiscard]] ErrorOr<void> emplace(const_iterator, Args&&...);
void pop_back();
void remove(const_iterator);
@@ -204,14 +204,14 @@ namespace BAN
template<typename T>
template<typename... Args>
ErrorOr<void> LinkedList<T>::emplace_back(Args... args)
ErrorOr<void> LinkedList<T>::emplace_back(Args&&... args)
{
return emplace(end(), forward<Args>(args)...);
}
template<typename T>
template<typename... Args>
ErrorOr<void> LinkedList<T>::emplace(const_iterator iter, Args... args)
ErrorOr<void> LinkedList<T>::emplace(const_iterator iter, Args&&... args)
{
Node* next = iter.m_past_end ? nullptr : iter.m_current;
Node* prev = next ? next->prev : m_last;