Sinipelto/banan-os
1
0
Fork 0
forked from Bananymous/banan-os
Code Pull Requests Activity

Kernel: cast between inheritance with static_cast

Browse Source 
using reinterpret_cast is not a good idea. preferably we would use
dynamic_cast, but that is not possible since kernel is compiled with
-fno-rtti.
This commit is contained in:
Bananymous
2023-11-29 20:50:57 +02:00
parent 327b330338
commit fdb6dc94ba
4 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/kernel/FS/ProcFS/FileSystem.cpp
View File

@@ -31,7 +31,7 @@ namespace Kernel
{
auto path = BAN::String::formatted("{}", process.pid());
auto inode = TRY(ProcPidInode::create_new(process, *this, 0555, process.credentials().ruid(), process.credentials().rgid()));
TRY(reinterpret_cast<TmpDirectoryInode*>(root_inode().ptr())->link_inode(*inode, path));
TRY(static_cast<TmpDirectoryInode*>(root_inode().ptr())->link_inode(*inode, path));
return {};
}
@@ -40,7 +40,7 @@ namespace Kernel
auto path = BAN::String::formatted("{}", process.pid());
auto inode = MUST(root_inode()->find_inode(path));
reinterpret_cast<ProcPidInode*>(inode.ptr())->cleanup();
static_cast<ProcPidInode*>(inode.ptr())->cleanup();
if (auto ret = root_inode()->unlink(path); ret.is_error())
dwarnln("{}", ret.error());