Sinipelto/banan-os
1
0
Fork 0
forked from Bananymous/banan-os
Code Pull Requests Activity

Kernel: Fix TCP accept bind address

Browse Source 
I was accidentally binding the new socket to the target address instead
of the listening socket's address
This commit is contained in:
Bananymous
2026-01-24 00:31:57 +02:00
parent 3d2362cb5f
commit ba6229b92d
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/kernel/Networking/TCPSocket.cpp
View File

@@ -95,8 +95,8 @@ namespace Kernel
} }
return_inode->m_mutex.lock(); return_inode->m_mutex.lock();
memcpy(&return_inode->m_address, &connection.target.address, connection.target.address_len); memcpy(&return_inode->m_address, &m_address, m_address_len);
return_inode->m_address_len = connection.target.address_len; return_inode->m_address_len = m_address_len;
return_inode->m_listen_parent = this; return_inode->m_listen_parent = this;
return_inode->m_connection_info.emplace(connection.target); return_inode->m_connection_info.emplace(connection.target);
return_inode->m_recv_window.start_seq = connection.target_start_seq; return_inode->m_recv_window.start_seq = connection.target_start_seq;
@@ -562,6 +562,7 @@ namespace Kernel
)); ));
epoll_notify(EPOLLIN); epoll_notify(EPOLLIN);
m_thread_blocker.unblock();
} }
} }
else else
@@ -573,14 +574,11 @@ namespace Kernel
break; break;
} }
auto socket = it->value; auto socket = it->value;
m_mutex.unlock(); m_mutex.unlock();
socket->receive_packet(buffer, sender, sender_len); socket->receive_packet(buffer, sender, sender_len);
m_mutex.lock(); m_mutex.lock();
return;
} }
break; return;
case State::Established: case State::Established:
check_payload = true; check_payload = true;
if (!(header.flags & FIN)) if (!(header.flags & FIN))