Sinipelto
/
banan-os
forked from Bananymous/banan-os
1
0
Fork 0
Code Pull Requests Activity

Kernel: Cleanup AML code

This commit is contained in:
Bananymous 2025-01-17 16:20:00 +02:00
parent 80ce9d546a
commit 82978da5e3
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
kernel/kernel/ACPI/AML/Node.cpp
View File

@ -283,16 +283,14 @@ namespace Kernel::ACPI::AML
switch (opcode) switch (opcode)
{ {
case AML::Byte::PackageOp: case AML::Byte::PackageOp:
if (context.aml_data.empty())
return BAN::Error::from_errno(ENODATA);
num_elements = context.aml_data[0]; num_elements = context.aml_data[0];
context.aml_data = context.aml_data.slice(1); context.aml_data = context.aml_data.slice(1);
break; break;
case AML::Byte::VarPackageOp: case AML::Byte::VarPackageOp:
{ num_elements = TRY(convert_node(TRY(parse_node(context)), ConvInteger, sizeof(uint64_t))).as.integer.value;
auto node = TRY(parse_node(context));
node = TRY(convert_node(BAN::move(node), ConvInteger, sizeof(uint64_t)));
num_elements = node.as.integer.value;
break; break;
}
default: default:
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
} }
@ -1868,10 +1866,13 @@ namespace Kernel::ACPI::AML
ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::NotifyOp); ASSERT(static_cast<AML::Byte>(context.aml_data[0]) == AML::Byte::NotifyOp);
context.aml_data = context.aml_data.slice(1); context.aml_data = context.aml_data.slice(1);
auto object = TRY(parse_super_name(context, true)); auto [obj_path, obj_ref] = TRY(parse_super_name(context, true));
auto value = TRY(convert_node(TRY(parse_node(context)), ConvInteger, sizeof(uint64_t))); auto value = TRY(convert_node(TRY(parse_node(context)), ConvInteger, sizeof(uint64_t)));
dwarnln("TODO: handle notify({}, {})", object.elem2->node, value); if (obj_ref == nullptr)
return {};
dwarnln("TODO: handle notify({}, {})", obj_ref->node, value);
return {}; return {};
} }