Sinipelto/banan-os
1
0
Fork 0
forked from Bananymous/banan-os
Code Pull Requests Activity

Kernel: Ignore SET_PROTOCOL(1) errors on HID devices

Browse Source 
One of my USB mice is a boot protocol device but stalls on SET_PROTOCOL
request. USB HID is supposed to be in report protocol on initialization
so an error *should* not be an issue
This commit is contained in:
Bananymous
2026-08-22 11:57:19 +03:00
parent 6a7c1c1281
commit 4b7d90f939
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kernel/kernel/USB/HID/HIDDriver.cpp
+10 -8
View File
@@ -14,6 +14,7 @@ namespace Kernel
enum HIDRequest : uint8_t enum HIDRequest : uint8_t
{ {
GET_PROTOCOL = 0x03,
SET_PROTOCOL = 0x0B, SET_PROTOCOL = 0x0B,
}; };
@@ -84,7 +85,7 @@ namespace Kernel
BAN::ErrorOr<void> USBHIDDriver::initialize() BAN::ErrorOr<void> USBHIDDriver::initialize()
{ {
auto dma_buffer = TRY(DMARegion::create(1024)); auto dma_buffer = TRY(DMARegion::create(1024, PageTable::MemoryType::Normal));
ASSERT(static_cast<USB::InterfaceBaseClass>(m_interface.descriptor.bInterfaceClass) == USB::InterfaceBaseClass::HID); ASSERT(static_cast<USB::InterfaceBaseClass>(m_interface.descriptor.bInterfaceClass) == USB::InterfaceBaseClass::HID);
@@ -119,13 +120,14 @@ namespace Kernel
// If this device supports boot protocol, make sure it is not used // If this device supports boot protocol, make sure it is not used
if (m_interface.descriptor.bInterfaceSubClass == 0x01) if (m_interface.descriptor.bInterfaceSubClass == 0x01)
{ {
USBDeviceRequest request; const auto request = USBDeviceRequest {
request.bmRequestType = USB::RequestType::HostToDevice | USB::RequestType::Class | USB::RequestType::Interface; .bmRequestType = USB::RequestType::HostToDevice | USB::RequestType::Class | USB::RequestType::Interface,
request.bRequest = HIDRequest::SET_PROTOCOL; .bRequest = HIDRequest::SET_PROTOCOL,
request.wValue = 1; // report protocol .wValue = 1, // report protocol
request.wIndex = m_interface.descriptor.bInterfaceNumber; .wIndex = m_interface.descriptor.bInterfaceNumber,
request.wLength = 0; .wLength = 0,
TRY(m_device.send_request(request, 0)); };
(void)m_device.send_request(request, 0);
} }
const auto& hid_descriptor = *reinterpret_cast<const HIDDescriptor*>(m_interface.misc_descriptors[hid_descriptor_index].data()); const auto& hid_descriptor = *reinterpret_cast<const HIDDescriptor*>(m_interface.misc_descriptors[hid_descriptor_index].data());