Sinipelto
/
banan-os
forked from Bananymous/banan-os
1
0
Fork 0
Code Pull Requests Activity

Kernel: Fix default ignored signals 

SIGWINCH and SIGCANCEL ended up interrupting functions even when they
were marked as SIG_DFL. Now resizing the userspace terminal emulator
does not get interrupted!
This commit is contained in:
Bananymous 2025-08-18 13:36:59 +03:00
parent 0f52f49188
commit 32d7f429f8
1 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
kernel/kernel/Thread.cpp
View File

@ -69,6 +69,20 @@ namespace Kernel
s_default_sse_storage_initialized = true; s_default_sse_storage_initialized = true;
} }
static bool is_default_ignored_signal(int signal)
{
switch (signal)
{
case SIGCHLD:
case SIGURG:
case SIGWINCH:
case SIGCANCEL:
return true;
default:
return false;
}
}
BAN::ErrorOr<Thread*> Thread::create_kernel(entry_t entry, void* data) BAN::ErrorOr<Thread*> Thread::create_kernel(entry_t entry, void* data)
{ {
// Create the thread object // Create the thread object
@ -467,7 +481,7 @@ namespace Kernel
} }
if (signal_handler == (vaddr_t)SIG_IGN) if (signal_handler == (vaddr_t)SIG_IGN)
continue; continue;
if (signal_handler == (vaddr_t)SIG_DFL && (i == SIGCHLD || i == SIGURG)) if (signal_handler == (vaddr_t)SIG_DFL && is_default_ignored_signal(i))
continue; continue;
return true; return true;
} }
@ -582,14 +596,8 @@ namespace Kernel
process().exit(128 + signal, signal); process().exit(128 + signal, signal);
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
// Ignore the signal
case SIGCHLD:
case SIGURG:
case SIGWINCH:
case SIGCANCEL:
break;
// Stop the process: // Stop the process:
case SIGSTOP:
case SIGTSTP: case SIGTSTP:
case SIGTTIN: case SIGTTIN:
case SIGTTOU: case SIGTTOU:
@ -598,6 +606,11 @@ namespace Kernel
// Continue the process, if it is stopped; otherwise, ignore the signal. // Continue the process, if it is stopped; otherwise, ignore the signal.
case SIGCONT: case SIGCONT:
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
default:
if (is_default_ignored_signal(signal))
break;
panic("Executing unhandled signal {}", signal);
} }
} }
@ -619,7 +632,7 @@ namespace Kernel
} }
if (signal_handler == (vaddr_t)SIG_IGN) if (signal_handler == (vaddr_t)SIG_IGN)
return false; return false;
if (signal_handler == (vaddr_t)SIG_DFL && (signal == SIGCHLD || signal == SIGURG)) if (signal_handler == (vaddr_t)SIG_DFL && is_default_ignored_signal(signal))
return false; return false;
} }
uint64_t mask = 1ull << signal; uint64_t mask = 1ull << signal;