Sinipelto
/
banan-os
forked from Bananymous/banan-os
1
0
Fork 0
Code Pull Requests Activity

BAN: Formatter now passes arguments as const references 

We used to take everything by value, since I wasn't sure if I wanted
to overload bigger types
This commit is contained in:
Bananymous 2022-12-13 20:43:43 +02:00
parent cb6dee9d91
commit d806778a6d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
BAN/include/BAN/Formatter.h
View File

@ -12,13 +12,13 @@ namespace BAN::Formatter
static void print(const char* format); static void print(const char* format);
template<void(*PUTC_LIKE)(char), typename Arg, typename... Args> template<void(*PUTC_LIKE)(char), typename Arg, typename... Args>
static void print(const char* format, Arg arg, Args... args); static void print(const char* format, const Arg& arg, const Args&... args);
template<void(*PUTC_LIKE)(char), typename... Args> template<void(*PUTC_LIKE)(char), typename... Args>
static void println(const char* format = "", Args... args); static void println(const char* format = "", const Args&... args);
template<void(*PUTC_LIKE)(char), typename T> template<void(*PUTC_LIKE)(char), typename T>
static size_t print_argument(const char* format, T arg); static size_t print_argument(const char* format, const T& arg);
template<void(*PUTC_LIKE)(char), typename T> template<void(*PUTC_LIKE)(char), typename T>
static void print_argument_impl(T value, const ValueFormat& format); static void print_argument_impl(T value, const ValueFormat& format);
@ -49,7 +49,7 @@ namespace BAN::Formatter
} }
template<void(*PUTC_LIKE)(char), typename Arg, typename... Args> template<void(*PUTC_LIKE)(char), typename Arg, typename... Args>
void print(const char* format, Arg arg, Args... args) void print(const char* format, const Arg& arg, const Args&... args)
{ {
while (*format && *format != '{') while (*format && *format != '{')
{ {
@ -67,14 +67,14 @@ namespace BAN::Formatter
} }
template<void(*PUTC_LIKE)(char), typename... Args> template<void(*PUTC_LIKE)(char), typename... Args>
void println(const char* format, Args... args) void println(const char* format, const Args&... args)
{ {
print<PUTC_LIKE>(format, args...); print<PUTC_LIKE>(format, args...);
PUTC_LIKE('\n'); PUTC_LIKE('\n');
} }
template<void(*PUTC_LIKE)(char), typename Arg> template<void(*PUTC_LIKE)(char), typename Arg>
size_t print_argument(const char* format, Arg argument) size_t print_argument(const char* format, const Arg& argument)
{ {
ValueFormat value_format; ValueFormat value_format;