diff --git a/BAN/include/BAN/Errors.h b/BAN/include/BAN/Errors.h index 3139b85dd..af29338c2 100644 --- a/BAN/include/BAN/Errors.h +++ b/BAN/include/BAN/Errors.h @@ -38,7 +38,7 @@ namespace BAN }; template - class ErrorOr + class [[nodiscard]] ErrorOr { public: ErrorOr(const T& value) : m_has_error(false) { m_data = (void*)new T(value); } @@ -56,7 +56,7 @@ namespace BAN }; template<> - class ErrorOr + class [[nodiscard]] ErrorOr { public: ErrorOr() { } diff --git a/BAN/include/BAN/HashSet.h b/BAN/include/BAN/HashSet.h index 40517f84f..6b435a374 100644 --- a/BAN/include/BAN/HashSet.h +++ b/BAN/include/BAN/HashSet.h @@ -28,8 +28,8 @@ namespace BAN HashSet& operator=(const HashSet&); HashSet& operator=(HashSet&&); - [[nodiscard]] ErrorOr insert(const T&); - [[nodiscard]] ErrorOr insert(T&&); + ErrorOr insert(const T&); + ErrorOr insert(T&&); void remove(const T&); void clear(); @@ -42,7 +42,7 @@ namespace BAN bool empty() const; private: - [[nodiscard]] ErrorOr rebucket(size_type); + ErrorOr rebucket(size_type); Vector& get_bucket(const T&); const Vector& get_bucket(const T&) const; diff --git a/BAN/include/BAN/LinkedList.h b/BAN/include/BAN/LinkedList.h index 53eae21e8..bac44b88a 100644 --- a/BAN/include/BAN/LinkedList.h +++ b/BAN/include/BAN/LinkedList.h @@ -28,14 +28,14 @@ namespace BAN LinkedList& operator=(const LinkedList&); LinkedList& operator=(LinkedList&&); - [[nodiscard]] ErrorOr push_back(const T&); - [[nodiscard]] ErrorOr push_back(T&&); - [[nodiscard]] ErrorOr insert(iterator, const T&); - [[nodiscard]] ErrorOr insert(iterator, T&&); + ErrorOr push_back(const T&); + ErrorOr push_back(T&&); + ErrorOr insert(iterator, const T&); + ErrorOr insert(iterator, T&&); template - [[nodiscard]] ErrorOr emplace_back(Args&&...); + ErrorOr emplace_back(Args&&...); template - [[nodiscard]] ErrorOr emplace(iterator, Args&&...); + ErrorOr emplace(iterator, Args&&...); void pop_back(); void remove(iterator); @@ -64,7 +64,7 @@ namespace BAN Node* prev; }; - [[nodiscard]] ErrorOr allocate_node() const; + ErrorOr allocate_node() const; Node* m_data = nullptr; Node* m_last = nullptr; diff --git a/BAN/include/BAN/Queue.h b/BAN/include/BAN/Queue.h index 1a9f95ab4..51e221bd5 100644 --- a/BAN/include/BAN/Queue.h +++ b/BAN/include/BAN/Queue.h @@ -24,10 +24,10 @@ namespace BAN Queue& operator=(Queue&&); Queue& operator=(const Queue&); - [[nodiscard]] ErrorOr push(T&&); - [[nodiscard]] ErrorOr push(const T&); + ErrorOr push(T&&); + ErrorOr push(const T&); template - [[nodiscard]] ErrorOr emplace(Args&&...); + ErrorOr emplace(Args&&...); void pop(); void clear(); @@ -39,7 +39,7 @@ namespace BAN T& front(); private: - [[nodiscard]] ErrorOr ensure_capacity(size_type size); + ErrorOr ensure_capacity(size_type size); private: T* m_data = nullptr; diff --git a/BAN/include/BAN/String.h b/BAN/include/BAN/String.h index 93f3910c1..fc3d993e7 100644 --- a/BAN/include/BAN/String.h +++ b/BAN/include/BAN/String.h @@ -25,11 +25,11 @@ namespace BAN String& operator=(String&&); String& operator=(StringView); - [[nodiscard]] ErrorOr push_back(char); - [[nodiscard]] ErrorOr insert(char, size_type); - [[nodiscard]] ErrorOr insert(StringView, size_type); - [[nodiscard]] ErrorOr append(StringView); - [[nodiscard]] ErrorOr append(const String&); + ErrorOr push_back(char); + ErrorOr insert(char, size_type); + ErrorOr insert(StringView, size_type); + ErrorOr append(StringView); + ErrorOr append(const String&); void pop_back(); void remove(size_type); @@ -44,8 +44,8 @@ namespace BAN bool operator==(StringView) const; bool operator==(const char*) const; - [[nodiscard]] ErrorOr resize(size_type, char = '\0'); - [[nodiscard]] ErrorOr reserve(size_type); + ErrorOr resize(size_type, char = '\0'); + ErrorOr reserve(size_type); StringView sv() const; @@ -56,9 +56,9 @@ namespace BAN const char* data() const; private: - [[nodiscard]] ErrorOr ensure_capacity(size_type); + ErrorOr ensure_capacity(size_type); - [[nodiscard]] ErrorOr copy_impl(StringView); + ErrorOr copy_impl(StringView); void move_impl(String&&); private: diff --git a/BAN/include/BAN/StringView.h b/BAN/include/BAN/StringView.h index 83e8913c7..acdcbbca6 100644 --- a/BAN/include/BAN/StringView.h +++ b/BAN/include/BAN/StringView.h @@ -24,8 +24,8 @@ namespace BAN StringView substring(size_type, size_type = -1) const; - [[nodiscard]] ErrorOr> split(char, bool = false); - [[nodiscard]] ErrorOr> split(bool(*comp)(char), bool = false); + ErrorOr> split(char, bool = false); + ErrorOr> split(bool(*comp)(char), bool = false); char back() const; char front() const; diff --git a/BAN/include/BAN/Vector.h b/BAN/include/BAN/Vector.h index 66defc61c..5aa89739d 100644 --- a/BAN/include/BAN/Vector.h +++ b/BAN/include/BAN/Vector.h @@ -31,14 +31,14 @@ namespace BAN Vector& operator=(Vector&&); Vector& operator=(const Vector&); - [[nodiscard]] ErrorOr push_back(T&&); - [[nodiscard]] ErrorOr push_back(const T&); + ErrorOr push_back(T&&); + ErrorOr push_back(const T&); template - [[nodiscard]] ErrorOr emplace_back(Args&&...); + ErrorOr emplace_back(Args&&...); template - [[nodiscard]] ErrorOr emplace(size_type, Args&&...); - [[nodiscard]] ErrorOr insert(size_type, T&&); - [[nodiscard]] ErrorOr insert(size_type, const T&); + ErrorOr emplace(size_type, Args&&...); + ErrorOr insert(size_type, T&&); + ErrorOr insert(size_type, const T&); iterator begin() { return iterator (m_data); } const_iterator begin() const { return const_iterator(m_data); } @@ -62,15 +62,15 @@ namespace BAN const T& front() const; T& front(); - [[nodiscard]] ErrorOr resize(size_type); - [[nodiscard]] ErrorOr reserve(size_type); + ErrorOr resize(size_type); + ErrorOr reserve(size_type); bool empty() const; size_type size() const; size_type capacity() const; private: - [[nodiscard]] ErrorOr ensure_capacity(size_type); + ErrorOr ensure_capacity(size_type); private: T* m_data = nullptr; diff --git a/kernel/include/kernel/Scheduler.h b/kernel/include/kernel/Scheduler.h index a0b5957c2..9e3af85cc 100644 --- a/kernel/include/kernel/Scheduler.h +++ b/kernel/include/kernel/Scheduler.h @@ -19,7 +19,7 @@ namespace Kernel const Thread& current_thread() const; template - [[nodiscard]] BAN::ErrorOr add_thread(const BAN::Function& func, Args... args) + BAN::ErrorOr add_thread(const BAN::Function& func, Args... args) { uintptr_t flags; asm volatile("pushf; pop %0" : "=r"(flags));