From 954898b14ddfd7a64290ce8325a3b2ad8356660c Mon Sep 17 00:00:00 2001 From: Bananymous Date: Mon, 25 May 2026 01:06:59 +0300 Subject: [PATCH] Kernel: Fix file backed mmap syncing, my if condition was inverted --- kernel/kernel/Memory/FileBackedRegion.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/kernel/Memory/FileBackedRegion.cpp b/kernel/kernel/Memory/FileBackedRegion.cpp index 6c41a0a5..8a2ac801 100644 --- a/kernel/kernel/Memory/FileBackedRegion.cpp +++ b/kernel/kernel/Memory/FileBackedRegion.cpp @@ -93,7 +93,7 @@ namespace Kernel void SharedFileData::sync_no_lock(size_t page_index) { - if (pages[page_index] == 0 || BAN::atomic_load(writers[page_index]) == 0) + if (pages[page_index] == 0 || BAN::atomic_load(writers[page_index]) > 0) return; uint8_t page_buffer[PAGE_SIZE]; @@ -108,8 +108,9 @@ namespace Kernel BAN::ErrorOr FileBackedRegion::msync(vaddr_t address, size_t size, int flags) { - if (flags != MS_SYNC) - dprintln("async file backed mmap msync"); + // TODO: maybe do something with the flags :) + (void)flags; + if (m_type != Type::SHARED) return {};