From 0a8b03d34913b50797e84b453770aa9a538d3d63 Mon Sep 17 00:00:00 2001 From: Bananymous Date: Thu, 2 Jul 2026 19:55:12 +0300 Subject: [PATCH] LibAudio: Make AudioLoaders return float instead of double AudioBuffers already use floats internally so there is no need for loaders to produces doubles --- userspace/libraries/LibAudio/AudioLoaders/WAVLoader.cpp | 8 ++++---- .../libraries/LibAudio/include/LibAudio/AudioLoader.h | 2 +- .../LibAudio/include/LibAudio/AudioLoaders/WAVLoader.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/userspace/libraries/LibAudio/AudioLoaders/WAVLoader.cpp b/userspace/libraries/LibAudio/AudioLoaders/WAVLoader.cpp index 028aaef1..84d33508 100644 --- a/userspace/libraries/LibAudio/AudioLoaders/WAVLoader.cpp +++ b/userspace/libraries/LibAudio/AudioLoaders/WAVLoader.cpp @@ -105,17 +105,17 @@ namespace LibAudio } template - static double read_sample(BAN::ConstByteSpan data) + static float read_sample(BAN::ConstByteSpan data) { if constexpr(BAN::is_same_v || BAN::is_same_v) return data.as(); else if constexpr(BAN::is_signed_v) - return data.as() / static_cast(BAN::numeric_limits::max()); + return data.as() / static_cast(BAN::numeric_limits::max()); else - return data.as() / (BAN::numeric_limits::max() / 2.0) - 1.0; + return data.as() / (BAN::numeric_limits::max() / 2.0f) - 1.0f; } - double WAVAudioLoader::get_sample() + float WAVAudioLoader::get_sample() { ASSERT(samples_remaining() > 0); diff --git a/userspace/libraries/LibAudio/include/LibAudio/AudioLoader.h b/userspace/libraries/LibAudio/include/LibAudio/AudioLoader.h index eb3f36a3..b5325865 100644 --- a/userspace/libraries/LibAudio/include/LibAudio/AudioLoader.h +++ b/userspace/libraries/LibAudio/include/LibAudio/AudioLoader.h @@ -19,7 +19,7 @@ namespace LibAudio virtual uint32_t sample_rate() const = 0; virtual uint32_t samples_remaining() const = 0; - virtual double get_sample() = 0; + virtual float get_sample() = 0; protected: AudioLoader() = default; diff --git a/userspace/libraries/LibAudio/include/LibAudio/AudioLoaders/WAVLoader.h b/userspace/libraries/LibAudio/include/LibAudio/AudioLoaders/WAVLoader.h index a81e7a97..4fb7b1be 100644 --- a/userspace/libraries/LibAudio/include/LibAudio/AudioLoaders/WAVLoader.h +++ b/userspace/libraries/LibAudio/include/LibAudio/AudioLoaders/WAVLoader.h @@ -24,7 +24,7 @@ namespace LibAudio uint32_t sample_rate() const override { return m_sample_rate; } uint32_t samples_remaining() const override { return m_total_samples - m_current_sample; } - double get_sample() override; + float get_sample() override; private: uint32_t m_channels { 0 };