From 0299d4d44e2e2de0f3f14c7582886eead04e204c Mon Sep 17 00:00:00 2001 From: Bananymous Date: Fri, 16 Jan 2026 15:57:36 +0200 Subject: [PATCH] Kernel/LibC: remove SYS_TERMID This syscall is not needed. /dev/tty is already a symlink to the controlling terminal. Also this syscall did not handle pseudo terminals --- kernel/include/kernel/Process.h | 2 -- kernel/kernel/Process.cpp | 19 ------------------- .../libraries/LibC/include/sys/syscall.h | 1 - userspace/libraries/LibC/stdio.cpp | 2 +- 4 files changed, 1 insertion(+), 23 deletions(-) diff --git a/kernel/include/kernel/Process.h b/kernel/include/kernel/Process.h index 9c166977..93e876af 100644 --- a/kernel/include/kernel/Process.h +++ b/kernel/include/kernel/Process.h @@ -218,8 +218,6 @@ namespace Kernel BAN::ErrorOr sys_tcgetpgrp(int fd); BAN::ErrorOr sys_tcsetpgrp(int fd, pid_t pgid); - BAN::ErrorOr sys_termid(char*); - BAN::ErrorOr sys_clock_gettime(clockid_t, timespec*); BAN::ErrorOr sys_load_keymap(const char* path); diff --git a/kernel/kernel/Process.cpp b/kernel/kernel/Process.cpp index 46ca6d68..4702ef3e 100644 --- a/kernel/kernel/Process.cpp +++ b/kernel/kernel/Process.cpp @@ -2741,26 +2741,7 @@ namespace Kernel return 0; } - BAN::ErrorOr Process::sys_termid(char* buffer) { - LockGuard _(m_process_lock); - - TRY(validate_string_access(buffer)); - - auto& tty = m_controlling_terminal; - - if (!tty) - buffer[0] = '\0'; - else - { - ASSERT(minor(tty->rdev()) < 10); - strcpy(buffer, "/dev/tty0"); - buffer[8] += minor(tty->rdev()); - } - - return 0; - } - BAN::ErrorOr Process::sys_clock_gettime(clockid_t clock_id, timespec* tp) { LockGuard _(m_process_lock); diff --git a/userspace/libraries/LibC/include/sys/syscall.h b/userspace/libraries/LibC/include/sys/syscall.h index 2d0eb4a1..8105cfee 100644 --- a/userspace/libraries/LibC/include/sys/syscall.h +++ b/userspace/libraries/LibC/include/sys/syscall.h @@ -9,7 +9,6 @@ __BEGIN_DECLS O(SYS_EXIT, exit) \ O(SYS_READ, read) \ O(SYS_WRITE, write) \ - O(SYS_TERMID, termid) \ O(SYS_CLOSE, close) \ O(SYS_OPENAT, openat) \ O(SYS_SEEK, seek) \ diff --git a/userspace/libraries/LibC/stdio.cpp b/userspace/libraries/LibC/stdio.cpp index 1b6c6dad..164f82fd 100644 --- a/userspace/libraries/LibC/stdio.cpp +++ b/userspace/libraries/LibC/stdio.cpp @@ -138,7 +138,7 @@ char* ctermid(char* buffer) { static char s_buffer[L_ctermid]; char* target = buffer ? buffer : s_buffer; - syscall(SYS_TERMID, target); + strcpy(buffer, "/dev/tty"); return target; }